[Bug 14544] New: Move the list related code to Koha::Virtualshelves

newer
[Bug 15374] New: Translatability:...

older
[Bug 7710] New: multiple holds per...

bugzilla-daemon＠bugs.koha-community.org

16 Jul 2015 16 Jul '15

7:07 p.m.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Bug ID: 14544 Summary: Move the list related code to Koha::Virtualshelves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Lists Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl There are some bugs in the list module which are not fixable easily, because of the (very) ugly C4::VirtualShelves::Page package. This module is completely stuck and there is no other way to rewrite it completely to make it move again. -- You are receiving this mail because: You are watching all bug changes.

Show replies by date

bugzilla-daemon＠bugs.koha-community.org

16 Jul 16 Jul

7:37 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41042&action=edit Bug 14544: WIP - Get rid of GetShelves This does not work. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:52 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

7:52 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13019 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 [Bug 13019] Add base classes on which to build Koha objects -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:09 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Based on my initial skimming of the patches, I think this looks great! The only very minor nitpicky suggestion would be the naming of the clases. You could rename Koha::Virtualshelf to Koha::List and Koha::Virtualshelfshares to Koha::List::Sharess or something along those lines so that we can start down the road to having our internal nomenclature match our external nomenclature. What do you think of that Jonathan? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Jul 17 Jul

12:23 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

4 Aug 4 Aug

11:07 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #11)

...

Based on my initial skimming of the patches, I think this looks great!

The only very minor nitpicky suggestion would be the naming of the clases. You could rename Koha::Virtualshelf to Koha::List and Koha::Virtualshelfshares to Koha::List::Sharess or something along those lines so that we can start down the road to having our internal nomenclature match our external nomenclature.

What do you think of that Jonathan?

It seems that a consensus on the name is not reach :) And I really don't want to rewrite the job already done or wait to find a name... I am sure it will be quite easy to rename everything (tables and classes) when this change will be done. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Aug 6 Aug

4:34 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

18 Aug 18 Aug

3:55 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41601&action=edit Bug 14544: Remove wrong tips about permissions The owner of a list should not need any permission to remove contents. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:55 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

20 Aug 20 Aug

2:59 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:10 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14517 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:15 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #42 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Patch "Make the intranet side independent of Page.pm" needs rebase since Bug 14517 is pushed. Nice job btw -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #62 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- There is a little error in opac/opac-addbybiblionumber.pl : Line 120 : $shelf-> This brakes the addition of records in a list. Other point : I see in opac/opac-addbybiblionumber.pl : } else { # TODO } Why not using $errcode ? like in virtualshelves/addbybiblionumber.pl ? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:18 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41766&action=edit Bug 14544: (follow-up) Get rid of ShelfPossibleAction -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:20 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #62)

...

There is a little error in opac/opac-addbybiblionumber.pl : Line 120 : $shelf-> This brakes the addition of records in a list.

Oops, fixed!

...

Other point : I see in opac/opac-addbybiblionumber.pl : } else { # TODO } Why not using $errcode ? like in virtualshelves/addbybiblionumber.pl ?

Because it didn't before the changes, and I would like to submit another patchset to fix the 2 addbybiblionumber scripts. Not in the scope of this bug report. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:30 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #65 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #64)

...

(In reply to Fridolin SOMERS from comment #62)

...
There is a little error in opac/opac-addbybiblionumber.pl : Line 120 : $shelf-> This brakes the addition of records in a list.

Oops, fixed!

It works fine, i continue testing -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

25 Aug 25 Aug

2 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #66 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Small bugs in : koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt 1/ Line 20, the closing span tag is missing : <span>anyone else to add entries. 2/ In [% BLOCK list_permissions %] the permissions vars must be called from "shelf" : [% IF allow_add %] must be [% IF shelf.allow_add %] Idem for allow_delete_own and allow_delete_other 3/ In breadcrumbs, a <li></li> tag has been removed. It was : <li><a href="/cgi-bin/koha/opac-shelves.pl?display=privateshelves">Your lists</a></li> Direct text is not correct inside a <ul></ul>. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

2:15 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #67 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41909&action=edit Bug 14544: Fix several minor fixes at the OPAC follow-up for Bug 14544: Remove wrong tips about permissions and Bug 14544: Make the OPAC side independent of Page.pm -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:16 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

2:41 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #69 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #68)

...

Created attachment 41910 [details] [review] Bug 14544: Fix several minor bugs at the OPAC

In breadcrumbs, › must also be inside a <li>. Like in ISBD view : <li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">›</span></li> <li><a href="#">ISBD view</a></li> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:47 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #70 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- 4/ I've noticed that when editing a list, the HTML warnings show there are 2 useless ending div tags. I think the correction is : diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt index 245a8dd..e5c40db 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt @@ -705,13 +705,13 @@ <p>No private lists.</p> [% END %] [% END %] + </div> + </div> [% ELSIF NOT loggedinusernumber %] [% IF Koha.Preference( 'opacuserlogin' ) == 1 %] <div class="alert alert-info"><a href="/cgi-bin/koha/opac-user.pl">Log in</a> to create new lists.</div> [% END %] [% END # IF loggedinusername %] - </div> - </div> </div>  </div>  </div>  -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:13 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

3:15 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

3:37 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:48 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14528 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:58 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #73 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41915&action=edit Bug 14544: Do not use shelf as a variable loop Otherwise the shelf variable send from the pl script is overwrite -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:03 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

4:12 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #75 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41918&action=edit Bug 14544: Fix redirect on editing a list If you edit a list from the list view, after saving the form, you are not redirected to the list view (but on the edit form). -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:18 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #76 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41919&action=edit Bug 14544: Cosmetic: › should be a class divider -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:33 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #77 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41924&action=edit Bug 14544: Fix regression: checkboxes'values are empty They should be filled with the biblionumber -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:53 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #78 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41927&action=edit Bug 14544: Pass the itemtype description and notforloan to the template Before it was returned by GetShelfContents and the join on itemtype. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:10 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #79 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41931&action=edit Bug 14544: Allow a user to delete his own contents -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:10 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #80 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41932&action=edit Bug 14544: Remove warnings in tests -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

26 Aug 26 Aug

2:46 p.m.

bugzilla-daemon＠bugs.koha-community.org

3:36 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

3:48 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #114 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41988&action=edit Bug 14544: DB Changes: Set a default value for sortfield -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:39 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #115 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- A behaviour I'm not sure it is the scope of this bug : - Log-in with a user A at intranet - Create a public list - Add some records - Allow anyone else to add entries and anyone to remove his own contributed entries, do not allow any user to remove any entries - Log-in with a user B at OPAC - View the list - You see links "Remove from this list" on every record, even if they where added by another user => It would be better to show this link only in records you can remove - When clicked and alert accepted, you get the message "No biblio has been removed." (records are not removed) => You should get a message of "unauthorized_on_remove_biblios" - Select some records - Click on "Remove from list" - You get no message (records are not removed) => Not sure what to do here because you may be allowed on some selected records -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:15 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #116 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's the expected behavior, at least the one before this patch. But I completely agree, it could be improved. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1 Sep 1 Sep

10:22 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli@cineca.it Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:51 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli@cineca.it | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 Sep 2 Sep

10:11 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #117 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 42192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42192&action=edit Bug 14544 - Handle database error when creating a shelf with DB admin account -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:48 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #118 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Alex Arnaud from comment #117)

...

Created attachment 42192 [details] [review] Bug 14544 - Handle database error when creating a shelf with DB admin account

I think this is not useful, the DB admin account should not be used for anything else than create a first superlibrarian user. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

...

I think this is not useful, the DB admin account should not be used for anything else than create a first superlibrarian user. It was the behavior before this patches. And, isn't it better to have a message

bugzilla-daemon＠bugs.koha-community.org

1:14 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #120 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We cannot track all the places this check should be done. It's a waste of time. But I am not against your patch, except that the Exception shouldn't be VirtualShelves specific (should be Koha::Exceptions::UseDbAdminAccount IMO). -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

2:42 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #142 from Alex Arnaud <alex.arnaud@biblibre.com> --- Didn't see any *new* bugs/issues so i signed off all the patches (except mine). But Why don't use this BZ to fix existing problems on virtualshelves system (Like the one shown by Fridolin)? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:45 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #143 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Alex Arnaud from comment #142)

...

Didn't see any *new* bugs/issues so i signed off all the patches (except mine).

But Why don't use this BZ to fix existing problems on virtualshelves system (Like the one shown by Fridolin)?

Because it's a huge change enough :) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Sep 17 Sep

10:43 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

10:45 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8 Oct 8 Oct

10:08 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #145 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I am planning to look at this patch set tomorrow, but I still have: Applying: Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page fatal: sha1 information is lacking or useless (catalogue/detail.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

11:12 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #167 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #145)

...

I am planning to look at this patch set tomorrow, but I still have:

Applying: Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page fatal: sha1 information is lacking or useless (catalogue/detail.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.

Patches rebased against master. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:34 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #168 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #167)

...

(In reply to Marcel de Rooy from comment #145)

...
I am planning to look at this patch set tomorrow, but I still have:

Applying: Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page fatal: sha1 information is lacking or useless (catalogue/detail.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.

Patches rebased against master.

Thanks. Applies now. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9 Oct 9 Oct

8:07 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #169 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking at this now. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:08 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:30 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #170 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 43296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43296&action=edit Bug 14544: [QA Follow-up] Fix warning about transaction When running Virtualshelves.t, you have this warning: DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1339. By moving the DBI lines after creating the TestBuilder object, the warning will be gone. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:42 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13995 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:54 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #171 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Great job !!! Lot of work involved. Still have some points for consideration: OPAC -- View contents of a list -- Send shelf - Crash Can't call method "can_be_viewed" on an undefined value at /home/koha/testclone/opac/opac-sendshelf.pl line 55. *BLOCKER* OPAC - View contents of a list - Sort by callnumber - Bang DBIx::Class::ResultSet::next(): Unknown column 'itemcallnumber' in 'order clause' at /home/koha/testclone/opac/opac-shelves.pl line 236 *BLOCKER* OPAC - Lists- Open a shared list where you do not have permission to remove items of someone else. Try to remove such an item. No success, but no warning too! IIRC There was a warning in the past about some items not deleted.. Now try to remove a item you added yourself to that list while having permission to remove your own entries. This does not work ! No items are deleted, no message. I am inclined to see this last point as a *BLOCKER* too. OPAC - View list - Delete your own item while the perms are ADD or DDD. Should not be possible. But the owner is able to now. This is change of behavior and not consistent with the wording of those permissions "Do not allow anyone to remove his own contributed entries" (including your own!). I would view it as a sort of Readonly list where you cannot accidentally delete your own items. (Note however that adding is still possible.) I am inclined to see this last point as a *BLOCKER* too (but I may not be completely neutral here :) + # FIXME + # This does not make sense, but it's has been backported from DelFromShelf. + # Why shouldn't we allow to remove his own contribution if allow_delete_other is on? Code Exceptions.pm module comes in now with a dependency Exception::Class. The description => "poeut" still needs some attention apparently :) Not sure what it means btw.. Although this looks good to me on itself, this dev should probably better have gone on its own report. Note there is another report too (13995). It kind of creeps in now. OPAC - Share a list - Enter email address - Return to your lists: This list does not exist ?? op=view && category=1. Adjust the URL? OPAC - I shared a list with AAD perms. The other user could add a few entries. After that removed the share. Now come back as owner of the list and try to remove one item of yourself and one of the other user. You will get the message: The item has been removed from the list. This is not completely true: You could only remove one item; the other is not permitted. OPAC - Create a new list - Starts with permissions D D D - Would it not be better to default to D A D ? Note that if I create a list with save to new list, it does default to DAD. So this is a minor inconsistency.. OPAC - View a list: For a list with ADD or DDD perms, the button Remove could be hidden or disabled? Might be the case now too btw. OPAC Detail - List(s) this item appears in: [nothing filled while expected] I click from view a (private) list on one entry. So go to opac detail. Should I expect that list to be mentioned now? It is not. Staff - View public lists [Related to another report] With the delete public lists permission I can delete the public list of another user. OK The staff user probably has a good reason to do so. Just noting that it would perhaps be more friendly to switch it to Private instead of a rigourous Delete? Code in opac-addbybiblionumber.pl: HandleSelectedShelf: Empty TODO in an else branch. Noting for the record. Code t/db_dependent/Utils/Datatables_Virtualshelves.t and C4/Utils/DataTables/VirtualShelves.pm This is only justified/used by svc/virtualshelves/search Isn't this the time to move this svc script to Koha::Virtualshelves too ? Or at least on another report ? Database design: Do we still need (or use) virtualshelfcontents.flags ? Could a dbrev remove it now? An observation (which could be considered as outside the scope): Add an item to the list with a barcode (in staff) is somewhat strange. You cannot add items, only biblios. This is current situation already. Just for completeness :) Moving the status to FQA now to reflect the need for some adjustments/clarifications. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12 Oct 12 Oct

11:39 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #172 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #171)

...

QA Comment: Great job !!! Lot of work involved.

Thanks a lot for Qaing this! Very useful feedback :)

...

Still have some points for consideration:

OPAC -- View contents of a list -- Send shelf - Crash Can't call method "can_be_viewed" on an undefined value at /home/koha/testclone/opac/opac-sendshelf.pl line 55. *BLOCKER*

Fixed! The shelfnumber param was not passed. I have also add a test in the pl file to avoid this crash when viewing an non-existing shelf (now display 'not authorized', which is the current behavior).

...

OPAC - View contents of a list - Sort by callnumber - Bang DBIx::Class::ResultSet::next(): Unknown column 'itemcallnumber' in 'order clause' at /home/koha/testclone/opac/opac-shelves.pl line 236 *BLOCKER*

Fixed! But... This is a bad one. In opac-shelves.pl and shelves.pl, the join was only done on biblio. But itemcallnumber is in the items table. I had to add the biblio<=>biblioitems<=>items relationship to the Schema and a PK on virtualshelfcontents table (DBIx::Class::Storage::DBIHacks::_adjust_select_args_for_complex_prefetch(): Unable to perform complex limited prefetch off Virtualshelfcontent without declared primary key). Fixed in a separate patch. Note that bug 14819 is stuck in the NSO status but also adds the relationships.

...

OPAC - Lists- Open a shared list where you do not have permission to remove items of someone else. Try to remove such an item. No success, but no warning too! IIRC There was a warning in the past about some items not deleted.. Now try to remove a item you added yourself to that list while having permission to remove your own entries. This does not work ! No items are deleted, no message. I am inclined to see this last point as a *BLOCKER* too.

Fixed! The "op" was "view" instead of "remove_biblios" on the submit button. Note that the individual links work (and intranet is ok).

...

OPAC - View list - Delete your own item while the perms are ADD or DDD. Should not be possible. But the owner is able to now. This is change of behavior and not consistent with the wording of those permissions "Do not allow anyone to remove his own contributed entries" (including your own!). I would view it as a sort of Readonly list where you cannot accidentally delete your own items. (Note however that adding is still possible.) I am inclined to see this last point as a *BLOCKER* too (but I may not be completely neutral here :) + # FIXME + # This does not make sense, but it's has been backported from DelFromShelf. + # Why shouldn't we allow to remove his own contribution if allow_delete_other is on?

Well, not fixed. I have asked on #koha and Nicole agreed (http://irc.koha-community.org/koha/2015-08-18#i_1716925). So I am not sure what to do here.

...

Code Exceptions.pm module comes in now with a dependency Exception::Class. The description => "poeut" still needs some attention apparently :) Not sure what it means btw.. Although this looks good to me on itself, this dev should probably better have gone on its own report. Note there is another report too (13995). It kind of creeps in now.

poeut is a typo for pouet which does not mean anything :) The exceptions implementation can be modified easily later (the question was: should we put all exceptions in 1 file, all exceptions of a given module in 1 file or 1 exception per file).

...

OPAC - Share a list - Enter email address - Return to your lists: This list does not exist ?? op=view && category=1. Adjust the URL?

Fixed! Yes, the op is 'list', not 'view".

...

OPAC - I shared a list with AAD perms. The other user could add a few entries. After that removed the share. Now come back as owner of the list and try to remove one item of yourself and one of the other user. You will get the message: The item has been removed from the list. This is not completely true: You could only remove one item; the other is not permitted.

This is a specific case and I would prefer to manage it in a separate bug report. I am not sure this work on master :)

...

OPAC - Create a new list - Starts with permissions D D D - Would it not be better to default to D A D ? Note that if I create a list with save to new list, it does default to DAD. So this is a minor inconsistency..

Yes, and it's a regression. Fixed on both interface (I have c/p OPAC code for the intranet).

...

OPAC - View a list: For a list with ADD or DDD perms, the button Remove could be hidden or disabled? Might be the case now too btw.

Not easily, and there is no regression here: it's how it works currently. The problem is that the queries done in remove_biblios should be executed for each biblio in the list. Maybe not a big deal, to investigate...

...

OPAC Detail - List(s) this item appears in: [nothing filled while expected] I click from view a (private) list on one entry. So go to opac detail. Should I expect that list to be mentioned now? It is not.

Fixed! In the template shelves->count should be check, not only the shelves variable (which is always defined).

...

Staff - View public lists [Related to another report] With the delete public lists permission I can delete the public list of another user. OK The staff user probably has a good reason to do so. Just noting that it would perhaps be more friendly to switch it to Private instead of a rigourous Delete?

Todo later yes.

...

Code in opac-addbybiblionumber.pl: HandleSelectedShelf: Empty TODO in an else branch. Noting for the record.

Yes, I preferred to add the TODO marked than nothing, but no regression here.

...

Code t/db_dependent/Utils/Datatables_Virtualshelves.t and C4/Utils/DataTables/VirtualShelves.pm This is only justified/used by svc/virtualshelves/search Isn't this the time to move this svc script to Koha::Virtualshelves too ? Or at least on another report ?

Not ready yet. The rewrite should use the REST api.

...

Database design: Do we still need (or use) virtualshelfcontents.flags ? Could a dbrev remove it now?

To investigate, but yes, I am not sure to have found any usefulness to this column.

...

An observation (which could be considered as outside the scope): Add an item to the list with a barcode (in staff) is somewhat strange. You cannot add items, only biblios. This is current situation already. Just for completeness :)

Changing the wording could maybe fix the ambiguity. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:46 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #173 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43334&action=edit Bug 14544: Add missing biblio <=> biblioitems <=> items relationships to the schema -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:47 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #174 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43335&action=edit Bug 14544: QA fixes - some minor bug fixes See comment 171 and 172 for more details. This patch mainly fixes typo or silly error in templates. It also uses the relationships added by previous patch to join the biblioitems and items tables (changes in opac-shelves.pl and shelves.pl). -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:02 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #175 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> ---

...

From IRC http://irc.koha-community.org/koha/2015-08-18 === 11:24 Joubu: nengard: Don't you think the following does not make sense? : "The owner of a list is always allowed to add entries, but needs permission to remove." 11:25 nengard that makes no sense at all ===

Well, i do not agree that it make no sense at all.. Although this is not the most important issue on lists, but just a detail, such a short conversation on irc is not the decisive factor for me to justify changing current behavior. Also note that the question is formulated rather suggestive. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:12 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #176 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #175)

...

From IRC http://irc.koha-community.org/koha/2015-08-18 === 11:24 Joubu: nengard: Don't you think the following does not make sense? : "The owner of a list is always allowed to add entries, but needs permission to remove." 11:25 nengard that makes no sense at all ===

Well, i do not agree that it make no sense at all.. Although this is not the most important issue on lists, but just a detail, such a short conversation on irc is not the decisive factor for me to justify changing current behavior. Also note that the question is formulated rather suggestive.

I don't have a strong opinion on it. I have to admit I did not see the "readonly list" feature, and it could make sense. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

14 Oct 14 Oct

4:10 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

4:11 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #177 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43403&action=edit Bug 14544: allow_delete_own == 0 could represent a read-only list This patch reintroduces the previous behavior. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:12 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #178 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marcel, The last patch reintroduces the read-only list feature/bug :) If we decide later to remove it, we would be able to do it reverting this patch! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:17 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #179 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I plan to look at this again Friday. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

10:55 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

...

...
OPAC - Share a list - Enter email address - Return to your lists: This list does not exist ?? op=view && category=1. Adjust the URL? Fixed! Yes, the op is 'list', not 'view". Fixed?? This is still a problem. Did you test it? (No blocker for such a large

...

Fixed! But... This is a bad one. In opac-shelves.pl and shelves.pl, the join was only done on biblio. But itemcallnumber is in the items table. I had to add the biblio<=>biblioitems<=>items relationship to the Schema and a PK on virtualshelfcontents table (DBIx::Class::Storage::DBIHacks::_adjust_select_args_for_complex_prefetch(): Unable to perform complex limited prefetch off Virtualshelfcontent without declared primary key). But this is not completely solved. View a private list in opac or staff: Bang. DBIx::Class::ResultSet::next(): Operation requires a primary key to be declared on 'Virtualshelfcontent' via set_primary_key How did you test this? :) Apparently, you forgot to include this added PK in your patches. Fixed by a hack now: added set_primary_key in Virtualshelfcontent in the local

...

Fixed! The "op" was "view" instead of "remove_biblios" on the submit button. Note that the individual links work (and intranet is ok). I removed two items. One should not be removed, the other should. This works now, but the message is not really clear. No blocker.

...

The last patch reintroduces the read-only list feature/bug :) If we decide later to remove it, we would be able to do it reverting this patch! Applying: Bug 14544: allow_delete_own == 0 could represent a read-only list Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Virtualshelves.t CONFLICT (content): Merge conflict in t/db_dependent/Virtualshelves.t At this time I rather obsolete this additional patch. The wording was removed, the behavior slightly changed. No need to test this now. It has been just a reminder that changing behavior may need more communication than one incidental IRC chat :)

Additional observation: The Author and [Date added] column in the shelf view on staff are empty. (With and without the last four follow-up patches.) Passed QA -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:56 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #207 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note to RM Another db rev may follow from Jonathan to correct the mentioned PK issue with DBIx. Please note that you get Koha::Exception too now. (See earlier QA comment.) An early push may help us to detect if this patch set still contains some further issues. But it looks quite good. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:50 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #208 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43485&action=edit Bug 14544: Fix 'back to lists' link -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:53 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #209 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #206)

...

QA Comment [Continuation]:

Thanks again for your hard work.

...
...
OPAC - Share a list - Enter email address - Return to your lists: This list does not exist ?? op=view && category=1. Adjust the URL? Fixed! Yes, the op is 'list', not 'view". Fixed?? This is still a problem. Did you test it? (No blocker for such a large patch, but ... Do you miss the shelf number?)

Hum no, I have tested the link just before the form submit! The last patch fixes that.

...

...
Fixed! But... This is a bad one. In opac-shelves.pl and shelves.pl, the join was only done on biblio. But itemcallnumber is in the items table. I had to add the biblio<=>biblioitems<=>items relationship to the Schema and a PK on virtualshelfcontents table (DBIx::Class::Storage::DBIHacks::_adjust_select_args_for_complex_prefetch(): Unable to perform complex limited prefetch off Virtualshelfcontent without declared primary key). But this is not completely solved. View a private list in opac or staff: Bang. DBIx::Class::ResultSet::next(): Operation requires a primary key to be declared on 'Virtualshelfcontent' via set_primary_key How did you test this? :) Apparently, you forgot to include this added PK in your patches. Fixed by a hack now: added set_primary_key in Virtualshelfcontent in the local section. Please adjust this by defining the PK on the table and regenerating the DBIx file. Note also that I removed the belongs_to from Biblioitem to Item. This is not a FK but a PK.

With my previous branch (so without your follow-ups), I have regenerated the schema and I don't get an error viewing a private list. That's why I have added the belongs_to rs. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:02 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #210 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43486&action=edit Bug 14544: Fixes regression: display author and dateadded on the list view [intranet] -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:03 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #211 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #206)

...

Additional observation: The Author and [Date added] column in the shelf view on staff are empty. (With and without the last four follow-up patches.)

See last patch. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:24 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #212 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #208)

...

Created attachment 43485 [details] [review] Bug 14544: Fix 'back to lists' link

Sure about the location? sendshelf? Creating a share is shareshelf? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:26 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #213 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #212)

...

(In reply to Jonathan Druart from comment #208)

...
Created attachment 43485 [details] [review] [review] Bug 14544: Fix 'back to lists' link

Sure about the location? sendshelf? Creating a share is shareshelf?

Erk, no! So there is another one missing. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:30 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #214 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43487&action=edit Bug 14544: Fix 'Back to lists' links on sharing a shelf -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:31 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #215 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #212)

...

(In reply to Jonathan Druart from comment #208)

...
Created attachment 43485 [details] [review] [review] Bug 14544: Fix 'back to lists' link

Sure about the location? sendshelf? Creating a share is shareshelf?

Sorry about that. I am sure I have fixed it already but I have certainly lost it during a rebase -i. Now it works! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

29 Oct 29 Oct

4:51 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

4:51 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15084 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4 Nov 4 Nov

3:07 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #216 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

2:37 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #238 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10 Nov 10 Nov

8:15 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Lists |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11 Nov 11 Nov

2:19 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #239 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44758&action=edit Bug 14544: Remove debug line -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:11 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #240 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Thanks for the followup, Jonathan! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12 Nov 12 Nov

10:13 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

13 Nov 13 Nov

4:03 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #241 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44845&action=edit Bug 14544: Fix regression on sending an email from staff The shelfnumber was not filled and result in a software error Can't call method "get_contents" on an undefined value at /home/koha/src/virtualshelves/sendshelf.pl line 74. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:22 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15137 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:50 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

14 Nov 14 Nov

3 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44852|0 |1 is obsolete| | --- Comment #243 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44863&action=edit [SIGNED-OFF] Bug 14544: Fix regression on sending an email from staff The shelfnumber was not filled and result in a software error Can't call method "get_contents" on an undefined value at /home/koha/src/virtualshelves/sendshelf.pl line 74. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Whith patch mail is sent. No errors -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Nov 16 Nov

12:05 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44863|0 |1 is obsolete| | --- Comment #244 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44872&action=edit [PASSED QA] Bug 14544: Fix regression on sending an email from staff The shelfnumber was not filled and result in a software error Can't call method "get_contents" on an undefined value at /home/koha/src/virtualshelves/sendshelf.pl line 74. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Whith patch mail is sent. No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:05 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

bugzilla-daemon＠bugs.koha-community.org

12:06 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:52 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15137 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 [Bug 15137] List email sent from staff is missing ISBN and author information -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:58 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #246 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Followup pushed to master. Thanks Jonathan, again! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

25 Nov 25 Nov

9:51 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15137 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15137 [Bug 15137] List email sent from staff is missing ISBN and author information -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3 Dec 3 Dec

4:07 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15293 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

15 Dec 15 Dec

4:01 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15379 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

12:11 p.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15453 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15453 [Bug 15453] Cannot download a list in the staff interface -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

13 Jan 13 Jan

11:09 a.m.

New subject: [Bug 14544] Move the list related code to Koha::Virtualshelves

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15394 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 [Bug 15394] Confirm messages on OPAC lists interface strangely worded -- You are receiving this mail because: You are watching all bug changes.

3835

Age (days ago)

4016

Last active (days ago)

List overview

Download

283 comments

1 participants

participants (1)

bugzilla-daemon＠bugs.koha-community.org