https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 211331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211331&action=edit Bug 26540: (QA follow-up) Don't rely on the caller's registers variable in transaction_types.inc transaction_types.inc checked "registers.size" to decide whether CASH should be offered for payouts and refunds. That variable is set by the including page: the patron account pages get an array from the Registers.all plugin, but pos/register.pl passed a Koha::Cash::Registers resultset, which has no "size" method. The POS register page failed with: The method Koha::Cash::Registers->size is not covered by tests! The include now asks the Registers plugin itself whether the current library has any register, so it behaves the same wherever it is used. pos/register.pl no longer passes the "registers" template parameter, which register.tt never used. To test: 1. Set UseCashRegisters to 'Use' 2. Add a cash register for your library (Administration > Cash registers) 3. Go to Point of sale > Register details for that register => The page loads (before this patch: Internal Server Error) 4. Open a patron's accounting page with a credit and a paid debit => The payout and refund type selects offer 'Cash' 5. Archive the register so your library has none => On the accounting page 'Cash' is no longer offered, and the prompt to create a cash register is shown 6. Sign off -- You are receiving this mail because: You are watching all bug changes.