https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176101|0 |1 is obsolete| | --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 176836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176836&action=edit Bug 38813: Make the 'curbside pickups' tab display selected if so This patch fixes a wrong condition check in `usermenu.inc` for determining if the tab should be active. It currently checks for `ermview`, probably a copy and paste error. This patch adds a new `curbside_pickups_view` parameter that is passed instead. Note: I tidied the code block I changed, inline to avoid extra commits. To test: 1. Enable the `CurbsidePickup` system preference 2. Log into the OPAC => SUCCESS: There's a 'Curbside pickups' tab 3. Click on the tab => SUCCESS: The 'Curbside pickups' section gets displayed => FAIL: The tab remains inactive 4. Apply this patch 5. Restart plack: $ ktd --shell k$ koha-plack --restart kohadev 6. Repeat 3 => SUCCESS: The 'Curbside pickups' section gets displayed => SUCCESS: The tab is rendered as active 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.