[Bug 38813] New: Curbside pickups tab not selected in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Bug ID: 38813 Summary: Curbside pickups tab not selected in OPAC Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org When you click on the tab, it renders the right page, but the tab itself remains unselected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |tomascohen@gmail.com Status|NEW |Needs Signoff CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 176098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176098&action=edit Bug 38813: Make the 'curbside pickups' tab display selected if so This patch fixes a wrong condition check in `usermenu.inc` for determining if the tab should be active. It currently checks for `ermview`, probably a copy and paste error. This patch adds a new `curbside_pickups_view` parameter that is passed instead. Note: I tidied the code block I changed, inline to avoid extra commits. To test: 1. Enable the `CurbsidePickup` system preference 2. Log into the OPAC => SUCCESS: There's a 'Curbside pickups' tab 3. Click on the tab => SUCCESS: The 'Curbside pickups' section gets displayed => FAIL: The tab remains inactive 4. Apply this patch 5. Restart plack: $ ktd --shell k$ koha-plack --restart kohadev 6. Repeat 3 => SUCCESS: The 'Curbside pickups' section gets displayed => SUCCESS: The tab is rendered as active 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I've checked this patch also works on 24.11 and 24.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176098|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176101&action=edit Bug 38813: Make the 'curbside pickups' tab display selected if so This patch fixes a wrong condition check in `usermenu.inc` for determining if the tab should be active. It currently checks for `ermview`, probably a copy and paste error. This patch adds a new `curbside_pickups_view` parameter that is passed instead. Note: I tidied the code block I changed, inline to avoid extra commits. To test: 1. Enable the `CurbsidePickup` system preference 2. Log into the OPAC => SUCCESS: There's a 'Curbside pickups' tab 3. Click on the tab => SUCCESS: The 'Curbside pickups' section gets displayed => FAIL: The tab remains inactive 4. Apply this patch 5. Restart plack: $ ktd --shell k$ koha-plack --restart kohadev 6. Repeat 3 => SUCCESS: The 'Curbside pickups' section gets displayed => SUCCESS: The tab is rendered as active 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 176106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176106&action=edit [24.05.x] Bug 38813: Make inner tabs selected correctly On the 24.05.x branch (i.e. before the tab wrapper) the template logic is making it not select the first tab if there are no policies defined. To test: 1. Have KTD running on 24.05.x 2. Enable the `CurbsidePickups` system preference 3. Define a policy (anyone), DISABLED 4. Log into the OPAC and point your browser to <koha>/cgi-bin/koha/opac-curbside-pickups.pl => FAIL: The 'Your pickups' tab is grey (not selected) and there's no content below it 5. ENABLE the policy and reload the OPAC => SUCCESS: Notice it gives you the option to 'Schedule a pickup', selected by default. 6. Apply this patch 7. Repeat 5 => SUCCESS: No behavior change 8. Repeat 3-4 => SUCCESS: The 'Your pickups' tab is selected, and the 'No curbside pickups' message displayed 9. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Thanks Lucas, I've added a small follow-up that is 24.05 only. Maybe 23.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate, | |rel_24_11_candidate Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176101|0 |1 is obsolete| | --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 176836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176836&action=edit Bug 38813: Make the 'curbside pickups' tab display selected if so This patch fixes a wrong condition check in `usermenu.inc` for determining if the tab should be active. It currently checks for `ermview`, probably a copy and paste error. This patch adds a new `curbside_pickups_view` parameter that is passed instead. Note: I tidied the code block I changed, inline to avoid extra commits. To test: 1. Enable the `CurbsidePickup` system preference 2. Log into the OPAC => SUCCESS: There's a 'Curbside pickups' tab 3. Click on the tab => SUCCESS: The 'Curbside pickups' section gets displayed => FAIL: The tab remains inactive 4. Apply this patch 5. Restart plack: $ ktd --shell k$ koha-plack --restart kohadev 6. Repeat 3 => SUCCESS: The 'Curbside pickups' section gets displayed => SUCCESS: The tab is rendered as active 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #5)
Thanks Lucas, I've added a small follow-up that is 24.05 only. Maybe 23.11.
Hi Tomás, so for 24.05 should I be applying both patches? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 --- Comment #10 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Alex Buckley from comment #9)
(In reply to Tomás Cohen Arazi (tcohen) from comment #5)
Thanks Lucas, I've added a small follow-up that is 24.05 only. Maybe 23.11.
Hi Tomás, so for 24.05 should I be applying both patches?
That's correct! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #10)
(In reply to Alex Buckley from comment #9)
(In reply to Tomás Cohen Arazi (tcohen) from comment #5)
Thanks Lucas, I've added a small follow-up that is 24.05 only. Maybe 23.11.
Hi Tomás, so for 24.05 should I be applying both patches?
That's correct!
thanks Tomás -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- We are a bit unsure why we need to apply both the patches because once we have applied the 24.05 patch that fixes the bug. So for step 3 of the test plan in the second patch (see below) we cannot replicate the fail, because the first patch has made the tab active already: 3. Click on the tab => SUCCESS: The 'Curbside pickups' section gets displayed => FAIL: The tab remains inactive -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #13 from Jesse Maseto <jesse@bywatersolutions.com> --- Merge conflicts with 24.05.x when trying to fast-forward. Everything else looks good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38813 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x (or 23.XX) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org