http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comments: 1/ New JS lib is not added to the about page 2/ The version 1.0.2 of Chart is released (after first submission), not need to include a beta version :) 3/ If there is no result, there is no graph. But the canvas is created => 1000x400px is blank on top of the page. Moreover the button ("Click to change to...") is displayed. 4/ There is no way not to hardcode the canvas size? 1000 could be too wide on small screens. 5/ Maybe it could be better to display the graph under the table (?) 6/ Commented code in js (//circChart.update();) 7/ IMO the colors should not be defined in the pl code but in tt. Moreover the get_colors subroutine is defined twice (c/p is bad ;)) Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.