https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | --- Comment #118 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'll finish my review tomorrow. Overall, this is what I wanted to see on bug 23838, so I'm happy for this, Martin. Great! It is lacking (at least) tests for the new Koha::Checkouts::Renewal->store method. I can add it, but got late today to do it. I would like to see some higher-level method, like Koha::Checkout->renew and start removing old code but we can do that in a follow-up, this is solid as it stands. -- You are receiving this mail because: You are watching all bug changes.