[Bug 30275] New: Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

11 Mar 2022 11 Mar '22

4:10 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131603&action=edit Bug 30275: Add `/api/v1/checkouts/{checkout_id}/renewals` -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:11 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

4:17 p.m.

bugzilla-daemon＠bugs.koha-community.org

2:12 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131909&action=edit Bug 30275: Fix checkouts.t unit test We no longer require a mocked userenv for these tests to pass, we're setting the userenv in api auth now. The mock just serves to break tests for the renew method now that AddRenewal required a correctly set userenv for 'number'. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:12 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131910&action=edit Bug 30275: Add basic unit test for fetching renewals -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:27 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The simplest way to test this is to test bug 23838 which relies on this foundational patch. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

26 Apr 26 Apr

3:42 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131909|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133920&action=edit Bug 30275: Fix checkouts.t unit test We no longer require a mocked userenv for these tests to pass, we're setting the userenv in api auth now. The mock just serves to break tests for the renew method now that AddRenewal required a correctly set userenv for 'number'. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:42 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

3:42 p.m.

bugzilla-daemon＠bugs.koha-community.org

4:10 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

6:03 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #100 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133984&action=edit Bug 30275: Add renewals relation to Koha::Old::Checkout Add the new 'renewals' relation to Koha::Old::Checkout to return a list of Koha::Checkouts::Renewal objects. We also add the same relation to the OldIssue schema inline. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

27 Apr 27 Apr

9:11 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:11 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133984|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:12 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133969|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:12 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133970|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:12 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133971|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:12 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133972|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:12 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133973|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:12 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133974|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:12 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:12 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133976|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:12 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133977|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:12 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133978|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:12 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133979|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:13 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133980|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:13 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133981|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:13 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133982|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:13 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133983|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:13 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #101 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134177&action=edit Bug 30275: Add checkout_renewals table This patch adds the new checkout_renewals table using an atomicupdate Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:13 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #102 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134178&action=edit Bug 30275: Generated kohastructure.sql This kohastructure update was generated using `koha-dump --schema-only` in koha-testing-docker once the atomicupdate had been run against the previous atomicupdate patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:14 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #103 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134179&action=edit Bug 30275: DBIC Schema Changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:14 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #104 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134180&action=edit Bug 30275: Record renewals Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:14 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #105 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134181&action=edit Bug 30275: DBIC Schema Additions Add checkout and old_checkout relations to CheckoutRenewal schema and mark 'seen' as a boolean. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:14 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #106 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134182&action=edit Bug 30275: Add Koha::Objects for Renewals Add Koha::Checkouts::Renewals|Renewal classes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:14 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #107 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134183&action=edit Bug 30275: Rename issues.renewals to issues.renewals_count Rename the issues.renewals field to renewals_count to prevent a method name collision with the new relation accessor introduced by this patchset. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:14 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #108 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134184&action=edit Bug 30275: renewals_count DBIC Update Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:15 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #109 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134185&action=edit Bug 30275: Add 'renewals' relation to Issue Schema Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:15 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #110 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134186&action=edit Bug 30275: Add renewals relation to Koha::Checkout Add the new 'renewals' relation to Koha::Checkout to return a list of Koha::Checkouts::Renewal objects. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:15 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #111 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134187&action=edit Bug 30275: Add `/api/v1/checkouts/{checkout_id}/renewals` Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:15 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #112 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134188&action=edit Bug 30275: Add alias to create renewal in api routes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:15 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #113 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134189&action=edit Bug 30275: Fix checkouts.t unit test We no longer require a mocked userenv for these tests to pass, we're setting the userenv in api auth now. The mock just serves to break tests for the renew method now that AddRenewal required a correctly set userenv for 'number'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:15 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #114 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134190&action=edit Bug 30275: Add basic unit test for fetching renewals Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:16 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #115 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134191&action=edit Bug 30275: (follow-up) Rebase fixes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:16 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #116 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134192&action=edit Bug 30275: Add renewals relation to Koha::Old::Checkout Add the new 'renewals' relation to Koha::Old::Checkout to return a list of Koha::Checkouts::Renewal objects. We also add the same relation to the OldIssue schema inline. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:16 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #117 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134193&action=edit Bug 30275: (QA follow-up) Rename columns to match API This patch performs the following column renames: * id => renewal_id * issue_id => checkout_id The idea is that no translation is needed for the API, and also, being a new table, we can educate the users into the 'to be' terminology we are leaning towards, instead of having them learn one naming to create reports and then need to translate them once we normalize things in a future. That said, this is simple to review. Apply this patch and repeat the test plan. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:19 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | --- Comment #118 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'll finish my review tomorrow. Overall, this is what I wanted to see on bug 23838, so I'm happy for this, Martin. Great! It is lacking (at least) tests for the new Koha::Checkouts::Renewal->store method. I can add it, but got late today to do it. I would like to see some higher-level method, like Koha::Checkout->renew and start removing old code but we can do that in a follow-up, this is solid as it stands. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

28 Apr 28 Apr

12:57 a.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #119 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #118)

...

I would like to see some higher-level method, like Koha::Checkout->renew and start removing old code but we can do that in a follow-up

+1 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:26 a.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #120 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome, thanks for the review Tomas. I'm happy to work on tests today, revisiting it yesterday my intention was to add some more tests as I also found them to be lacking. I got held up as it appears Circulation.t is failing already due to the constraint added here.. but I can't for the life of me work out why as the data does appear to be present and correct in k-t-d where I was testing. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:19 a.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30637 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30637 [Bug 30637] Add Koha::Checkout->renew method -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:02 a.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #121 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134210&action=edit Bug 30275: (follow-up) Drop renewer_id constraint This patch fixes some unit tests by ensureing we set a valid userid for mock userenv setting so that the foreign key constraint doesn't fail and it also removes the exception class and check for renewer_id from the store method as, for example with autorenewals, the renewal may not have been triggered by a actual user. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:21 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134177|0 |1 is obsolete| | --- Comment #122 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134228&action=edit Bug 30275: Add checkout_renewals table This patch adds the new checkout_renewals table using an atomicupdate Sponsored-by: Loughborough University Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:21 p.m.

bugzilla-daemon＠bugs.koha-community.org

1:21 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

1:21 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

1:21 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134186|0 |1 is obsolete| | --- Comment #131 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134237&action=edit Bug 30275: Add renewals relation to Koha::Checkout Add the new 'renewals' relation to Koha::Checkout to return a list of Koha::Checkouts::Renewal objects. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:22 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

2 May 2 May

bugzilla-daemon＠bugs.koha-community.org

12:43 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134228|0 |1 is obsolete| | --- Comment #148 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134869&action=edit Bug 30275: Add checkout_renewals table This patch adds the new checkout_renewals table using an atomicupdate Sponsored-by: Loughborough University Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:43 p.m.

12:45 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

12:45 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

12:45 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

12:46 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #169 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just another rebase to keep it fresh -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 May 18 May

2:38 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Passed QA |Failed QA --- Comment #170 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Please run the QA scripts, there are tiny issues to fix. There are also several tests that are failing. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:50 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134869|0 |1 is obsolete| | --- Comment #171 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135123&action=edit Bug 30275: Add checkout_renewals table This patch adds the new checkout_renewals table using an atomicupdate Sponsored-by: Loughborough University Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:50 p.m.

bugzilla-daemon＠bugs.koha-community.org

3:51 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

3:51 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

3:51 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134878|0 |1 is obsolete| | --- Comment #180 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135132&action=edit Bug 30275: Add renewals relation to Koha::Checkout Add the new 'renewals' relation to Koha::Checkout to return a list of Koha::Checkouts::Renewal objects. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:52 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

3:53 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134886|0 |1 is obsolete| | --- Comment #188 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135140&action=edit Bug 30275: (follow-up) Drop renewer_id constraint This patch fixes some unit tests by ensureing we set a valid userid for mock userenv setting so that the foreign key constraint doesn't fail and it also removes the exception class and check for renewer_id from the store method as, for example with autorenewals, the renewal may not have been triggered by a actual user. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:53 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

3:53 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

3:53 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

3:56 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #192 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #170)

...

Please run the QA scripts, there are tiny issues to fix.

There are also several tests that are failing.

QA Script re-run... I've fixed the executable bit issue, and fixed up the touched lines where the script detected tabs (as discussed on IRC, I fixed those up, but the rest of the file is still tabbed) The git manip in this case I feel is helpful in the history to be able to follow the thought process.. I could possibly merge it and add a not to the commit merged.. but I've not delved into it yet. POD issue is just the standard koha_object_class stuff we add in all Schema files. Finally.. I couldn't replicate any unit test failures.. for me they all pass first time (after a reset) and subsequent runs also pass too :? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:40 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

19 May 19 May

7:25 a.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #193 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #192)

...

Finally.. I couldn't replicate any unit test failures.. for me they all pass first time (after a reset) and subsequent runs also pass too :?

Hum, confirmed. Cannot recreate today. Certainly something wrong with my DB yesterday. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:05 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #194 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #193)

...

(In reply to Martin Renvoize from comment #192)

...
Finally.. I couldn't replicate any unit test failures.. for me they all pass first time (after a reset) and subsequent runs also pass too :?

Hum, confirmed. Cannot recreate today. Certainly something wrong with my DB yesterday.

Maybe worth adding a test for 2022-05-18? Kidding -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:56 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5 Jul 5 Jul

1:36 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135123|0 |1 is obsolete| | --- Comment #195 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137146&action=edit Bug 30275: Add checkout_renewals table This patch adds the new checkout_renewals table using an atomicupdate Sponsored-by: Loughborough University Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:36 p.m.

1:38 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

1:38 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

1:38 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

bugzilla-daemon＠bugs.koha-community.org

1:59 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:59 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #216 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Jul 6 Jul

4:04 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #217 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137217&action=edit Bug 30275: (QA follow-up) Fix TestBuilder.t This patch adds 'CheckoutRenewal.checkout_id' to the list of non-foreign key relations found in _should_be_fk. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:19 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate |release-notes-needed --- Comment #218 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12 Jul 12 Jul

3:37 a.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #219 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 137598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137598&action=edit Bug 30275: (QA follow-up) Trivial fix to schema file Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:37 a.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133 [Bug 31133] TestBuilder fragile on virtual fks -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9 Aug 9 Aug

11:16 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #220 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to the 22.05.x series -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

19 Nov 19 Nov

2:21 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:23 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |renewals table to store | |details of a checkouts | |renewals. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

24 Nov 24 Nov

9:04 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

13 Dec 13 Dec

7:42 a.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala@helsinki.fi --- Comment #221 from Ere Maijala <ere.maijala@helsinki.fi> --- This introduced a backward compatibility break in the REST API by renaming the renewals field in checkouts to renewals_count. Isn't the idea of a v1 API to keep it backward compatible? Could the renewals field be added back as an alias for renewals_count? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

14 Dec 14 Dec

3:20 a.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #222 from David Cook <dcook@prosentient.com.au> --- (In reply to Ere Maijala from comment #221)

...

Isn't the idea of a v1 API to keep it backward compatible?

I think that's the idea although I don't think we've really done that in practice, unfortunately. I suppose one could argue that the v1 API isn't even complete yet... (In reply to Ere Maijala from comment #221)

...

Could the renewals field be added back as an alias for renewals_count?

I don't know the API code well enough, but that sounds like a reasonable idea to me. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:27 a.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #223 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Ere Maijala from comment #221)

...

API to keep it backward compatible? Could the renewals field be added back as an alias for renewals_count?

I agree this is annoying. The main reason for the change in the name was to reuse the 'renewals' attribute for x-koha-embed(ding) the renewals. Not sure what to do. If this is critical for the vuFind integration maintainers we could reconsider. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:11 a.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #224 from Ere Maijala <ere.maijala@helsinki.fi> --- (In reply to Tomás Cohen Arazi from comment #223)

...

(In reply to Ere Maijala from comment #221)

...
API to keep it backward compatible? Could the renewals field be added back as an alias for renewals_count?

I agree this is annoying. The main reason for the change in the name was to reuse the 'renewals' attribute for x-koha-embed(ding) the renewals.

Not sure what to do. If this is critical for the vuFind integration maintainers we could reconsider.

Fortunately this one is not critical, and since the change had already shipped in a released Koha version, going back could cause even worse confusion. VuFind has been adjusted (see https://github.com/vufind-org/vufind/commit/7d8b08fb43027dfaec2ef8417ba34c8a...), though a new release is needed for everyone to get the fix. Since renewals will be re-used (and I think for a good function), my suggestion for an alias is not a good one either. At this point I suppose what's left is a wish to avoid such changes in the future, but if they're needed, at least publish a prominent note about the BC break in release notes. v1 API being incomplete is not a problem as long as new functionality doesn't break compatibility. And even if the v1 API was considered "alpha" level and subject to change, it's really difficult for an API consumer to manage as they might not even be aware of a Koha upgrade being done. I understand it's difficult to always stay compatible, and others have failed as well even when they've introduced changes with new API versions. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 Feb 2 Feb

4:56 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29021 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29021 [Bug 29021] Automatic renewal due to RenewAccruingItemWhenPaid should not be considered Seen -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

20 Mar 20 Mar

7:37 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33284 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 [Bug 33284] checkout_renewals table retains checkout history in violation of patron privacy -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

14 Apr 14 Apr

9:24 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #225 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There was a problem reported on the koha-devel mailing list that could relate to this patch set or the feature in general: https://lists.koha-community.org/pipermail/koha-devel/2024-April/048583.html "I have updated our database from koha 21.11.10 to the current Koha 23.11.04. When searching the catalogue I get a result list, but when clicking a single hit I get an error 500. In file "plack-error.log" I have found the following line which could be the reason: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'issue.renewals_count' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 317" Could you maybe have a look if you can help to identify the source of the issue? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9 Oct 9 Oct

1:25 p.m.

New subject: [Bug 30275] Checkout renewals should be stored in their own table

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38131 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38131 [Bug 38131] ILS-DI doc still shows nenewals -- You are receiving this mail because: You are watching all bug changes.

643

Age (days ago)

1586

Last active (days ago)

List overview

Download

263 comments

1 participants

participants (1)

bugzilla-daemon＠bugs.koha-community.org