https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #157 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #154)
I have given this priority as it's quite a big change and it will give us the chance to get a lot of eyes on it next week during the hackfest.
Some notes from my own review:
1) I notice quite a lot of remaining FIXMEs. I feel like some of those should filed as follow-up bugs, like the question of sorting serial issues here:
my $items_rs = $biblio->items; + # FIXME We need to order_by serial.publisheddate if we have _order_by=+me.serial_issue_number + # FIXME Do we always need host_items => 1 or depending on a flag? + # FIXME Should we prefetch => ['issue','branchtransfer']? + my $items_rs = $biblio->items( { host_items => 1 } )->search_ordered( {}, { join => 'biblioitem' } ); $items_rs = $items_rs->filter_by_bookable if $bookable_only; + # FIXME We need to order_by serial.publisheddate if we have _order_by=+me.serial_issue_number my $items = $c->objects->search($items_rs);
Yes, there were a lot of FIXMEs. We were supposed to discuss them.
2) Untranslatables
node += '<a href="/cgi-bin/koha/catalogue/image.pl?itemnumber=%s&imagenumber=%s" title="Local cover image">'.format(id, id); node += '<img src="/cgi-bin/koha/catalogue/image.pl?thumbnail=1&imagenumber=%s" alt="Local cover image" data-link="/cgi-bin/koha/catalogue/imageviewer.pl?itemnumber=[% item.itemnumber | uri % return '<a href="/cgi-bin/koha/catalogue/search.pl?idx=hi&q=%s">%s analytics</a>'.format(row.item_id, row.analytics_count); return '<a href="/cgi-bin/koha/cataloguing/addbiblio.pl?hostbiblionumber=%s& hostitemnumber=%s">Create analytics</a>'.format(row.biblio_id, row.item_id); return '<a href="/cgi-bin/koha/cataloguing/addbiblio.pl?hostbiblionumber=%s& hostitemnumber=%s">Create analytics</a>'.format(row.biblio_id, row.item_id); return '<a href="/cgi-bin/koha/cataloguing/addbiblio.pl?hostbiblionumber=%s& hostitemnumber=%s">Create analytics</a>'.format(row.biblio_id, row.item_id); nodes += ' <li><a href="/cgi-bin/koha/tools/upload-cover-image.pl?itemnumber=%s& filetype=image"><i class="fa fa-upload"></i> Upload image</a></li>'.format(row.item_id); nodes += '<a class="btn btn-default btn-xs" href="/cgi-bin/koha/cataloguing/additem. pl?op=edititem&biblionumber=%s&itemnumber=%s#edititem"><i class="fa-solid fa-pencil"></i> Edit</a>'.format(row.biblio_id, row.item_id); nodes += '<button class="btn btn-default btn-xs details-control"><i class="fa fa-folder"></i> Manage bundle (%s|%s)</button>'.format(escape_str(row.bundle_items_not_lost_count), escape_str(row.bundle_items_lost_count));
See last patch.
3) Unit tests
Actually you removed some :D We should add some for balance and the new methods in the various .pm.
Will do on bug 36535.
4) Processing note
The processing note now always shows for a split second when doing an action like sorting columns. Not sure if that is an option, but could we make it only show if the action itself takeslike a little longer? It's just a fast blink now and you can hardly even read the "processing" (definitely for a separate bug of course)
This is not related to this patch, if we want it that needs to be done for all DT. -- You are receiving this mail because: You are watching all bug changes.