https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 --- Comment #32 from David Cook <dcook@prosentient.com.au> --- The more I read... the more I'm not convinced that build_query_compat and search_compat are the way to go. If you look at _create_query_string in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm, there is some handling for st-year. I think we might want to look at _modify_string_by_type() as well. We'll need unit tests regardless. For the controllers and template... it is still bonkers that we're passing query strings around when we can just pass the date values. Admittedly, that's a pre-existing issue. So I might spin that out as another bug report and attach it as a dependency. In any case, I'm planning to take another look at this tomorrow. -- You are receiving this mail because: You are watching all bug changes.