https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Rebased on current main. The series was last rebased in 2022, so this was more than a mechanical rebase: - API: the OpenAPI changes had to be re-added in the current style (quoted $refs, documented 404, new slip definition and path entry) and the print_slip controller now follows the idioms of the neighbouring Items.pm methods ($c->param, render_resource_not_found; unused $lang dropped). - UI: the modal markup is now Bootstrap 5 (data-bs-*), and printing relies on the existing js/modal_printer.js rather than duplicating the print handlers in the new bundle_contents_modal.js. - Notice: the atomicupdate now follows the current db_rev conventions (say_success/say_failure), the table style attribute is fixed (width:100%), and the sample notice and the atomicupdate use the same name and title. Tested in KTD: applied the atomicupdate, yarn build + restart_all, created a bundle with two items, and GET /api/v1/items/{id}/print_slips/BUNDLE returns the rendered slip (200), 404 for an unknown item or slip, 401 unauthenticated. In the staff client, checking in the bundle, scanning its contents and clicking 'View contents list' on the 'Bundle verified' message opens the modal with the title and contents from the slip; the Print button is still there. koha-qa passes. Not included: REST tests for the new route (t/db_dependent/api/v1/items.t). Happy to add them as a follow-up if useful. Restoring status to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.