https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41070 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue when release notes| |adding an order to a basket | |using the "From a new file" | |option. | | | |When adding an order from | |the staged file there was | |no warning if you didn't | |select the fund in either | |the "Select to import" or | |"Default accounting | |details" tabs. | | | |Now there is a warning if | |you don't select a fund: | |"Some funds are not defined | |in item records". --- Comment #9 from David Nind <david@davidnind.com> --- The patch still applies, and I have signed it off. Note that both the fund fields in the "Add orders from ...." page have instructions about what will be used if a fund is not selected (I don't know how to do either of these things, so can't check what happens if these are set): - Select to import tab: . Fund: Select a fund (will use default if set) - Default accounting details tab: . Fund: Select a fund (will populate orders/items if set) Does that mean that making selecting a fund shouldn't generate a warning? Testing notes: 1. Exported Programming Perl with item (biblionumber = 262). 2. Instead of step 3, I didn't do anything. Later on (steps 4-6) the "Koha item type" field is mandatory in the "Item information" tab and is not pre-polulated (in a MARC21 KTD instance). 3. Step 6: If you don't populate the "Koha item type" file in the "Item information" tab, a browser pop-up error/warning message is shown with "Some required item subfields are not set". 4. After applying the patch (step 7) and restarting everything, I also cleared the browser cache. (Which means cleaning and deleting the importing batch, and starting again.) I did this, otherwise I didn't get the pop-up 5. The browser pop-up message is "Some funds are not defined in item records". Note that the qa script complains about tidiness: qa Tag v25.05.00-1 found in /kohadevbox/koha — checking out branch main in /kohadevbox/qa-test-tools Already on 'main' Your branch is up to date with 'origin/main'. testing 1 commit(s) (applied to a81b2cf '4f Bug 16994: (QA follow-up) Align ov') Processing files [RUNNING] koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js [FAIL] koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js Result: [FAIL] koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js` Processing additional checks PASS! * Was this bug sponsored by anyone? -- You are receiving this mail because: You are watching all bug changes.