https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #42 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Nick Clemens from comment #41) Hi Nick
Tests need rebase, I got some fails
I can't replicate this: kohadev-koha@kohadevbox:/kohadevbox/koha$ ../qa-test-tools/koha-qa.pl -c 6 testing 6 commit(s) (applied to 3d06cbb '5a Bug 19889: (follow-up) update DB a') Processing files before patches |========================>| 11 / 11 (100.00%) Processing files after patches |========================>| 11 / 11 (100.00%) OK C4/Circulation.pm OK C4/Members.pm OK Koha/Checkout.pm OK Koha/Patrons.pm OK installer/data/mysql/kohastructure.sql OK installer/data/mysql/sysprefs.sql OK koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt OK t/db_dependent/Circulation.t OK t/db_dependent/Koha/Checkouts.t OK t/db_dependent/Koha/Patrons.t Processing additional checks OK!
If this relies on a syspref then the update should not attempt to convert action_logs to the issuer column - please make this a script that libraries can optionally run, or leave it out.
Good point. The retrospective migration of old issues into action_logs wasn't ideal as there are definitely cases where it could give erroneous results. I'm going to drop it.
When anonymising checkouts that have no issuer we convert NULL to the anonymous borrowernumber - I believe we should exclude these and preserve the NULL
OK, I'll change this -- You are receiving this mail because: You are watching all bug changes.