https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 196509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196509&action=edit Bug 42193: Fix the "Suspend Hold" modal in the OPAC In the OPAC, the "Suspend Hold" modal sometimes shows up as (and acts like) a "Resume Hold" modal. The reason for this is a left over "HOLD.suspend" in the template. "HOLD" should not be used in this template and is set as a side effect of the processing of "holds-table.inc". Since there is a separate form that exist for the "Resume" action and the modal is only needed for suspension, this patch simply removes the inacurate conditional in the modal definition. To test : 1. Have at least 2 holds. 2. In the holds table in the OPAC, make sure all holds are active and have a "Suspend" link. 3. Click the "Suspend" link on the newest hold (with the highest reserve_id). => The modal is titled "Suspend hold" and submitting it correctly suspends the hold. 4. Click the "Suspend" link on any of the other hold. => The modal is titled "Resume hold" and submitting it doesn't suspends the hold. 5. Apply patch 6. Repeat step 4. => The modal is titled "Suspend hold" and submitting it correctly suspends the hold. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.