[Bug 42193] New: The "Suspend Hold" modal in the OPAC sometimes tries to resume hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 Bug ID: 42193 Summary: The "Suspend Hold" modal in the OPAC sometimes tries to resume hold Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: maryse.simard@inlibro.com QA Contact: testopia@bugs.koha-community.org In the OPAC, the "Suspend Hold" modal sometimes shows up as (and acts like) a "Resume Hold" modal. This depends on the state of the user's other holds. To reproduce : 1. Have at least 2 holds. 2. In the holds table in the OPAC, make sure all holds are active and have a "Suspend" link. 3. Click the "Suspend" link on the newest hold (with the highest reserve_id). => The modal is titled "Suspend hold" and submitting it correctly suspends the hold. 4. Click the "Suspend" link on any of the other hold. => The modal is titled "Resume hold" and submitting it doesn't suspends the hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |maryse.simard@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 --- Comment #1 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 196335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196335&action=edit Bug 42193: Fix the "Suspend Hold" modal in the OPAC In the OPAC, the "Suspend Hold" modal sometimes shows up as (and acts like) a "Resume Hold" modal. The reason for this is a left over "HOLD.suspend" in the template. "HOLD" should not be used in this template and is set as a side effect of the processing of "holds-table.inc". Since there is a separate form that exist for the "Resume" action and the modal is only needed for suspension, this patch simply removes the inacurate conditional in the modal definition. To test : 1. Have at least 2 holds. 2. In the holds table in the OPAC, make sure all holds are active and have a "Suspend" link. 3. Click the "Suspend" link on the newest hold (with the highest reserve_id). => The modal is titled "Suspend hold" and submitting it correctly suspends the hold. 4. Click the "Suspend" link on any of the other hold. => The modal is titled "Resume hold" and submitting it doesn't suspends the hold. 5. Apply patch 6. Repeat step 4. => The modal is titled "Suspend hold" and submitting it correctly suspends the hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 196509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196509&action=edit Bug 42193: Fix the "Suspend Hold" modal in the OPAC In the OPAC, the "Suspend Hold" modal sometimes shows up as (and acts like) a "Resume Hold" modal. The reason for this is a left over "HOLD.suspend" in the template. "HOLD" should not be used in this template and is set as a side effect of the processing of "holds-table.inc". Since there is a separate form that exist for the "Resume" action and the modal is only needed for suspension, this patch simply removes the inacurate conditional in the modal definition. To test : 1. Have at least 2 holds. 2. In the holds table in the OPAC, make sure all holds are active and have a "Suspend" link. 3. Click the "Suspend" link on the newest hold (with the highest reserve_id). => The modal is titled "Suspend hold" and submitting it correctly suspends the hold. 4. Click the "Suspend" link on any of the other hold. => The modal is titled "Resume hold" and submitting it doesn't suspends the hold. 5. Apply patch 6. Repeat step 4. => The modal is titled "Suspend hold" and submitting it correctly suspends the hold. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196509|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 199419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199419&action=edit Bug 42193: Fix the "Suspend Hold" modal in the OPAC In the OPAC, the "Suspend Hold" modal sometimes shows up as (and acts like) a "Resume Hold" modal. The reason for this is a left over "HOLD.suspend" in the template. "HOLD" should not be used in this template and is set as a side effect of the processing of "holds-table.inc". Since there is a separate form that exist for the "Resume" action and the modal is only needed for suspension, this patch simply removes the inacurate conditional in the modal definition. To test : 1. Have at least 2 holds. 2. In the holds table in the OPAC, make sure all holds are active and have a "Suspend" link. 3. Click the "Suspend" link on the newest hold (with the highest reserve_id). => The modal is titled "Suspend hold" and submitting it correctly suspends the hold. 4. Click the "Suspend" link on any of the other hold. => The modal is titled "Resume hold" and submitting it doesn't suspends the hold. 5. Apply patch 6. Repeat step 4. => The modal is titled "Suspend hold" and submitting it correctly suspends the hold. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 --- Comment #4 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The "Suspend Hold" modal in |The "Suspend hold" modal in |the OPAC sometimes tries to |the OPAC sometimes tries to |resume hold |resume hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01 |26.11.00,26.05.01,25.11.05 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.05 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42193 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01,25.11.05 |26.11.00,26.05.01,25.11.06 released in| | --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- EDIT: pushed to 25.11.06 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org