https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Bug ID: 38126 Summary: Holds queue is allocating holds twice when using TransportCostMatrix and LocalHoldsPriority Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In MapItemsToHoldRequests we first attempt to fill holds with local priority - if we find any we mark the request 'allocated' then pass remaining holds to _allocateWithTransportCostMatrix, however, that routine doesn't filter out allocated holds To recreate: 1 - Enable RealTimeHoldsQueue 2 - Enable UseTransportCostMatrix 3 - Enable LocalHoldsPriority Give/Home/Home 4 - Administration - Transport cost matrix - enable transfers to/from Centreville and other libraries, add a cost, and save 5 - Find a bib with a Centerville item 6 - Place a hold for a centerville patron 7 - Circulation - Holds queue - All libraries 8 - Note hold is entered twice 9 - On command line: perl misc/cronjobs/holds/build_holds_queue.pl --force 10 - Run holds queue again, still there twice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.