https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Lucas Gass from comment #6)
(In reply to Emily Lamancusa from comment #5)
There's also an edge case when a record has item groups defined, but all of the item groups are empty. Could this fix be adjusted to cover that case too? Maybe by filtering the search itself to exclude empty item groups, and bumping it up in the code a bit?
I must be missing something because I thought that is what this patch is correcting.
It corrects the usual case, where a record has no item groups at all. To replicate what I'm seeing: 1. Apply the patch 2. On the intranet, find a record with no item groups 3. Add one or more item groups to that record (Do not add any items to the item group(s)) 4. On the OPAC, go to that record and try to place a hold --> Note that there is an option to choose an item group with the only option being "Any item group" I can't think of a reason this state would exist except in error, so if this is not as easy to address as I'm imagining, then I don't think it needs to be a blocker. But if this case can be covered by making something like a three-line change as opposed to a one-line change, then I'd rather go with the more robust fix the first time around. -- You are receiving this mail because: You are watching all bug changes.