[Bug 34823] New: Do not show item group drop-down if there are no item groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Bug ID: 34823 Summary: Do not show item group drop-down if there are no item groups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When EnableItemGroupHolds is activated, there is a "Request specific item group:" drop-down in the OPAC when placing a hold. However, this drop-down appears regardless of whether the record has item groups or not. I think this may be confusing for patrons. To replicate: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Go to the OPAC and log in as a patron 3. Go to any record that doesn't have grouped items and try to place a hold 4. Click on "Show more options" --> Note that there is an option to choose an item group with the only option being "Any item group" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Depends on| |36227 CC| |lucas@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 [Bug 36227] No warning if placing hold on item group with no items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162847&action=edit Bug 34823: Do not show Item group dropdown if there are no item groups To test: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Go to the OPAC and log in as a patron 3. Go to any record that doesn't have grouped items and try to place a hold 4. Click on "Show more options" 5. See "Request specific item group:" and dropdown 6. APPLY PATCH 7. Try again, this time if the record has no item groups you should not see the dropdown at all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162847|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 162850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162850&action=edit Bug 34823: Do not show Item group dropdown if there are no item groups To test: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Go to the OPAC and log in as a patron 3. Go to any record that doesn't have grouped items and try to place a hold 4. Click on "Show more options" 5. See "Request specific item group:" and dropdown 6. APPLY PATCH 7. Try again, this time if the record has no item groups you should not see the dropdown at all. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Lucas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #4 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Moving this to BLOCKED for now, since the dependent patch does not apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov --- Comment #5 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- There's also an edge case when a record has item groups defined, but all of the item groups are empty. Could this fix be adjusted to cover that case too? Maybe by filtering the search itself to exclude empty item groups, and bumping it up in the code a bit? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Emily Lamancusa from comment #5)
There's also an edge case when a record has item groups defined, but all of the item groups are empty. Could this fix be adjusted to cover that case too? Maybe by filtering the search itself to exclude empty item groups, and bumping it up in the code a bit?
I must be missing something because I thought that is what this patch is correcting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Lucas Gass from comment #6)
(In reply to Emily Lamancusa from comment #5)
There's also an edge case when a record has item groups defined, but all of the item groups are empty. Could this fix be adjusted to cover that case too? Maybe by filtering the search itself to exclude empty item groups, and bumping it up in the code a bit?
I must be missing something because I thought that is what this patch is correcting.
It corrects the usual case, where a record has no item groups at all. To replicate what I'm seeing: 1. Apply the patch 2. On the intranet, find a record with no item groups 3. Add one or more item groups to that record (Do not add any items to the item group(s)) 4. On the OPAC, go to that record and try to place a hold --> Note that there is an option to choose an item group with the only option being "Any item group" I can't think of a reason this state would exist except in error, so if this is not as easy to address as I'm imagining, then I don't think it needs to be a blocker. But if this case can be covered by making something like a three-line change as opposed to a one-line change, then I'd rather go with the more robust fix the first time around. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162850|0 |1 is obsolete| | --- Comment #8 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 166610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166610&action=edit Bug 34823: Do not show Item group dropdown if there are no item groups To test: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Go to the OPAC and log in as a patron 3. Go to any record that doesn't have grouped items and try to place a hold 4. Click on "Show more options" 5. See "Request specific item group:" and dropdown 6. APPLY PATCH 7. Try again, this time if the record has no item groups you should not see the dropdown at all. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz Resolution|--- |FIXED --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Bug 34823 depends on bug 36227, which changed state. Bug 36227 Summary: No warning if placing hold on item group with no items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org