https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41023 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Mathieu Saby from comment #5) Thanks for testing!
However I raise these concerns :
- you can’t select four value at once because the filter activates as soon as you select the first one. So you have to apply other values one at a time. Maybe some people won’t like that, but I’m not sure that another approach (like adding a button to confirm the filter?) would be a good idea. The patch as proposed is already a major step forward. But maybe you should describe this behavior more clearly in the test plan and bug description ?
This can be improved later, but I didn't manage to implement something better. Requiring the focus out to update the table is not intuitive IMO.
- there’s a minor display issue: the library names aren’t properly aligned in the selection filter. Maybe they’re centered ? In any case, it looks strange. Is it possible to fix this so that they appear exactly one below the other and left-aligned?
I've tried to fix that but it is still not perfect.
- When I filter on holding columns I see this warning in my console. I do not know if it is related : Blocked aria-hidden on an element because its descendant retained focus. The focus must not be hidden from assistive technology users. Avoid using aria-hidden on a focused element or its ancestor. Consider using the inert attribute instead, which will also prevent focus. For more details, see the aria-hidden section of the WAI-ARIA specification at https://w3c.github.io/aria/#aria-hidden. Element with focus: <textarea.select2-search__field> Ancestor with aria-hidden: <table.items_table dataTable fixedHeader-floating>
I don't think it's coming from this patch. This sounds like a FixedHeader issue. I will investigate this one later. -- You are receiving this mail because: You are watching all bug changes.