https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Excessive use of |Replace GetMarcBiblio |StripNonXmlChars |occurrences with | |$biblio->metadata->record --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I went "a bit" further, and completely replaced GetMarcBiblio with $biblio->metadata->record. The patches also remove GetHiddenItemnumbers (was called by the embed items code) and EmbedItemsInMarcBiblio. I first tried to create a Koha::MARC::Record class that would inherit from MARC::Record (and would have prevented the (not nice) class method call trick in Koha::Biblio::Metadata->record), but it's not trivial at all: From /usr/share/perl5/MARC/File/XML.pm 155 sub MARC::Record::new_from_xml { [...] 163 return( MARC::File::XML::decode( $xml, $enc, $format ) ); I think this is a move we must do ASAP, the diff is big but most of the changes are trivial. -- You are receiving this mail because: You are watching all bug changes.