https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #215 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi Olivia, thanks for the follow-ups! Round 1 status: - Blocker 1 (owner takeover): Fair enough! - Blockers 2, 4 and both code design questions: fixed - Blockers 3 and 5: fixed, but the fixes introduced blockers 1 and 2 below Unfortunately the follow-ups bring in 4 new blockers: Base setup 1) Launch ktd with the patches applied, then in `ktd --shell` run `yarn api:bundle && yarn build && restart_all` 2) Create these staff users at Centerville, with a username and password each: - 'Staff B': catalogue, item_lists > create_item_lists, borrowers > list_borrowers - 'Staff C': catalogue, item_lists > create_item_lists, tools > items_batchmod ('Perform batch modification of items', not the 'restricted' one), tools > items_batchdel. No list_borrowers Blocker 1: tables without table settings get a broken 'Copy shareable link' button 1) Open http://localhost:8081/cgi-bin/koha/admin/record_sources and create a record source if there are none 2) The table now has 'Columns' and 'Copy shareable link' buttons. Without the patches it has neither 3) Click 'Copy shareable link' and paste it somewhere. It contains 'DataTables_undefined_undefined_undefined_state', and opening it restores nothing Same on Preservation, ILL requesting agencies, and the vendor/EHoldings show pages. Tables with their own table settings (e.g. ERM agreements and licenses) are fine. "Don't disable table sharing in Vue" only reverts disable_share: KohaTable.vue still always passes a truthy table_settings ({ ...props.table_settings, columns }). Passing it only when props.table_settings is set should do it. Blocker 2: lists of a deleted owner can't be reached and block their name 1) Log in as Staff B, open http://localhost:8081/cgi-bin/koha/lists/items and create a list 'B private', visibility 'Private' 2) As koha, delete Staff B 3) As koha, reload http://localhost:8081/cgi-bin/koha/lists/items. 'B private' isn't there, even for a superlibrarian 4) Create a new list called 'B private'. You get 'An item list already exists with this name' Nobody can see, edit or delete it, and the name is gone for good. Round 1 failed open, now it fails closed with no way back. Some way to reach ownerless lists (e.g. superlibrarians, or reassigning lists on patron deletion like ListOwnershipUponPatronDeletion does for public lists) would solve it. Blocker 3: batch actions need 'list_borrowers' 1) Log in as Staff C, open http://localhost:8081/cgi-bin/koha/lists/items, create a list 'C list' and add a couple of items to it 2) Open 'C list'. The toolbar only has 'Add items': no 'Batch remove from list', 'Batch edit' or 'Batch delete' 3) As koha, give Staff C borrowers > list_borrowers. As Staff C, reload 'C list'. The batch buttons now appear list_borrowers is only needed to search patrons for 'Add shares'. Since "Switch to toolbar buttons", the batch buttons sit behind the same early return in additionalToolbarButtons. Blocker 4: items table settings hide the wrong column 1) As Staff C, open 'C list' from Blocker 3: http://localhost:8081/cgi-bin/koha/lists/items/2. The first column is a checkbox column, before 'Barcode' 2) As koha, open http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl?module=item_lis..., find the 'items' table, tick 'Is hidden by default' for 'barcode' and save 3) As Staff C, open http://localhost:8081/cgi-bin/koha/lists/items/2 in a private window. 'Barcode' is still shown, and the checkbox column is gone instead, so rows can't be selected for the batch actions 4) Untick 'barcode', tick 'call_number' instead and save. Reload in a private window: 'Barcode' disappears and 'Call Number' stays The settings are matched by position and don't count the leading checkbox column, so each setting hides the column to the left of the one you picked. -- You are receiving this mail because: You are watching all bug changes.