[Bug 30557] New: Add ability to create Item lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Bug ID: 30557 Summary: Add ability to create Item lists Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: estherm@sodaspringsid.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl This is relevant for multi-branch installations. Lists currently appear to be primarily bibliographic lists. This creates a problem when sorting lists by call number. In this scenario there may be multiple items from different libraries using different call number schema attached to a single bibliographic record. The list cannot be sorted accurately by call number. It would be helpful if there was an option for an item based list. In this scenario items are added to a list for a specific branch. The call number sort will then sort correctly because the call number schema will be consistent for the branch. An item list would display the same information as a bibliographic list with the exception of additional branches which may also have the item. A typical use case would a library creating an item list, sort by call number, and then use that list to go to the shelf to pull the items in order. This is currently not possible in a multi-branch installation without a bit of work. It would require downloading the list and then cleaning up the list to be useful for this kind of work. It may be possible to create a report that will do this, but it would be a nice added functionality in the List tool. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #1 from Katie Bliss <kebliss@dmpl.org> --- + 1 One of our branch managers was asking for this exact thing just yesterday. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Nancy M. <nmumford@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nmumford@clamsnet.org --- Comment #2 from Nancy M. <nmumford@clamsnet.org> --- A CLAMS library has recently requested this feature as they would like to print a list without all the other libraries' call numbers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 krkincai@elkocountynv.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |krkincai@elkocountynv.net --- Comment #3 from krkincai@elkocountynv.net --- We were just looking at this as well. We would like this feature so we can create a list of leased titles catalogued each month. By having it item specific, we can keep track of the individual copies for an easier recall when it is time to return them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Are people talking about lists on the staff interface only or OPAC as well?
From the comments so far, it sounds like a staff-only feature?
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #5 from Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> --- +1 Staff want this so they can print lists with titles, locations and call numbers for shelf searches. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 karie.straube@yavapaiaz.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karie.straube@yavapaiaz.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Dani Elder <danielle.elder@law.utexas.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle.elder@law.utexas.e | |du --- Comment #6 from Dani Elder <danielle.elder@law.utexas.edu> --- Would love this if a staff only feature that we could share with other staff members (not just private or public) like list are not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Ilona R <hattara@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hattara@gmail.com --- Comment #7 from Ilona R <hattara@gmail.com> --- This would help immensely with collection management, if it could work similarly to a feature that was called "silos" in another ILS that I have used. I could create a "silo", or list, of items by either adding them with their barcodes or from the biblio's detail page. Batch actions could be performed based on the list and I could easily share it. Colleagues at other branches could make a list of items they are unsure what to do with, then pass it to me, and I could easily go through all items and make decisions. I could also perform several different searches, add some of the items from the results to a list, and once I'm done with everything, batch action the whole lot. We would also use this for items that needed new labels, just stick 'em in a list that someone prints out later, instead of that person having to read each barcode individually again. Currently in Koha, the only way I have found to do anything like this is copy and paste individual barcodes into a list, then share that or put it into batch actions. I would love it if I could just tick a box to put items on a list that would be saved inside Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #8 from carthur@slolibrary.org <carthur@slolibrary.org> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Danielle M. <dmeininger591@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmeininger591@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Kris <kbecker@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbecker@jcls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #9 from Mathieu Saby <mathsabypro@gmail.com> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 nhansen@nekls.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nhansen@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 crosenthal@pwcgov.org <crosenthal@pwcgov.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crosenthal@pwcgov.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Assignee|koha-bugs@lists.koha-commun |olivia.reynolds@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |ByWater Solutions list of Sponsors| |<https://bywatersolutions.c | |om/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203509&action=edit Proposal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #11 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203898&action=edit Bug 30557: Add DataTables select extension Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #12 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203899&action=edit Bug 30557: Add DataTables additionalButtons Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #13 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203900&action=edit Bug 30557: Support column toggling in Vue KohaTable Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #14 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203901&action=edit Bug 30557: Support resource remove in Vue Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #15 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203902&action=edit Bug 30557: Allow parent resources to set breadcrumbs Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #16 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203903&action=edit Bug 30557: Use select label in ResourceList cells Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #17 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203904&action=edit Bug 30557: Use legal property name for base resource emit Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #18 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203905&action=edit Bug 30557: Allow undef group_feature for visibility checking Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #19 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203906&action=edit Bug 30557: DB updates Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #20 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203907&action=edit Bug 30557: DBIC updates (DO NOT PUSH) Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #21 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203908&action=edit Bug 30557: Additional Result class methods Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #22 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203909&action=edit Bug 30557: Add new permissions Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #23 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203910&action=edit Bug 30557: Add item list object classes Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #24 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203911&action=edit Bug 30557: Add Koha object unit tests Test plan: 1. Prove t/db_dependent/Koha/Item/List.t Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #25 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203912&action=edit Bug 30557: Add item lists REST API Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #26 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203913&action=edit Bug 30557: Add item lists REST API unit tests Test plan: 1. Prove t/db_dependent/api/v1/item_lists.t Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #27 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203914&action=edit Bug 30557: Add item lists Vue module Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #28 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203915&action=edit Bug 30557: Add Cypress tests for Vue module Test plan: 1. Rebuild the JS bundles with yarn js:build 2. Run the Cypress spec t/cypress/integration/ItemLists_spec.ts In KTD you can do this with: cypress run -s t/cypress/integration/ItemLists_spec.ts Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #29 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 203916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203916&action=edit Bug 30557: Integrate adding items to item lists Test plan: 1. Navigate to Item Lists, and create a new item list with your user as the owner and any visibility. 2. Navigate to a Catalogue detail page, and select an item in its holdings table. 3. Verify an "Add selected items to list" button appears above the table. 4. Click this button, and add the item to the list you created earlier. 5. Return to the item list, clicking its name to view its items. 6. Verify the item you added appears in the list. 7. Remove the item from the list. 8. Navigate to Reports > Create from SQL, and create a new report with any name and the following SQL: SELECT itemnumber FROM items ORDER BY RAND() LIMIT 1 9. Run this report, and verify "Add items to list" appears under the "Batch operations with 1 visible records" dropdown. 10. Use this option to add the item to the list you created earlier. 11. Verify the item has been added to the list, and remove it again. 12. Navigate to Search > Item Search, and perform an empty search to list all items. 13. Select an item from the results, and verify "Batch add to item list" appears in the "Batch operations" dropdown at the top of the results table. 14. Use this option to add the item to the list you created earlier. 15. Verify the item has been added to the list, and remove it again. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited|ByWater Solutions |CLAMS list of Sponsors|<https://bywatersolutions.c |<https://info.clamsnet.org/ |om/> |> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #30 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I get an error when I attempt to yarn build after applying these patches: $ rspack build --mode development ERROR in ./koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue?vue&type=script&lang=js (./koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue.js?vue&type=script&lang=js!=!./node_modules/vue-loader/dist/index.js??ruleSet[0]!./koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue?vue&type=script&lang=js) 8:1-31 × Module not found: Can't resolve 'datatables.net-select' in '/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/js/vue/components' ╭─[8:0] 6 │ import "datatables.net-buttons/js/buttons.print"; 7 │ import "datatables.net-buttons/js/buttons.colVis"; 8 │ import "datatables.net-select"; · ─────────────────────────────── 9 │ import { 10 │ onBeforeMount, ╰──── Not sure if there's something I could/should do in ktd to resolve this or if it's an issue with the patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #31 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- (In reply to Andrew Fuerste-Henry from comment #30)
I get an error when I attempt to yarn build after applying these patches:
Not sure if there's something I could/should do in ktd to resolve this or if it's an issue with the patches.
Apologies, that's a missing step in the test plan for adding the DataTables select extension. Running `yarn install` after applying the patch "Add DataTables select extension" should resolve that issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #32 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Olivia Reynolds from comment #31)
(In reply to Andrew Fuerste-Henry from comment #30)
I get an error when I attempt to yarn build after applying these patches:
Not sure if there's something I could/should do in ktd to resolve this or if it's an issue with the patches.
Apologies, that's a missing step in the test plan for adding the DataTables select extension. Running `yarn install` after applying the patch "Add DataTables select extension" should resolve that issue.
ah! ty :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #33 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I wrote up a test plan for permissions enforcement: 1 - As a superlibrarian, create 3 item lists owned by the superlibrarian with Public, Private, and Group visibilities 2 - Create a user with staff access (catalogue) permission but no item list or other permissions. Give your user a different home branch than your superlibrarian accout 3 - As a superlibrarian, create a private list owned by your user 3 - Log in as your user 4 - Confirm you can access the Item Lists module and see only the public list and the private list owned by the user 5 - Return to your superlibrarian login and create a library group containing the superlibrarian and user's libraries 6 - Return to your user login, confirm you can now see the group list 7 - On the Item Lists home page (/cgi-bin/koha/lists/items) confirm your user is not offered buttons for New item list, Edit, or Delete 8 - Click into one of the lists owned by the superlibrarian (/cgi-bin/koha/lists/items/X) and confirm your user is not offered a button for Add items 9 - Click into the list owned by your user, confirm you are able to add items to it 10 - Confirm your user can add items to the list they own from bib details, item search, and report results 11 - confirm your user can edit the list they own 12 - confirm your user can delete the list they own 13 - Give your user the permission Add/remove items in public or group lists (manage_item_list_contents) 14 - As your user, confirm you can add items to public & group lists owned by the superlibrarian via the Item Lists module, bib details, item search, and report results 15 - Give your user the permission Edit item lists owned by others / public (edit_item_lists) 16 - Confirm your user can now edit the public & group lists owned by the superlibrarin 17 - Give your user the permission Delete item lists owned by others / public (delete_item_lists) 18 - Confirm your user can now delete the public & group lists owned by the superlibrarin 19 - Give your user the permisison Create item lists (create_item_lists). Make sure they *do not* have the permission Search, list and view patrons (list_borrowers) 20 - Confirm your user can now create item lists with themselves as the owner 21 - Give your user the permission Search, list and view patrons (list_borrowers) 22 - Confirm your user can now find and assign other users as list owner when creating an item list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #34 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- All the functionality covered by Olivia's test plan works great! But there are some issues when one has limited permissions. These notes refer to the permissions test plan I just added: Step 4 - user cannot see Item Lists without at least one item list permission (contrast with bib lists, which the user can see without list management permissions) Step 7 - currently the user is given buttons for actions they do not have permisisons for and receives an error when attempting to use them. They should not be offered buttons for actions they do not have permissions for Step 9 - without access to the item lists module, the user can only add to their list from bib details, item search, and report results Step 11 & 12 - without access to the item lists module, the user cannot edit or delete lists they own Step 16 - the user is able to successfully edit public and group lists with the permission, but receives an erroneous error on the edit screen before clicking "save" -- "Something went wrong: Error: Authorization failure. Missing required permission(s)." Step 20 - a user who has Create item lists but not the permission Search, list and view patrons (list_borrowers) is functionally blocked from creating lists because they are not given a list of users to select from when typing into the Owner field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #35 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- When searching for a user to set as list owner, would it make sense to constrain the search to only users with access to the staff interface? Since item lists don't have any visibility on the OPAC? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #36 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Three more things as I continue to poke at this: - When I'm in the Item Lists module, the search bar at the top of the screen disappears. It would be nice to have the same search bar options here that one has in biblio Lists - Item lists does not appear in the More dropdown on the main nav bar - When adding to a list via /cgi-bin/koha/lists/items/X/add, the Save button has a down arrow suggesting more options (save and continue, etc), but clicking the down arrow reveals an empty box. This should just be a solid button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #37 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Feedback from the funding library: 1 - It would save clicks to always assume a new list will be owned by the creator, allowing the creator to click on Owner to change it when desired 2 - Selecting the list to add items to will be confusing if the same name is used on more than one list. Biblio lists already enforce unique names, so item lists should, too Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203898|0 |1 is obsolete| | Attachment #203899|0 |1 is obsolete| | Attachment #203900|0 |1 is obsolete| | Attachment #203901|0 |1 is obsolete| | Attachment #203902|0 |1 is obsolete| | Attachment #203903|0 |1 is obsolete| | Attachment #203904|0 |1 is obsolete| | Attachment #203905|0 |1 is obsolete| | Attachment #203906|0 |1 is obsolete| | Attachment #203907|0 |1 is obsolete| | Attachment #203908|0 |1 is obsolete| | Attachment #203909|0 |1 is obsolete| | Attachment #203910|0 |1 is obsolete| | Attachment #203911|0 |1 is obsolete| | Attachment #203912|0 |1 is obsolete| | Attachment #203913|0 |1 is obsolete| | Attachment #203914|0 |1 is obsolete| | Attachment #203915|0 |1 is obsolete| | Attachment #203916|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #38 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204307&action=edit Bug 30557: Add DataTables select extension Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #39 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204308&action=edit Bug 30557: Add DataTables additionalButtons Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #40 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204309&action=edit Bug 30557: Support column toggling in Vue KohaTable Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #41 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204310&action=edit Bug 30557: Support resource remove in Vue Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #43 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204312&action=edit Bug 30557: Allow using parentResource to decide table actions Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #46 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204315&action=edit Bug 30557: Hide labels for hidden FormElements Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #47 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204316&action=edit Bug 30557: Allow undef group_feature for visibility checking Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #48 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204317&action=edit Bug 30557: Allow filtering patron API by permissions Test plan: 1. Prove t/db_dependent/api/v1/patrons.t Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #49 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204318&action=edit Bug 30557: Don't show dropdown if there are no actions Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #50 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204319&action=edit Bug 30557: DB updates Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #51 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204320&action=edit Bug 30557: DBIC updates (DO NOT PUSH) Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #52 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204321&action=edit Bug 30557: Additional Result class methods Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #53 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204322&action=edit Bug 30557: Add new permissions Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #54 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204323&action=edit Bug 30557: Add item list object classes Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #55 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204324&action=edit Bug 30557: Add Koha object unit tests Test plan: 1. Prove t/db_dependent/Koha/Item/List.t Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #56 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204325&action=edit Bug 30557: Add item lists REST API Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #58 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204327&action=edit Bug 30557: Add item lists Vue module Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #59 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204328&action=edit Bug 30557: Add Cypress tests for Vue module Test plan: 1. Ensure you have installed the new dependencies by running yarn install 2. Rebuild the JS bundles with yarn js:build 3. Run the Cypress spec t/cypress/integration/ItemLists_spec.ts In KTD you can do this with: cypress run -s t/cypress/integration/ItemLists_spec.ts Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #60 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204329&action=edit Bug 30557: Integrate adding items to item lists Test plan: 1. Navigate to Item Lists, and create a new item list with your user as the owner and any visibility. 2. Navigate to a Catalogue detail page, and select an item in its holdings table. 3. Verify an "Add selected items to list" button appears above the table. 4. Click this button, and add the item to the list you created earlier. 5. Return to the item list, clicking its name to view its items. 6. Verify the item you added appears in the list. 7. Remove the item from the list. 8. Navigate to Reports > Create from SQL, and create a new report with any name and the following SQL: SELECT itemnumber FROM items ORDER BY RAND() LIMIT 1 9. Run this report, and verify "Add items to list" appears under the "Batch operations with 1 visible records" dropdown. 10. Use this option to add the item to the list you created earlier. 11. Verify the item has been added to the list, and remove it again. 12. Navigate to Search > Item Search, and perform an empty search to list all items. 13. Select an item from the results, and verify "Batch add to item list" appears in the "Batch operations" dropdown at the top of the results table. 14. Use this option to add the item to the list you created earlier. 15. Verify the item has been added to the list, and remove it again. Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #61 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks Olivia! I will test this out asap. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #62 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- No problem! Thank you as well to Andrew for additional feedback and suggestions on this version. Just to highlight two slightly less obvious changes with this update: - Everywhere you could add specify a patron in the item lists module should now only autocomplete to patrons with catalogue access (they're the only folks who could make use of item lists anyway). - If you don't have the list_borrowers permission, everywhere you could specify a patron will be hidden (the autocomplete doesn't work without that permission). So that means you can only create lists belonging to yourself (the new default) and edit existing lists without changing their owner. You also won't be able to add new shares, as that also requires specifying a patron. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #63 from Brendan Lawlor <blawlor@clamsnet.org> --- There is a conflict when applying the last patch Integrate adding items to item lists. Looks like it's caused by a recent tidy in guided_reports_start.tt I was able to get it resolved and start testing it out though. One thing I found was that if I try to search the table of item lists I got an alert with a 500 error. These errors were logged to the console: Failed to load resource: the server responded with a status of 500 (Internal Server Error) datatables_26.0600016.js:414 Got 500 (Internal Server Error) datatables_26.0600016.js:437 DataTables warning: table id=DataTables_Table_0 - Ajax error. For more information about this error, please see https://datatables.net/tn/7 jquery-3.6.0.min_26.0600016.js:2 GET http://localhost:8081/api/v1/item-lists?_page=1&_per_page=20&q=%5B%5B%7B%22me.id%22%3A%7B%22like%22%3A%22%25wow%25%22%7D%7D%5D%2C%5B%7B%22me.name%22%3A%7B%22like%22%3A%22%25wow%25%22%7D%7D%5D%2C%5B%7B%22me.item_list_contents_count%22%3A%7B%22like%22%3A%22%25wow%25%22%7D%7D%5D%2C%5B%7B%22me.visibility%22%3A%7B%22like%22%3A%22%25wow%25%22%7D%7D%5D%2C%5B%7B%22me.created_date%22%3A%7B%22like%22%3A%22%25wow%25%22%7D%7D%5D%2C%5B%7B%22me.updated_date%22%3A%7B%22like%22%3A%22%25wow%25%22%7D%7D%5D%5D&_match=contains&_order_by=%2Bme.id 500 (Internal Server Error) In the url I think the problem is me.item_list_contents_count. My understanding is that the item_list_contents_count column needs a tableColumnDefinition because it's not a real column in the database. Other than that everything is looking good in the rest of the test plan. I have not followed Andrew's plan for testing permissions yet, but I will next time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #64 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204367&action=edit Bug 30557: (follow-up) Disable sort/search on unsupported columns Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #65 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Thanks for spotting that search error and identifying the issue. I've added a follow-up patch to disable sort/search on the columns where this isn't possible under Koha's current API setup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #66 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks Olivia! Patch application failed for attachment 204329 - Bug 30557: Integrate adding items to item lists This one patch still needs to be rebased for changes in guided_reports_start.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #67 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Apologies for missing that! I've rebased everything and squashed that search fix in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204307|0 |1 is obsolete| | Attachment #204308|0 |1 is obsolete| | Attachment #204309|0 |1 is obsolete| | Attachment #204310|0 |1 is obsolete| | Attachment #204311|0 |1 is obsolete| | Attachment #204312|0 |1 is obsolete| | Attachment #204313|0 |1 is obsolete| | Attachment #204314|0 |1 is obsolete| | Attachment #204315|0 |1 is obsolete| | Attachment #204316|0 |1 is obsolete| | Attachment #204317|0 |1 is obsolete| | Attachment #204318|0 |1 is obsolete| | Attachment #204319|0 |1 is obsolete| | Attachment #204320|0 |1 is obsolete| | Attachment #204321|0 |1 is obsolete| | Attachment #204322|0 |1 is obsolete| | Attachment #204323|0 |1 is obsolete| | Attachment #204324|0 |1 is obsolete| | Attachment #204325|0 |1 is obsolete| | Attachment #204326|0 |1 is obsolete| | Attachment #204327|0 |1 is obsolete| | Attachment #204328|0 |1 is obsolete| | Attachment #204329|0 |1 is obsolete| | Attachment #204367|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #68 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204388&action=edit Bug 30557: Add DataTables select extension Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #69 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204389&action=edit Bug 30557: Add DataTables additionalButtons Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #70 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204390&action=edit Bug 30557: Support column toggling in Vue KohaTable Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #71 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204391&action=edit Bug 30557: Support resource remove in Vue Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #72 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204392&action=edit Bug 30557: Allow resource lists to access a parent resource Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #73 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204393&action=edit Bug 30557: Allow using parentResource to decide table actions Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #74 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204394&action=edit Bug 30557: Use select label in ResourceList cells Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #75 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204395&action=edit Bug 30557: Use legal property name for base resource emit Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #76 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204396&action=edit Bug 30557: Hide labels for hidden FormElements Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #77 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204397&action=edit Bug 30557: Allow undef group_feature for visibility checking Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #78 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204398&action=edit Bug 30557: Allow filtering patron API by permissions Test plan: 1. Prove t/db_dependent/api/v1/patrons.t Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #79 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204399&action=edit Bug 30557: Don't show dropdown if there are no actions Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #80 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204400&action=edit Bug 30557: DB updates Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #81 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204401&action=edit Bug 30557: DBIC updates (DO NOT PUSH) Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #82 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204402&action=edit Bug 30557: Additional Result class methods Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #83 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204403&action=edit Bug 30557: Add new permissions Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #84 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204404&action=edit Bug 30557: Add item list object classes Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #85 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204405&action=edit Bug 30557: Add Koha object unit tests Test plan: 1. Prove t/db_dependent/Koha/Item/List.t Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #86 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204406&action=edit Bug 30557: Add item lists REST API Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #87 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204407&action=edit Bug 30557: Add item lists REST API unit tests Test plan: 1. Prove t/db_dependent/api/v1/item_lists.t Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #88 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204408&action=edit Bug 30557: Add item lists Vue module Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #89 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204409&action=edit Bug 30557: Add Cypress tests for Vue module Test plan: 1. Ensure you have installed the new dependencies by running yarn install 2. Rebuild the JS bundles with yarn js:build 3. Run the Cypress spec t/cypress/integration/ItemLists_spec.ts In KTD you can do this with: cypress run -s t/cypress/integration/ItemLists_spec.ts Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #90 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204410&action=edit Bug 30557: Integrate adding items to item lists Test plan: 1. Navigate to Item Lists, and create a new item list with your user as the owner and any visibility. 2. Navigate to a Catalogue detail page, and select an item in its holdings table. 3. Verify an "Add selected items to list" button appears above the table. 4. Click this button, and add the item to the list you created earlier. 5. Return to the item list, clicking its name to view its items. 6. Verify the item you added appears in the list. 7. Remove the item from the list. 8. Navigate to Reports > Create from SQL, and create a new report with any name and the following SQL: SELECT itemnumber FROM items ORDER BY RAND() LIMIT 1 9. Run this report, and verify "Add items to list" appears under the "Batch operations with 1 visible records" dropdown. 10. Use this option to add the item to the list you created earlier. 11. Verify the item has been added to the list, and remove it again. 12. Navigate to Search > Item Search, and perform an empty search to list all items. 13. Select an item from the results, and verify "Batch add to item list" appears in the "Batch operations" dropdown at the top of the results table. 14. Use this option to add the item to the list you created earlier. 15. Verify the item has been added to the list, and remove it again. Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|dcook@prosentient.com.au | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #91 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for working on this Olivia! It's going to be a super userful new feature for our libraries! Olivia’s plan: Basic functionality mostly works. There is a permissions issue that prevents adding items from the item search for non super librarians. Some of these points are for more consitent ui and ux improvements. Some are would be nice suggestions and not necessarily blockers. # Creating item lists - Default visibility should be Private, to be consistent with the Lists feature and to save clicks. # On koha/lists/items page - Page is missing <h1> for ‘Item lists’ below the menu buttons above the table to be consistent with other Koha UI and Lists feature - Actions column should use a drop down with Edit, + Add items, Add shares and Delete - Add items and add shares would go direct to forms to add items or shares # On an item list page /koha/lists/items/1 - Page is missing <h1> for ‘Contents of <list name> - The table is missing an option for Home Library, which would be useful, otherwise you’d have to infer that by the barcode prefix. Collection code is another important column for library staff. Enumchron would also be a needed option for periodicals - Filtering is not available for Location and Item Type columns - Allow removing multiple selected items from the list rather than one at a time. There should be a remove selected button like the bib Lists feature has, otherwise managing a long list of items would be frustrating. - Batch edit and Batch delete buttons should be disabled if no items are selected and nothing would be sent to the tool - Not a blocker but note that these buttons look different than other Koha buttons, and links to these functions usually appear under a batch operations dropdown menu in other parts of Koha - It would be nice to show a summary of info about the list above the table including visibility Private/Group/Public and number of shares on this page - Should + Add share button also be visible in the menu bar here if the user has permission to add a share on the /koha/lists/items/1/shares route? I understand if it’s a design chose to keep adding shares totally separated, but it could help managers of the lists to save clicks (not a blocker) # On koha/lists/items/1/add - This page should have the option to add items by itemnumber, consistent with the bibs List feature - Missing an <h1>, Add items is <h2> - Not sure what would be a consistent pattern because the Lists feature uses a modal for adding records instead of a separate page (not a blocker) - Modal: Are you sure you want to remove this item from the list? - Should show more information than barcode, a summary of the row data would help to confirm the item # On koha/lists/items/1/shares - Modal: Are you sure you want to remove this share from the list? - Only displays the borrower number, but should display the patron name and info consistent with other parts of Koha - Adding items from Item search - Permissions issue? According to Andrew’s test plan, a user that does not have any item_lists sub permissions, but has been given ownership or a shared a list with edit permissions by a superlibrarian can not add items via item search. They can add items via the other three methods, Item lists interface, catalog search and reports (if they have access to run reports) - The Batch operations drop down with Batch add to item lists option does not render. - Should this be a separate button from batch operations that update or delete records, considering this only adds records to a list? - For accessibility these should be coded as <button> rather than <a> since they are used for actions not navigation # Adding items from a Report - Menu option name suggestion ‘Add to item list’ to be consistent with but also differentiate ‘Add to list’ #Adding items from item search, holdings table or report - This doesn’t seem to work except for the superlibrarian. Even with the top level item_lists permission the batch operations button doesn’t render without more permissions # Modal: Add items to item list - Allows you to select a list you have permission to add items on - If you have permission to create item lists, the top option should be Create a new list - The Add to list button should have a dropdown for Add to list and view, which would take you to the list you (similar to save and view elsewhere in Koha) - When searching for a patron to set owner or add a share, there is no indication that ‘No matching records were found’. When you submit the form validation says ‘You must select a patron from the results list’ so it would be helpful to indicate that to the user Andrew’s test plan: # 4 - Confirm you can access the Item Lists module and see only the public list and the private list owned by the user - Confirmed, but also note that there is no link from the home page to get here. That actually seems consistent with how Lists works, you need at least one permission to see the menu link, but it seems like a bug because the user can access the module for things that are public/visible to them. The menu link displaying does not seem to have the same control as whether the user can reach the module http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=list # 7, 8 and 9 - Click into the list owned by your user, confirm you are able to add items to it - Confirmed # 10 - Confirm your user can add items to the list they own from bib details, item search, and report results - From item search there is No Batch operations drop down with Batch add to item lists option. - Should this be a separate button from batch operations that update or delete records, considering this only adds records to a list? # 11 and 12 - Confirmed #13 - 16 - From item search there is No Batch operations drop down with Batch add to item lists option. # 17 - 18 Confirmed # 19 - 20 Confirmed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Lauri Hänninen <lauri.hanninen@lahti.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauri.hanninen@lahti.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204388|0 |1 is obsolete| | Attachment #204389|0 |1 is obsolete| | Attachment #204390|0 |1 is obsolete| | Attachment #204391|0 |1 is obsolete| | Attachment #204392|0 |1 is obsolete| | Attachment #204393|0 |1 is obsolete| | Attachment #204394|0 |1 is obsolete| | Attachment #204395|0 |1 is obsolete| | Attachment #204396|0 |1 is obsolete| | Attachment #204397|0 |1 is obsolete| | Attachment #204398|0 |1 is obsolete| | Attachment #204399|0 |1 is obsolete| | Attachment #204400|0 |1 is obsolete| | Attachment #204401|0 |1 is obsolete| | Attachment #204402|0 |1 is obsolete| | Attachment #204403|0 |1 is obsolete| | Attachment #204404|0 |1 is obsolete| | Attachment #204405|0 |1 is obsolete| | Attachment #204406|0 |1 is obsolete| | Attachment #204407|0 |1 is obsolete| | Attachment #204408|0 |1 is obsolete| | Attachment #204409|0 |1 is obsolete| | Attachment #204410|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #92 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205675&action=edit Bug 30557: Add DataTables select extension Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #93 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205676&action=edit Bug 30557: Add DataTables additionalButtons Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #94 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205677&action=edit Bug 30557: Support column toggling in Vue KohaTable Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #95 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205678&action=edit Bug 30557: Support resource remove in Vue Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #96 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205679&action=edit Bug 30557: Allow resource lists to access a parent resource Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #97 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205680&action=edit Bug 30557: Allow using parentResource to decide table actions Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #98 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205681&action=edit Bug 30557: Allow adding additional DataTables event handlers Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #99 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205682&action=edit Bug 30557: Use select label in ResourceList cells Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #100 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205683&action=edit Bug 30557: Use legal property name for base resource emit Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #101 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205684&action=edit Bug 30557: Allow specifying a custom resource description function Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #102 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205685&action=edit Bug 30557: Allow putting KohaTable actions in dropdown Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #103 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205686&action=edit Bug 30557: Hide labels for hidden FormElements Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #104 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205687&action=edit Bug 30557: Allow undef group_feature for visibility checking Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #105 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205688&action=edit Bug 30557: Allow filtering patron API by permissions Test plan: 1. Prove t/db_dependent/api/v1/patrons.t Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #106 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205689&action=edit Bug 30557: Don't show dropdown if there are no actions Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #107 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205690&action=edit Bug 30557: Allow http client DELETEs to have a body Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #108 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205691&action=edit Bug 30557: Add a list-header slot to BaseResource Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #109 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205692&action=edit Bug 30557: DB updates Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #110 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205693&action=edit Bug 30557: DBIC updates (DO NOT PUSH) Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #111 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205694&action=edit Bug 30557: Additional Result class methods Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #112 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205695&action=edit Bug 30557: Add new permissions Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #113 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205696&action=edit Bug 30557: Add item list object classes Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #114 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205697&action=edit Bug 30557: Add Koha object unit tests Test plan: 1. Prove t/db_dependent/Koha/Item/List.t Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #115 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205698&action=edit Bug 30557: Add item lists REST API Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #116 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205699&action=edit Bug 30557: Add item lists REST API unit tests Test plan: 1. Prove t/db_dependent/api/v1/item_lists.t Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #117 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205700&action=edit Bug 30557: Add item lists Vue module Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #118 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205701&action=edit Bug 30557: Add Cypress tests for Vue module Test plan: 1. Ensure you have installed the new dependencies by running yarn install 2. Rebuild the JS bundles with yarn js:build 3. Run the Cypress spec t/cypress/integration/ItemLists_spec.ts In KTD you can do this with: cypress run -s t/cypress/integration/ItemLists_spec.ts Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #119 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 205702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205702&action=edit Bug 30557: Integrate adding items to item lists Test plan: 1. Navigate to Item Lists, and create a new item list with your user as the owner and any visibility. 2. Navigate to a Catalogue detail page, and select an item in its holdings table. 3. Verify an "Add selected items to list" button appears above the table. 4. Click this button, and add the item to the list you created earlier. 5. Return to the item list, clicking its name to view its items. 6. Verify the item you added appears in the list. 7. Remove the item from the list. 8. Navigate to Reports > Create from SQL, and create a new report with any name and the following SQL: SELECT itemnumber FROM items ORDER BY RAND() LIMIT 1 9. Run this report, and verify "Add items to list" appears under the "Batch operations with 1 visible records" dropdown. 10. Use this option to add the item to the list you created earlier. 11. Verify the item has been added to the list, and remove it again. 12. Navigate to Search > Item Search, and perform an empty search to list all items. 13. Select an item from the results, and the "Add to item list" button appears at the top of the results table. 14. Use this button to add the item to the list you created earlier. 15. Verify the item has been added to the list, and remove it again. 16. Repeat steps 2-15, selecting "Add to list and view" from the modal's dropdown and verifying you are redirected to the list. 17. Repeat steps 2-16, creating a new list from the "Add items to item list" modal. Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #120 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Thanks for all of the feedback! I believe with this new set of patches I've addressed most of the blockers. Here's a list of the ones I don't think I've addressed, and my rationale:
# On an item list page /koha/lists/items/1 - Filtering is not available for Location and Item Type columns
From what I can see, filtering by those column types isn't possible with Koha's current REST API setup, and I can't see a table with them where it does work.
# On koha/lists/items/1/add - Missing an <h1>, Add items is <h2> - Not sure what would be a consistent pattern because the Lists feature uses a modal for adding records instead of a separate page (not a blocker)
I agree that it would be better to have a <h1>, but the <h2> is expected in a number of Cypress tests for other Vue modules, and I don't want the scope of this bug to expand to include making changes in all of those too.
# Modal: Add items to item list - When searching for a patron to set owner or add a share, there is no indication that ‘No matching records were found’. When you submit the form validation says ‘You must select a patron from the results list’ so it would be helpful to indicate that to the user
This looks to be an issue anywhere patron autocomplete is used (I can reproduce a similar thing when transferring a biblio list). I think this would be best as a separate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited|CLAMS |CLAMS, CLAMS list of Sponsors|<https://info.clamsnet.org/ |<https://info.clamsnet.org/ |> |> Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205675|0 |1 is obsolete| | Attachment #205676|0 |1 is obsolete| | Attachment #205677|0 |1 is obsolete| | Attachment #205678|0 |1 is obsolete| | Attachment #205679|0 |1 is obsolete| | Attachment #205680|0 |1 is obsolete| | Attachment #205681|0 |1 is obsolete| | Attachment #205682|0 |1 is obsolete| | Attachment #205683|0 |1 is obsolete| | Attachment #205684|0 |1 is obsolete| | Attachment #205685|0 |1 is obsolete| | Attachment #205686|0 |1 is obsolete| | Attachment #205687|0 |1 is obsolete| | Attachment #205688|0 |1 is obsolete| | Attachment #205689|0 |1 is obsolete| | Attachment #205690|0 |1 is obsolete| | Attachment #205691|0 |1 is obsolete| | Attachment #205692|0 |1 is obsolete| | Attachment #205693|0 |1 is obsolete| | Attachment #205694|0 |1 is obsolete| | Attachment #205695|0 |1 is obsolete| | Attachment #205696|0 |1 is obsolete| | Attachment #205697|0 |1 is obsolete| | Attachment #205698|0 |1 is obsolete| | Attachment #205699|0 |1 is obsolete| | Attachment #205700|0 |1 is obsolete| | Attachment #205701|0 |1 is obsolete| | Attachment #205702|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #121 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205978&action=edit Bug 30557: Add DataTables select extension Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #122 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205979&action=edit Bug 30557: Add DataTables additionalButtons Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #123 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205980&action=edit Bug 30557: Support column toggling in Vue KohaTable Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #124 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205981&action=edit Bug 30557: Support resource remove in Vue Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #125 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205982&action=edit Bug 30557: Allow resource lists to access a parent resource Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #126 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205983&action=edit Bug 30557: Allow using parentResource to decide table actions Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #127 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205984&action=edit Bug 30557: Allow adding additional DataTables event handlers Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #128 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205985&action=edit Bug 30557: Use select label in ResourceList cells Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #129 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205986&action=edit Bug 30557: Use legal property name for base resource emit Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #130 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205987&action=edit Bug 30557: Allow specifying a custom resource description function Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #131 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205988&action=edit Bug 30557: Allow putting KohaTable actions in dropdown Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #132 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205989&action=edit Bug 30557: Hide labels for hidden FormElements Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #133 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205990&action=edit Bug 30557: Allow undef group_feature for visibility checking Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #134 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205991&action=edit Bug 30557: Allow filtering patron API by permissions Test plan: 1. Prove t/db_dependent/api/v1/patrons.t Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #135 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205992&action=edit Bug 30557: Don't show dropdown if there are no actions Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #136 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205993&action=edit Bug 30557: Allow http client DELETEs to have a body Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #137 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205994&action=edit Bug 30557: Add a list-header slot to BaseResource Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #138 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205995&action=edit Bug 30557: DB updates Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #139 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205996&action=edit Bug 30557: DBIC updates (DO NOT PUSH) Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #140 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205997&action=edit Bug 30557: Additional Result class methods Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #141 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205998&action=edit Bug 30557: Add new permissions Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #142 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 205999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205999&action=edit Bug 30557: Add item list object classes Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #143 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206000&action=edit Bug 30557: Add Koha object unit tests Test plan: 1. Prove t/db_dependent/Koha/Item/List.t Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #144 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206001&action=edit Bug 30557: Add item lists REST API Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #145 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206002&action=edit Bug 30557: Add item lists REST API unit tests Test plan: 1. Prove t/db_dependent/api/v1/item_lists.t Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #146 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206003&action=edit Bug 30557: Add item lists Vue module Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #147 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206004&action=edit Bug 30557: Add Cypress tests for Vue module Test plan: 1. Ensure you have installed the new dependencies by running yarn install 2. Rebuild the JS bundles with yarn js:build 3. Run the Cypress spec t/cypress/integration/ItemLists_spec.ts In KTD you can do this with: cypress run -s t/cypress/integration/ItemLists_spec.ts Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #148 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206005&action=edit Bug 30557: Integrate adding items to item lists Test plan: 1. Navigate to Item Lists, and create a new item list with your user as the owner and any visibility. 2. Navigate to a Catalogue detail page, and select an item in its holdings table. 3. Verify an "Add selected items to list" button appears above the table. 4. Click this button, and add the item to the list you created earlier. 5. Return to the item list, clicking its name to view its items. 6. Verify the item you added appears in the list. 7. Remove the item from the list. 8. Navigate to Reports > Create from SQL, and create a new report with any name and the following SQL: SELECT itemnumber FROM items ORDER BY RAND() LIMIT 1 9. Run this report, and verify "Add items to list" appears under the "Batch operations with 1 visible records" dropdown. 10. Use this option to add the item to the list you created earlier. 11. Verify the item has been added to the list, and remove it again. 12. Navigate to Search > Item Search, and perform an empty search to list all items. 13. Select an item from the results, and the "Add to item list" button appears at the top of the results table. 14. Use this button to add the item to the list you created earlier. 15. Verify the item has been added to the list, and remove it again. 16. Repeat steps 2-15, selecting "Add to list and view" from the modal's dropdown and verifying you are redirected to the list. 17. Repeat steps 2-16, creating a new list from the "Add items to item list" modal. Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #149 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to Olivia Reynolds from comment #120)
Thanks for all of the feedback!
Thank you! The latest patches address many small but meaningful ui/ux enhancements. We can file follow up bugs for anything else.
# On an item list page /koha/lists/items/1 - Filtering is not available for Location and Item Type columns
From what I can see, filtering by those column types isn't possible with Koha's current REST API setup, and I can't see a table with them where it does work.
Item search somehow builds dropdowns from authorized values for location and item type. Testing note: After running updatedatabase and yarn js:build for some reason I had to run reset_all before the cypress test would run successfully -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #150 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- t/db_dependent/api/v1/item_lists.t is failing for me with a lot of output. Looks like maybe it's due to overdue rules changes from BZ 10190? Test Summary Report ------------------- /kohadevbox/koha/t/db_dependent/api/v1/item_lists.t (Wstat: 256 (exited 1) Tests: 12 Failed: 1) Failed test: 12 Non-zero exit status: 1 Files=1, Tests=12, 13 wallclock secs ( 0.02 usr 0.00 sys + 9.31 cusr 0.96 csys = 10.29 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #151 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- (In reply to Andrew Fuerste-Henry from comment #150)
t/db_dependent/api/v1/item_lists.t is failing for me with a lot of output. Looks like maybe it's due to overdue rules changes from BZ 10190?
I'm afraid I can't reproduce those tests failing, even after rebasing on the latest main. Does running yarn api:bundle && koha-plack --restart kohadev beforehand help? If not, are you able to share the exact failures you're seeing, and I'll take a look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #152 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- hrm, would have sworn I had done both of those things. did a full reset, took ktd down and back up again, reapplied patches, etc. Tests passing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #153 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Looking really good! But: Per new coding guidelines, this should include logging of creation, edit, and deletion of item lists https://wiki.koha-community.org/wiki/Coding_Guidelines#ACTN2:_New_additions_... other minor feedback: - When viewing the contents of a list, there are checkboxes to select items but no actions to perform on those items after selecting them. Why have a checkbox? - From the list of lists (/cgi-bin/koha/lists/items) clicking Add items from the dropdown on a list's Edit button should take one directly to /cgi-bin/koha/lists/items/X/add. It currently goes to /cgi-bin/koha/lists/items/X - Similarly, clicking Add shares from the Edit dropdown should go to /cgi-bin/koha/lists/items/X/shares/add rather than /cgi-bin/koha/lists/items/X/shares -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #154 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 206111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206111&action=edit Bug 30557: (follow-up) Allow filtering authorised value columns Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #155 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 206112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206112&action=edit Bug 30557: (follow-up) Allow filtering item type Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #156 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 206113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206113&action=edit Bug 30557: (follow-up) Log actions on item lists Test plan: 1. Prove t/db_dependent/Koha/Item/List.t and verify all tests pass. Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #157 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 206114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206114&action=edit Bug 30557: (follow-up) Link directly to add forms from item list index Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #158 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- (In reply to Brendan Lawlor from comment #149)
Item search somehow builds dropdowns from authorized values for location and item type.
Thanks for pointing this out, I've submitted some follow-up patches that should allow filtering by these columns now. (In reply to Andrew Fuerste-Henry from comment #153)
- When viewing the contents of a list, there are checkboxes to select items but no actions to perform on those items after selecting them. Why have a checkbox?
I've tried to set this up, and I don't think the current structure of the Vue resources really works to do it. The options for the DataTable (including whether there are selection checkboxes) are defined before we know the details about the item list itself, which would let us determine whether we should show them or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206111|0 |1 is obsolete| | Attachment #206112|0 |1 is obsolete| | Attachment #206113|0 |1 is obsolete| | Attachment #206114|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #159 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206256&action=edit Bug 30557: (follow-up) Allow filtering authorised value columns Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #160 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206257&action=edit Bug 30557: (follow-up) Allow filtering item type Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #161 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206258&action=edit Bug 30557: (follow-up) Log actions on item lists Test plan: 1. Prove t/db_dependent/Koha/Item/List.t and verify all tests pass. Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #162 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206259&action=edit Bug 30557: (follow-up) Link directly to add forms from item list index Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #163 from Brendan Lawlor <blawlor@clamsnet.org> --- Drop downs for filtering by item type and location now work. Thanks Olivia! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #164 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (Hopefully) final nitpicks: - There should be a system preference to enable logging for item lists. It should be off at upgrade. - the log viewer tool should include Item Lists in its list of modules to search by - in log search results, the module should display as "Item lists" rather than "ITEM_LISTS" thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited|CLAMS, CLAMS |CLAMS list of Sponsors|<https://info.clamsnet.org/ |<https://info.clamsnet.org/ |> |> Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #165 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 206409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206409&action=edit Bug 30557: (follow-up) Polish action logs for item lists - Introduce "ItemListsLog" syspref to control logging - Correctly translate internal ITEM_LISTS module name - Add "Item lists" to action log filters Test plan: 1. Ensure the database is updated to include the new syspref. 2. Make sure the syspref "ItemListsLog" is disabled. 3. Create, edit, and then delete an item list. 4. Verify no action logs are created. 5. Enable the syspref "ItemListsLog" and repeat step 3. 6. Verify corresponding action logs are created. 7. Verify you can filter action logs to just include item lists, and only the relevant entries are displayed. 8. Verify you can filter action logs to exclude item lists, and none of the item list entries are displayed. 9. Prove t/db_dependent/Koha/Item/List.t, and verify all tests pass. Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #166 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- These most recent changes are small enough that I'd be happy to QA without another sign-off. That said: https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML7:_Use_system_pre... You're using C4:Context to check the syspref value when the coding guidelines say you should use the TT plugin instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #167 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #166)
These most recent changes are small enough that I'd be happy to QA without another sign-off. That said: https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML7: _Use_system_preference_TT_plugin
You're using C4:Context to check the syspref value when the coding guidelines say you should use the TT plugin instead.
Oop, apologies. Drank more coffee and realized that's only for template files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited|CLAMS |CLAMS, CLAMS list of Sponsors|<https://info.clamsnet.org/ |<https://info.clamsnet.org/ |> |> Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205978|0 |1 is obsolete| | Attachment #205979|0 |1 is obsolete| | Attachment #205980|0 |1 is obsolete| | Attachment #205981|0 |1 is obsolete| | Attachment #205982|0 |1 is obsolete| | Attachment #205983|0 |1 is obsolete| | Attachment #205984|0 |1 is obsolete| | Attachment #205985|0 |1 is obsolete| | Attachment #205986|0 |1 is obsolete| | Attachment #205987|0 |1 is obsolete| | Attachment #205988|0 |1 is obsolete| | Attachment #205989|0 |1 is obsolete| | Attachment #205990|0 |1 is obsolete| | Attachment #205991|0 |1 is obsolete| | Attachment #205992|0 |1 is obsolete| | Attachment #205993|0 |1 is obsolete| | Attachment #205994|0 |1 is obsolete| | Attachment #205995|0 |1 is obsolete| | Attachment #205996|0 |1 is obsolete| | Attachment #205997|0 |1 is obsolete| | Attachment #205998|0 |1 is obsolete| | Attachment #205999|0 |1 is obsolete| | Attachment #206000|0 |1 is obsolete| | Attachment #206001|0 |1 is obsolete| | Attachment #206002|0 |1 is obsolete| | Attachment #206003|0 |1 is obsolete| | Attachment #206004|0 |1 is obsolete| | Attachment #206005|0 |1 is obsolete| | Attachment #206256|0 |1 is obsolete| | Attachment #206257|0 |1 is obsolete| | Attachment #206258|0 |1 is obsolete| | Attachment #206259|0 |1 is obsolete| | Attachment #206409|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #168 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206434&action=edit Bug 30557: Add DataTables select extension Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #169 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206435&action=edit Bug 30557: Add DataTables additionalButtons Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #170 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206436&action=edit Bug 30557: Support column toggling in Vue KohaTable Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #171 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206437&action=edit Bug 30557: Support resource remove in Vue Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #172 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206438&action=edit Bug 30557: Allow resource lists to access a parent resource Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #173 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206439&action=edit Bug 30557: Allow using parentResource to decide table actions Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #174 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206440&action=edit Bug 30557: Allow adding additional DataTables event handlers Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #175 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206441&action=edit Bug 30557: Use select label in ResourceList cells Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #176 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206442&action=edit Bug 30557: Use legal property name for base resource emit Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #177 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206443&action=edit Bug 30557: Allow specifying a custom resource description function Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #178 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206444&action=edit Bug 30557: Allow putting KohaTable actions in dropdown Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #179 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206445&action=edit Bug 30557: Hide labels for hidden FormElements Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #180 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206446&action=edit Bug 30557: Allow undef group_feature for visibility checking Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #181 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206447&action=edit Bug 30557: Allow filtering patron API by permissions Test plan: 1. Prove t/db_dependent/api/v1/patrons.t Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #182 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206448&action=edit Bug 30557: Don't show dropdown if there are no actions Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #183 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206449&action=edit Bug 30557: Allow http client DELETEs to have a body Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #184 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206450&action=edit Bug 30557: Add a list-header slot to BaseResource Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #185 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206451&action=edit Bug 30557: DB updates Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #186 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206452&action=edit Bug 30557: DBIC updates (DO NOT PUSH) Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #187 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206453&action=edit Bug 30557: Additional Result class methods Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #188 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206454&action=edit Bug 30557: Add new permissions Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #189 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206455&action=edit Bug 30557: Add item list object classes Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #190 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206456&action=edit Bug 30557: Add Koha object unit tests Test plan: 1. Prove t/db_dependent/Koha/Item/List.t Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #191 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206457&action=edit Bug 30557: Add item lists REST API Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #192 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206458&action=edit Bug 30557: Add item lists REST API unit tests Test plan: 1. Prove t/db_dependent/api/v1/item_lists.t Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #193 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206459&action=edit Bug 30557: Add item lists Vue module Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #194 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206460&action=edit Bug 30557: Add Cypress tests for Vue module Test plan: 1. Ensure you have installed the new dependencies by running yarn install 2. Rebuild the JS bundles with yarn js:build 3. Run the Cypress spec t/cypress/integration/ItemLists_spec.ts In KTD you can do this with: cypress run -s t/cypress/integration/ItemLists_spec.ts Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #195 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206461&action=edit Bug 30557: Integrate adding items to item lists Test plan: 1. Navigate to Item Lists, and create a new item list with your user as the owner and any visibility. 2. Navigate to a Catalogue detail page, and select an item in its holdings table. 3. Verify an "Add selected items to list" button appears above the table. 4. Click this button, and add the item to the list you created earlier. 5. Return to the item list, clicking its name to view its items. 6. Verify the item you added appears in the list. 7. Remove the item from the list. 8. Navigate to Reports > Create from SQL, and create a new report with any name and the following SQL: SELECT itemnumber FROM items ORDER BY RAND() LIMIT 1 9. Run this report, and verify "Add items to list" appears under the "Batch operations with 1 visible records" dropdown. 10. Use this option to add the item to the list you created earlier. 11. Verify the item has been added to the list, and remove it again. 12. Navigate to Search > Item Search, and perform an empty search to list all items. 13. Select an item from the results, and the "Add to item list" button appears at the top of the results table. 14. Use this button to add the item to the list you created earlier. 15. Verify the item has been added to the list, and remove it again. 16. Repeat steps 2-15, selecting "Add to list and view" from the modal's dropdown and verifying you are redirected to the list. 17. Repeat steps 2-16, creating a new list from the "Add items to item list" modal. Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #196 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206462&action=edit Bug 30557: (follow-up) Allow filtering authorised value columns Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #197 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206463&action=edit Bug 30557: (follow-up) Allow filtering item type Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #198 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206464&action=edit Bug 30557: (follow-up) Log actions on item lists Test plan: 1. Prove t/db_dependent/Koha/Item/List.t and verify all tests pass. Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #199 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206465&action=edit Bug 30557: (follow-up) Link directly to add forms from item list index Sponsored-by: CLAMS Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 --- Comment #200 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206466&action=edit Bug 30557: (follow-up) Polish action logs for item lists - Introduce "ItemListsLog" syspref to control logging - Correctly translate internal ITEM_LISTS module name - Add "Item lists" to action log filters Test plan: 1. Ensure the database is updated to include the new syspref. 2. Make sure the syspref "ItemListsLog" is disabled. 3. Create, edit, and then delete an item list. 4. Verify no action logs are created. 5. Enable the syspref "ItemListsLog" and repeat step 3. 6. Verify corresponding action logs are created. 7. Verify you can filter action logs to just include item lists, and only the relevant entries are displayed. 8. Verify you can filter action logs to exclude item lists, and none of the item list entries are displayed. 9. Prove t/db_dependent/Koha/Item/List.t, and verify all tests pass. Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |26.11 Keywords| |rel_26_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |ability to save list of | |items. These lists are only | |accessible in the staff | |interface. Items may be | |added to a list from the | |biblio detail page, item | |search results, or report | |results. Lists may be | |private, accessible to | |specific libraries, or | |accessible to specific | |library groups. Lists may | |also be shared with | |specific users. Interaction | |with item lists is enabled | |via new permissions: | |create_item_lists, | |edit_item_lists, | |delete_item_lists, and | |manage_item_list_contents. | |Logging of list creation, | |modification, and deletion | |may be enabled via a new | |system preference, | |ItemListsLog. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org