https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 179489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179489 Bug 37344: Add a real solution for discharge cancellation Review of attachment 179489: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37344&attachment=179489) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt @@ +111,4 @@
[% END %] [% END %]
+<div class="modal fade" id="cancelDischargeModal" tabindex="-1" aria-labelledby="exampleModalLabel" aria-hidden="true">
"exampleModalLabel" @@ +124,5 @@
+ <input name="op" type="hidden" value="cud-cancel-discharge" /> + <div id="cancel_dicharge_alert" class="alert alert-danger" style="display:none;"></div> + <fieldset class="action"> + <p>Are you sure you want to cancel this discharge ? Borrower will again have right to check out books after this.</p> + [% SET discharge_cancellation = AuthorisedValues.GetAuthValueDropbox('DISCHARGE_CANCELLATION') %]
discharge_cancellation: name doesn't reflect that it's a list. @@ +127,5 @@
+ <p>Are you sure you want to cancel this discharge ? Borrower will again have right to check out books after this.</p> + [% SET discharge_cancellation = AuthorisedValues.GetAuthValueDropbox('DISCHARGE_CANCELLATION') %] + [% IF discharge_cancellation.count %] + <label for="cancellation-reason">Cancellation reason: </label> + <select class="cancellation-reason" name="cancellation-reason" id="modal-cancellation-reason">
Which part of the code will process the selected value? Test plan needs to actions this. @@ +141,5 @@
+ <div class="modal-footer"> + <input id="cancelModalConfirmBtn" type="submit" class="btn btn-danger" value="Confirm cancellation" /> + <button type="button" class="btn btn-default" data-bs-dismiss="modal">Cancel</button> + <!-- <button type="button" class="btn btn-secondary" data-bs-dismiss="modal">Close</button> + <button type="button" class="btn btn-primary">Save changes</button> -->
Forgotten comment? -- You are receiving this mail because: You are watching all bug changes.