[Bug 37344] New: Patrons with cancelled discharge are seen as discharged when suspended due to overdue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Bug ID: 37344 Summary: Patrons with cancelled discharge are seen as discharged when suspended due to overdue Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org GIVEN: 1 - A library with overdue suspension 2 - A user with a cancelled discharge 3 - The same user has an issue whose date_due is gone WHEN: 1 - The book is checked in 2 - The user connects to the OPAC THEN: The user can see they are suspended due to a discharge EXPECTED: The user can see they are suspended due to an overdue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- The issue is quite simple : If there is a suspension, the OPAC checks if a discharge is available. If there is one, they tell the user they have a discharge. Otherwise, it tells them they have been suspended. To cancel the discharge, the librarian only cancels the related suspension. The table discharge remains unchanged so the software has to consider that having a discharge + being suspended => being suspended due to discharge. However, in France at least, there are a few valid reasons to cancel a discharge : 1 - Patrons asking discharge by mistake 2 - Patrons needing to prove they have no debt toward library to defend their thesis, even if they stay in the same place. I propose adding two columns to discharge : 1 - Cancel date 2 - Cancel reason Then, if a discharge is cancelled, it should not be available anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39369 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39369 [Bug 39369] Button "generate discharge" should not validate again a validated discharge -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179461&action=edit Bug 37344: Add a real solution for discharge cancellation Note: if you experience issues with the behaviour of the "generate discharge" button while testing, you might want to have a look at BZ39369 TEST PLAN: Note: you will have to reset your db in the middle of the plan 0 - Set systempreference "useDischarge" to allow 1 - Add a discharge on Henry Acevedo (HA) 2 - Log in on the OPAC as HA 3 - Notice you are suspended due to discharge 4 - Remove the suspension due to the discharge 5 - Add another manual suspension to HA 6 - Log in on the OPAC as HA 7 - Notice you are still suspended due to the discharge 8 - Reset your db, Apply patch, updatedb, update db schema 9 - Add a discharge on HA, notice there are new columns 10 - Login to HA on the OPAC 11 - Notice you are suspended due to the discharge 12 - Remove the discharge using the "Delete" button in the discharge panel on the intranet 13 - Notice the new columns are now filled 14 - Add a new manual suspension to HA 15 - Login again as HA and notice your are not seen as discharged anymore Note for the QA - I'll provide tests at the end of the week -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37451 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 [Bug 37451] Restrictions due to discharge should not be able to be removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Thibault Keromnès <thibault.keromnes@univ-paris8.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibault.keromnes@univ-pari | |s8.fr Status|Needs Signoff |Failed QA --- Comment #3 from Thibault Keromnès <thibault.keromnes@univ-paris8.fr> --- On step 9 discharge.pl ends with error 500 Log reads: ==> /var/log/koha/kohadev/plack-error.log <== DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.cancellation_date' in 'field list' at /kohadevbox/koha/Koha/Patron/Discharge.pm line 257 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179461|0 |1 is obsolete| | --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179489&action=edit Bug 37344: Add a real solution for discharge cancellation Note: if you experience issues with the behaviour of the "generate discharge" button while testing, you might want to have a look at BZ39369 TEST PLAN: Note: you will have to reset your db in the middle of the plan 0 - Set systempreference "useDischarge" to allow 1 - Add a discharge on Henry Acevedo (HA) 2 - Log in on the OPAC as HA 3 - Notice you are suspended due to discharge 4 - Remove the suspension due to the discharge 5 - Add another manual suspension to HA 6 - Log in on the OPAC as HA 7 - Notice you are still suspended due to the discharge 8 - Reset your db, Apply patch, updatedb, update db schema 9 - Add a discharge on HA, notice there are new columns 10 - Login to HA on the OPAC 11 - Notice you are suspended due to the discharge 12 - Remove the discharge using the "Delete" button in the discharge panel on the intranet 13 - Notice the new columns are now filled 14 - Add a new manual suspension to HA 15 - Login again as HA and notice your are not seen as discharged anymore Note for the QA - I'll provide tests at the end of the week -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Note: I fixed something in kohastructure.sql, but I have no clue why you get this error, but it looks like it is related with the way our sandboxes generate the dbic files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #5)
Note: I fixed something in kohastructure.sql, but I have no clue why you get this error, but it looks like it is related with the way our sandboxes generate the dbic files
I was looking at this with Thibault at the KohaLa symposium and testing was done on a local Koha (KTD) so it's wasn't a sandbox quirk. ----
I fixed something in kohastructure.sql but I have no clue why you get this error,
That's weird. It seems that cancellation_date was in the DB and DBIx didn't found in it's schema and errored. But there was no reason cancellation_date to be in the DB because the v1 of you patch doesn't have it. o_O -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 179489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179489 Bug 37344: Add a real solution for discharge cancellation Review of attachment 179489: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37344&attachment=179489) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_37344.pl @@ +2,5 @@
+use Koha::Installer::Output qw(say_warning say_failure say_success say_info); + +return { + bug_number => "37344", + description => "Add columns cancellation_reason and cancellation_date to discharge",
Old name is still mentioned: cancellation_date. @@ +20,5 @@
+ + $dbh->do( + q{ + INSERT IGNORE INTO authorised_value_categories (category_name) VALUES + ('DISCHARGE_CANCELLATION')
There is divergence between an existing install and a new install. The insertion of the authorised_value stuff is only on existing installs. New ones won't have it. @@ +26,5 @@
+ ); + $dbh->do( + q{ + INSERT IGNORE INTO authorised_values (category, authorised_value, lib) VALUES + ('DISCHARGE_CANCELLATION','BORROWER_MISTAKE', 'Borrower asked a discharge by mistake'),
Terminology issue: https://wiki.koha-community.org/wiki/Terminology#P We keep "borrower" when it's existing stuff that would need refactor elsewhere and mess with SQL reports. So here when introducing new stuff, there is constraint to keep using "borrower". And there is a user facing string here also. They don't have technical constraints and we can always use the current terminology. @@ +36,5 @@
+ # tables + say $out "Added column 'discharges.cancelled'"; + say $out "Added column 'discharges.cancellation_reason'"; + say $out "Added authorized values"; + say $out "Added authorized values";
Duplicate line? ::: installer/data/mysql/kohastructure.sql @@ +2872,5 @@
`borrower` int(11) DEFAULT NULL, `needed` timestamp NULL DEFAULT NULL, `validated` timestamp NULL DEFAULT NULL, + `cancelled` timestamp DEFAULT NULL, + `cancellation_reason`varchar(32) DEFAULT NULL,
Divergence with dbrev on length. ---- If I understand correctly, the only data in this column will be from the DISCHARGE_CANCELLATION authorised values. If so, a comment would help document this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179763&action=edit Bug 37344: (follow-up) to be squashed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #9 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- The follow-up address all the required changes, but does not make sense for the branch, please squash it with the main patch after QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 179763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179763 Bug 37344: (follow-up) to be squashed Review of attachment 179763: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37344&attachment=179763) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_37344.pl @@ +27,5 @@
$dbh->do( q{ INSERT IGNORE INTO authorised_values (category, authorised_value, lib) VALUES + ('DISCHARGE_CANCELLATION','PATRON_MISTAKE', 'Patron asked a discharge by mistake'), + ('DISCHARGE_CANCELLATION','PATRON_STILL_NEEDS_ACCOUNT','Administration required a discharge however the patron still needs to use their account')
Discharge.pm still has an occurrence of BORROWER_MISTAKE. (I'm not sure of there are other cases) ::: installer/data/mysql/en/optional/auth_val.yml @@ +334,5 @@
authorised_value: "OPAC" lib: "Cancelled from the OPAC user page" + + + # Disharge cancellations
=> Discharge @@ +336,5 @@
+ + + # Disharge cancellations + - category: "DISCHARGE_CANCELLATION" + authorised_value: "PATRON_MISTAKE"
If Discharge.pm requires PATRON_MISTAKE/BORROWER_MISTAKE. And if the dbrev adds it on existing installs. Then it's not consistent with being in optional/auth_val.yml Which then as implications on «You must define at least one authorized value for the category DISCHARGE_CANCELLATION» But it's not clear where the value of <select class="cancellation-reason" name="cancellation-reason" id="modal-cancellation-reason"> Is processed so all the above is influence by eventual changes. ::: installer/data/mysql/kohastructure.sql @@ +2873,4 @@
`needed` timestamp NULL DEFAULT NULL, `validated` timestamp NULL DEFAULT NULL, `cancelled` timestamp DEFAULT NULL, + `cancellation_reason`varchar(80) DEFAULT NULL COMMENT 'authorised value CANCELLATION_REASON',
CANCELLATION_REASON => DISCHARGE_CANCELLATION DISCHARGE_CANCELLATION is the AV category. So that's what is the most needed to know. To know where the values come from. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 179489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179489 Bug 37344: Add a real solution for discharge cancellation Review of attachment 179489: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37344&attachment=179489) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt @@ +111,4 @@
[% END %] [% END %]
+<div class="modal fade" id="cancelDischargeModal" tabindex="-1" aria-labelledby="exampleModalLabel" aria-hidden="true">
"exampleModalLabel" @@ +124,5 @@
+ <input name="op" type="hidden" value="cud-cancel-discharge" /> + <div id="cancel_dicharge_alert" class="alert alert-danger" style="display:none;"></div> + <fieldset class="action"> + <p>Are you sure you want to cancel this discharge ? Borrower will again have right to check out books after this.</p> + [% SET discharge_cancellation = AuthorisedValues.GetAuthValueDropbox('DISCHARGE_CANCELLATION') %]
discharge_cancellation: name doesn't reflect that it's a list. @@ +127,5 @@
+ <p>Are you sure you want to cancel this discharge ? Borrower will again have right to check out books after this.</p> + [% SET discharge_cancellation = AuthorisedValues.GetAuthValueDropbox('DISCHARGE_CANCELLATION') %] + [% IF discharge_cancellation.count %] + <label for="cancellation-reason">Cancellation reason: </label> + <select class="cancellation-reason" name="cancellation-reason" id="modal-cancellation-reason">
Which part of the code will process the selected value? Test plan needs to actions this. @@ +141,5 @@
+ <div class="modal-footer"> + <input id="cancelModalConfirmBtn" type="submit" class="btn btn-danger" value="Confirm cancellation" /> + <button type="button" class="btn btn-default" data-bs-dismiss="modal">Cancel</button> + <!-- <button type="button" class="btn btn-secondary" data-bs-dismiss="modal">Close</button> + <button type="button" class="btn btn-primary">Save changes</button> -->
Forgotten comment? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179489|0 |1 is obsolete| | --- Comment #12 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179826&action=edit Bug 37344: Add a real solution for discharge cancellation Note: if you experience issues with the behaviour of the "generate discharge" button while testing, you might want to have a look at BZ39369 TEST PLAN: Note: you will have to reset your db in the middle of the plan 0 - Set systempreference "useDischarge" to allow 1 - Add a discharge on Henry Acevedo (HA) 2 - Log in on the OPAC as HA 3 - Notice you are suspended due to discharge 4 - Remove the suspension due to the discharge 5 - Add another manual suspension to HA 6 - Log in on the OPAC as HA 7 - Notice you are still suspended due to the discharge 8 - Reset your db, Apply patch, updatedb, update db schema 9 - Add a discharge on HA, notice there are new columns 10 - Login to HA on the OPAC 11 - Notice you are suspended due to the discharge 12 - Click on the "Delete" button in the discharge panel on the intranet 13 - On the modal select "Patron asked a discharge by mistake" and submit 14 - Notice the new columns are filled (cancellation reason should be PATRON_MISTAKE 15 - Add a new manual suspension to HA 16 - Login again as HA and notice your are not seen as discharged anymore Note for the QA - I'll provide tests at the end of the week -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179763|0 |1 is obsolete| | --- Comment #13 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179827&action=edit Bug 37344: (follow-up) to be squashed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #14 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179828&action=edit Bug 37344: (follow-up) to be squashed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Sonia Bouis <sonia.bouis@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sonia.bouis@univ-lyon3.fr Status|Needs Signoff |Failed QA --- Comment #15 from Sonia Bouis <sonia.bouis@univ-lyon3.fr> --- Hello, step 14 doesn't work: nothing happen when you click on "confirm cancellation" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Not reproduced on main on ktd, could someone retry the test please ? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |roman.dolny@jezuici.pl --- Comment #17 from Roman Dolny <roman.dolny@jezuici.pl> --- There is 'BORROWER_MISTAKE' as 'Reason of cancellation' no matter which reason I choose in modal. It is hard-codded in Discharge.pm: + $discharge->update( + { + cancelled => dt_from_string, + cancellation_reason => 'BORROWER_MISTAKE' + } + ); There is a typo in discharge.tt ('cancel_dicharge_alert' => 'cancel_discharge_alert') + <form id="cancel_modal_form" method="post" action="discharge.pl"> + <div class="modal-body"> + [% INCLUDE 'csrf-token.inc' %] + <input name="op" type="hidden" value="cud-cancel-discharge" /> + <div id="cancel_dicharge_alert" class="alert alert-danger" style="display:none;"></div> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #18 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181709&action=edit Bug 37344: (follow-up) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #19 from Roman Dolny <roman.dolny@jezuici.pl> --- Problem when applying a patch (p. 8): kohadev-koha@kohadevbox:koha(bug_37344)$ git bz apply 37344 Bug 37344 - Patrons with cancelled discharge are seen as discharged when suspended due to overdue 179826 - Bug 37344: Add a real solution for discharge cancellation 179827 - Bug 37344: (follow-up) to be squashed 179828 - Bug 37344: (follow-up) to be squashed 181709 - Bug 37344: (follow-up) Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 37344: Add a real solution for discharge cancellation Using index info to reconstruct a base tree... M Koha/Patron/Discharge.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt M members/discharge.pl Falling back to patching base and 3-way merge... Auto-merging members/discharge.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging Koha/Patron/Discharge.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 37344: Add a real solution for discharge cancellation hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-37344-Add-a-real-solution-for-discharge-cancel-s5vjzos4.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179826|0 |1 is obsolete| | Attachment #179827|0 |1 is obsolete| | Attachment #179828|0 |1 is obsolete| | Attachment #181709|0 |1 is obsolete| | --- Comment #20 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 182647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182647&action=edit Bug 37344: Add a real solution for discharge cancellation Note: if you experience issues with the behaviour of the "generate discharge" button while testing, you might want to have a look at BZ39369 TEST PLAN: Note: you will have to reset your db in the middle of the plan 0 - Set systempreference "useDischarge" to allow 1 - Add a discharge on Henry Acevedo (HA) 2 - Log in on the OPAC as HA 3 - Notice you are suspended due to discharge 4 - Remove the suspension due to the discharge 5 - Add another manual suspension to HA 6 - Log in on the OPAC as HA 7 - Notice you are still suspended due to the discharge 8 - Reset your db, Apply patch, updatedb, update db schema 9 - Add a discharge on HA, notice there are new columns 10 - Login to HA on the OPAC 11 - Notice you are suspended due to the discharge 12 - Click on the "Delete" button in the discharge panel on the intranet 13 - On the modal select "Patron asked a discharge by mistake" and submit 14 - Notice the new columns are filled (cancellation reason should be PATRON_MISTAKE 15 - Add a new manual suspension to HA 16 - Login again as HA and notice your are not seen as discharged anymore Note for the QA - I'll provide tests at the end of the week -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #21 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 182648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182648&action=edit Bug 37344: (follow-up) to be squashed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #22 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 182649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182649&action=edit Bug 37344: (follow-up) to be squashed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #23 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 182650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182650&action=edit Bug 37344: (follow-up) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #24 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Rebased on main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182647|0 |1 is obsolete| | --- Comment #25 from David Nind <david@davidnind.com> --- Created attachment 182747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182747&action=edit Bug 37344: Add a real solution for discharge cancellation Note: if you experience issues with the behaviour of the "generate discharge" button while testing, you might want to have a look at BZ39369 TEST PLAN: Note: you will have to reset your db in the middle of the plan 0 - Set systempreference "useDischarge" to allow 1 - Add a discharge on Henry Acevedo (HA) 2 - Log in on the OPAC as HA 3 - Notice you are suspended due to discharge 4 - Remove the suspension due to the discharge 5 - Add another manual suspension to HA 6 - Log in on the OPAC as HA 7 - Notice you are still suspended due to the discharge 8 - Reset your db, Apply patch, updatedb, update db schema 9 - Add a discharge on HA, notice there are new columns 10 - Login to HA on the OPAC 11 - Notice you are suspended due to the discharge 12 - Click on the "Delete" button in the discharge panel on the intranet 13 - On the modal select "Patron asked a discharge by mistake" and submit 14 - Notice the new columns are filled (cancellation reason should be PATRON_MISTAKE 15 - Add a new manual suspension to HA 16 - Login again as HA and notice your are not seen as discharged anymore Note for the QA - I'll provide tests at the end of the week Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182648|0 |1 is obsolete| | Attachment #182649|0 |1 is obsolete| | --- Comment #26 from David Nind <david@davidnind.com> --- Created attachment 182748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182748&action=edit Bug 37344: (follow-up) to be squashed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #27 from David Nind <david@davidnind.com> --- Created attachment 182749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182749&action=edit Bug 37344: (follow-up) to be squashed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182650|0 |1 is obsolete| | --- Comment #28 from David Nind <david@davidnind.com> --- Created attachment 182750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182750&action=edit Bug 37344: (follow-up) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #29 from David Nind <david@davidnind.com> --- Created attachment 182751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182751&action=edit Bug 37344: (follow-up) Fix wording for messages This fixes the wording for some messages. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Keywords| |release-notes-needed --- Comment #30 from David Nind <david@davidnind.com> --- I've suggested some changes to the wording in a follow-up (see below for details or review the diff). Some comments: 1. After you generate the discharge in the staff interface, the table is not shown. You need to select the "Discharges" tab to show it. 2. If you cancel the discharge, then generate the discharge again, it only shows the latest discharge - the history is not shown. 3. Shouldn't the value in the field for "Reason for cancellation" (now "Reason cancelled") be the authorized value's description, not the cancellation code? Testing notes (using KTD): 1. Update the database: updatedatabase 2. Update the schema: dbic 3. Restart everything: restart_all 4. Set system preference "useDischarge" to allow. 5. Update the username and password for Henry so that you can log in to the account on the OPAC. Suggested changes to messages in the follow-up ---------------------------------------------- koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt - "Confirm deletion" --> "Confirm cancellation" (everywhere else, including the button, says "Cancel" instead of delete) - Column heading for the table in discahrges: change from "Reason of cancellation" ==> "Reason cancelled" - <p>Are you sure you want to cancel this discharge ? Borrower will again have right to check out books after this.</p> ==> <p>Are you sure you want to cancel this discharge? The patron will be able to check out items again.</p> koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt - <p>Reasons why a discharge can be cancelled</p> ==> <p>Reasons for cancelling a discharge</p> installer/data/mysql/atomicupdate/bug_37344.pl - 'Patron asked a discharge by mistake' ==> 'The patron asked for a discharge by mistake.' - 'Administration required a discharge however the patron still needs to use their account' ==> 'A discharge was required, however the patron still needs to use their account.' installer/data/mysql/en/optional/auth_val.yml: - "Patron asked a discharge by mistake" ==> "The patron asked for a discharge by mistake." - "Administration required a discharge however the borrower still needs to use their account" ==> "A discharge is required, however the patron still needs to use their account." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182751|0 |1 is obsolete| | --- Comment #31 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 182907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182907&action=edit Bug 37344: (follow-up) Fix wording for messages This fixes the wording for some messages. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182747|0 |1 is obsolete| | --- Comment #32 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 184427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184427&action=edit Bug 37344: Add a real solution for discharge cancellation Note: if you experience issues with the behaviour of the "generate discharge" button while testing, you might want to have a look at BZ39369 TEST PLAN: Note: you will have to reset your db in the middle of the plan 0 - Set systempreference "useDischarge" to allow 1 - Add a discharge on Henry Acevedo (HA) 2 - Log in on the OPAC as HA 3 - Notice you are suspended due to discharge 4 - Remove the suspension due to the discharge 5 - Add another manual suspension to HA 6 - Log in on the OPAC as HA 7 - Notice you are still suspended due to the discharge 8 - Reset your db, Apply patch, updatedb, update db schema 9 - Add a discharge on HA, notice there are new columns 10 - Login to HA on the OPAC 11 - Notice you are suspended due to the discharge 12 - Click on the "Delete" button in the discharge panel on the intranet 13 - On the modal select "Patron asked a discharge by mistake" and submit 14 - Notice the new columns are filled (cancellation reason should be PATRON_MISTAKE 15 - Add a new manual suspension to HA 16 - Login again as HA and notice your are not seen as discharged anymore Note for the QA - I'll provide tests at the end of the week -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182748|0 |1 is obsolete| | Attachment #182749|0 |1 is obsolete| | --- Comment #33 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 184428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184428&action=edit Bug 37344: (follow-up) to be squashed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #34 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 184429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184429&action=edit Bug 37344: (follow-up) to be squashed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182750|0 |1 is obsolete| | --- Comment #35 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 184430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184430&action=edit Bug 37344: (follow-up) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182907|0 |1 is obsolete| | --- Comment #36 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 184431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184431&action=edit Bug 37344: (follow-up) Fix wording for messages This fixes the wording for some messages. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184427|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184428|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184429|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184430|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184431|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #37 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185361&action=edit Bug 37344: Add a real solution for discharge cancellation Note: if you experience issues with the behaviour of the "generate discharge" button while testing, you might want to have a look at BZ39369 TEST PLAN: Note: you will have to reset your db in the middle of the plan 0 - Set systempreference "useDischarge" to allow 1 - Add a discharge on Henry Acevedo (HA) 2 - Log in on the OPAC as HA 3 - Notice you are suspended due to discharge 4 - Remove the suspension due to the discharge 5 - Add another manual suspension to HA 6 - Log in on the OPAC as HA 7 - Notice you are still suspended due to the discharge 8 - Reset your db, Apply patch, updatedb, update db schema 9 - Add a discharge on HA, notice there are new columns 10 - Login to HA on the OPAC 11 - Notice you are suspended due to the discharge 12 - Click on the "Delete" button in the discharge panel on the intranet 13 - On the modal select "Patron asked a discharge by mistake" and submit 14 - Notice the new columns are filled (cancellation reason should be PATRON_MISTAKE 15 - Add a new manual suspension to HA 16 - Login again as HA and notice your are not seen as discharged anymore 17 - Run `prove t/db_dependent/Patron/Borrower_Discharge.t` Note for the QA - I'll provide tests at the end of the week -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #38 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185362&action=edit Bug 37344: Update test suite -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #39 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185363&action=edit Bug 37344: (follow-up) To be squashed This fix: - Solves the issues from qa script - Update the function to add more consistency - Add pod documentation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #40 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185364&action=edit Bug 37344: [DO NOT PUSH] Dbix changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off Version(s)| |This patch adds a way to released in| |cancel a discharge and | |provide a reason why the | |discharge was cancelled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here. Just wondering at first glance if this should be an enh ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #42 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> ---
If there is a suspension, the OPAC checks if a discharge is available. If there is one, they tell the user they have a discharge. Otherwise, it tells them they have been suspended. (Comment 1)
This is the initial bug, which is still corrected by the enhancement and cannot be fixed in an easy way. I am not sure if we should set this as a minor bug or enhancement. https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines#Severity doesn't help me for disambiguation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #43 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #42)
If there is a suspension, the OPAC checks if a discharge is available. If there is one, they tell the user they have a discharge. Otherwise, it tells them they have been suspended. (Comment 1)
This is the initial bug, which is still corrected by the enhancement and cannot be fixed in an easy way. I am not sure if we should set this as a minor bug or enhancement. https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines#Severity doesn't help me for disambiguation.
It does not feel like a bugfix anymore. And bugfixes with dbrevs are not that popular too ;) I would classify as an enh. Chances for backports being low. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA comments: # TODO This module should be based on Koha::Object[s] This is very true indeed. But not the scope of this report. But we feel it here. Looking at various subroutines in Koha/Patron/Discharge I am wondering if we need to also check cancelled now. sub count ? sub get_pendings ? sub get_validated ? Not sure if we get bitten by that omission somewhere else. Intuitively, I tend to think so. Can we fix the sign-off lines? Or do we need another signoff for testing? Apart from the above and looking at some git greps with discharge, this feels safe enough to get further. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #45 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- And just an observation from the current code: my $available = Koha::Patron::Discharge::is_discharged( { borrowernumber => $loggedinuser } ); This was quite confusing. To say if a patron has been discharged, it is available.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 --- Comment #46 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- (In reply to Marcel de Rooy from comment #43)
(In reply to Baptiste Wojtkowski (bwoj) from comment #42)
If there is a suspension, the OPAC checks if a discharge is available. If there is one, they tell the user they have a discharge. Otherwise, it tells them they have been suspended. (Comment 1)
This is the initial bug, which is still corrected by the enhancement and cannot be fixed in an easy way. I am not sure if we should set this as a minor bug or enhancement. https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines#Severity doesn't help me for disambiguation.
It does not feel like a bugfix anymore. And bugfixes with dbrevs are not that popular too ;) I would classify as an enh. Chances for backports being low.
I agree, I reported it in the documentation :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|This patch adds a way to |This enhancement adds a way released in|cancel a discharge and |to cancel a discharge and |provide a reason why the |provide a reason why the |discharge was cancelled. |discharge was cancelled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|This enhancement adds a way | released in|to cancel a discharge and | |provide a reason why the | |discharge was cancelled. | Keywords|release-notes-needed | CC| |lisette@bywatersolutions.co | |m Text to go in the| |This enhancement adds a way release notes| |to cancel a discharge and | |provide a reason why the | |discharge was cancelled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED --- Comment #47 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- I'm stuck on this one, I prefer working on reworking Discharge to use Koha::Object and then come back here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43471 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43471 [Bug 43471] Koha/Discharge.pm should inherit from Koha::Object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|43471 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43471 [Bug 43471] Koha/Discharge.pm should inherit from Koha::Object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43471 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43471 [Bug 43471] Koha/Discharge.pm should inherit from Koha::Object -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org