http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #20 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Patch still applies! +1 for unit tests. I have some hesitations however on signing this off: [1] The unit test contains: $dbh->do("INSERT INTO auth_types(authtypecode, authtypetext, auth_tag_to_report, summary) VALUES('TEST_PERSO', 'Personal Name', '109', 'Personal Names');"); This is only valid for UNIMARC. What about MARC21? [2] You do not include test plans. This could be a reason why this report has not received much attention lately. Changing status to Failed QA. -- You are receiving this mail because: You are watching all bug changes.