[Bug 11700] New: C4::AuthoritiesMarc::merge enhancements/fixes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bug ID: 11700 Summary: C4::AuthoritiesMarc::merge enhancements/fixes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 7419 patches contains several enhancements and fixes for subroutine C4::AuthoritiesMarc::merge. This bug is complicated to test so I will remove changes to this subroutine from bug 7419 and put it here. So maybe it will increase the chances to push these patches into master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25086&action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes - Returns the list of modified biblio records - Retrieve MARC records from DB if not given in parameters - Delete source authority if source and destination records are different - Indentation and whitespace fixes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7419 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Should not a change in functionality of core routine C4 or Koha mean that there should be an associated test for the routine somewhere? I notice that this routine seems to be only used on authorities/merge.pl, and it doesn't even check the return value currently. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Please also note: http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL6:_Indentation "If you want to reindent large amounts of existing code in connection with a bugfix or enhancement, you must do so in a separate patch from the one with code changes (unless the reindent is required due to the addition or removal of an indentation level (for example, an additional if added around a block)." 1422 -- not necessary. There are several other lines, which I am assuming are white space fixes. 1497-1512 -- fixed indention was not necessary. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25086|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25413&action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Indentation and whitespace fixes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25414&action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes - Returns the list of modified biblio records - Retrieve MARC records from DB if not given in parameters - Delete source authority if source and destination records are different -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- I split patch in two parts: 1) whitespace fixes 2) real changes I'll try to write unit tests asap -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25426&action=edit Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel@gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Small conflict on t/db_dependent/AuthoritiesMarc.t, but problem is that tests fail prove -v t/db_dependent/AuthoritiesMarc.t t/db_dependent/AuthoritiesMarc.t .. 1..15 ok 1 - use C4::AuthoritiesMarc; "my" variable $dbh masks earlier declaration in same scope at t/db_dependent/AuthoritiesMarc.t line 196. ok 2 - Built linked authtrees hierarchy string ok 3 - Generated hierarchy data structure for linked hierarchy ok 4 - Built unlinked authtrees hierarchy string ok 5 - Generated hierarchy data structure for unlinked hierarchy ok 6 - test BuildSummary for MARC21 ok 7 - BuildSummary does not generate warning if main heading subfield not present ok 8 - test BuildSummary for UNIMARC Can't call method "subfield" on an undefined value at /home/bgkriegel/kohaclone/C4/AuthoritiesMarc.pm line 1476. # Looks like you planned 15 tests but ran 8. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25413|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 27970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27970&action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25414|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 27971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27971&action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25426|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 27972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27972&action=edit Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 27973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27973&action=edit Bug 11700: Fix unit tests when index mode is 'dom' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Problem was the mock for ZOOM::Record::raw was always returning iso2709 records whereas new_record_from_zebra expect MARCXML when biblio index mode is 'dom'. Tests should pass now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- How does this bug relate to bug 5572? The description of this bug is rather generic, could you specify what 'enhancements' this actually brings to the table please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |gmcharlt@gmail.com --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- This patch series should be accompanied by an update to authorities/merge.pl for two reasons: [1] Why change the return of C4::AuthoritiesMarc::merge if the return value is going to be thrown away? [2] authorities/merge.pl has a call to DelAuthority, but that would be made redundant by this patch series. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Galen Charlton from comment #15)
[1] Why change the return of C4::AuthoritiesMarc::merge if the return value is going to be thrown away?
This return value is used by UT and by the script dedup_authorities.pl introduced by bug 7419.
[2] authorities/merge.pl has a call to DelAuthority, but that would be made redundant by this patch series.
Yes it is. Patch coming. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28176&action=edit Bug 11700: Avoid to try to delete the authority twice -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #17)
Created attachment 28176 [details] [review] Bug 11700: Avoid to try to delete the authority twice
Not sure dying is the best thing to do... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28176|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28177&action=edit Bug 11700: Avoid to try to delete the authority twice -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #20 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Patch still applies! +1 for unit tests. I have some hesitations however on signing this off: [1] The unit test contains: $dbh->do("INSERT INTO auth_types(authtypecode, authtypetext, auth_tag_to_report, summary) VALUES('TEST_PERSO', 'Personal Name', '109', 'Personal Names');"); This is only valid for UNIMARC. What about MARC21? [2] You do not include test plans. This could be a reason why this report has not received much attention lately. Changing status to Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #21 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Hm. I cannot find any reference to field 109 in unimarc too? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- OK. I had a closer look. But we are not there yet: I added some debug prints to the unit test: warn "L251a"; my @biblios = C4::AuthoritiesMarc::merge($authid2, undef, $authid1, undef); warn "L251b"; produces this: L251a at t/db_dependent/AuthoritiesMarc.t line 251. Use of uninitialized value $self in pattern match (m//) at /usr/local/share/perl5/MARC/File/XML.pm line 441. Can't call method "subfield" on an undefined value at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 1483. # Looks like you planned 15 tests but ran 8. # Looks like your test exited with 255 just after 8. Since the 251b warn is not issued anymore, the error is somewhere in the call to merge.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #21)
Hm. I cannot find any reference to field 109 in unimarc too?
Julian has certainly chosen 109 arbitrarily. The tests pass on a MARC21 installation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #24 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #23)
(In reply to M. de Rooy from comment #21)
Hm. I cannot find any reference to field 109 in unimarc too?
Julian has certainly chosen 109 arbitrarily. The tests pass on a MARC21 installation.
Not always. See comment22. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Marcel, Unfortunately I am not able to reproduce your problem. Could you add some debug prints in the mock of ZOOM::Record::raw (line 242 of t/db_dependent/AuthoritiesMarc.t) ? Maybe something like this, just before the return: warn "biblionumber: " . $this->{_rec}->{biblionumber}; warn "marc: " . $marcs->[0]; This should tell us if the mocks don't work, if the record is not inserted in database, or if it's something else. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Jonathan reproduced the bug on one of the sandbox, so no need to do this on your side. I think I've found the problem and will submit a patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #27 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35107&action=edit Bug 11700: Fix unit test when index mode is not defined Use the same default value as everywhere (dom) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13706 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13762 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13760 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #28 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #19)
Created attachment 28177 [details] [review] Bug 11700: Avoid to try to delete the authority twice There is also a delete after merge in misc/migration_tools/merge_authority.pl.
(In reply to Jonathan Druart from comment #18)
(In reply to Jonathan Druart from comment #17)
Created attachment 28176 [details] [review] [review] Bug 11700: Avoid to try to delete the authority twice
Not sure dying is the best thing to do... Same for me, a warn is enough.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27970|0 |1 is obsolete| | --- Comment #29 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39264&action=edit [SIGNED_OFF] Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Indentation and whitespace fixes Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27971|0 |1 is obsolete| | --- Comment #30 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39265&action=edit [SIGNED_OFF] Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes - Returns the list of modified biblio records - Retrieve MARC records from DB if not given in parameters - Delete source authority if source and destination records are different Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27972|0 |1 is obsolete| | --- Comment #31 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39266&action=edit [SIGNED_OFF] Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27973|0 |1 is obsolete| | --- Comment #32 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39267&action=edit [SIGNED_OFF] Bug 11700: Fix unit tests when index mode is 'dom' Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28177|0 |1 is obsolete| | --- Comment #33 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39268&action=edit [SIGNED_OFF] Bug 11700: Avoid to try to delete the authority twice Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35107|0 |1 is obsolete| | --- Comment #34 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39269&action=edit [SIGNED_OFF] Bug 11700: Fix unit test when index mode is not defined Use the same default value as everywhere (dom) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested mergin auths, no problems Test runs Ok No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Julian, can you please add a test plan? Also, please make the new tests output something useful :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39264|0 |1 is obsolete| | --- Comment #36 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 40968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40968&action=edit [SIGNED_OFF] Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39265|0 |1 is obsolete| | --- Comment #37 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 40969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40969&action=edit [SIGNED_OFF] Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39268|0 |1 is obsolete| | --- Comment #38 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 40970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40970&action=edit [SIGNED_OFF] Bug 11700: Avoid to try to delete the authority twice Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39266|0 |1 is obsolete| | Attachment #39267|0 |1 is obsolete| | Attachment #39269|0 |1 is obsolete| | --- Comment #39 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 40971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40971&action=edit [SIGNED_OFF] Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge Rebased on master and squashed with others unit tests patches -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #40 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 40972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40972&action=edit Bug 11700: Add description to unit tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #41 from Julian Maurice <julian.maurice@biblibre.com> --- Test plan: 1/ Launch unit tests: prove t/db_dependent/AuthoritiesMarc.t 2/ Check the authorities merge feature still works (search for authorities in staff interface and click 'Merge' on two different authorities, possibly used by 1 or more biblios) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a bit of a mixed bag of things - can you please add test plans to the 2nd and 3rd patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40968|0 |1 is obsolete| | Attachment #40969|0 |1 is obsolete| | Attachment #40970|0 |1 is obsolete| | Attachment #40971|0 |1 is obsolete| | Attachment #40972|0 |1 is obsolete| | --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45048&action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Indentation and whitespace fixes Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45048|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45049&action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes - Returns the list of modified biblio records - Retrieve MARC records from DB if not given in parameters - Delete source authority if source and destination records are different Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45050&action=edit Bug 11700: Avoid to try to delete the authority twice Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45051&action=edit Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45052&action=edit Bug 11700: Add description to unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45053&action=edit Bug 11700 [QA Followup] - Tidy merge a bit, fix warning triggered during unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Patch doesn't apply --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Patch set no longer applies cleanly, please rebase and reset status to passed qa! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Merging authorities is broken currently - see bug 15358 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45049|0 |1 is obsolete| | --- Comment #51 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 46397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46397&action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Indentation and whitespace fixes Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #52 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 46398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46398&action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes - Returns the list of modified biblio records - Retrieve MARC records from DB if not given in parameters - Delete source authority if source and destination records are different Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45050|0 |1 is obsolete| | --- Comment #53 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 46399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46399&action=edit Bug 11700: Avoid to try to delete the authority twice Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45051|0 |1 is obsolete| | --- Comment #54 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 46400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46400&action=edit Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45052|0 |1 is obsolete| | --- Comment #55 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 46401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46401&action=edit Bug 11700: Add description to unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45053|0 |1 is obsolete| | --- Comment #56 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 46402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46402&action=edit Bug 11700 [QA Followup] - Tidy merge a bit, fix warning triggered during unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #57 from Julian Maurice <julian.maurice@biblibre.com> --- All patches rebased on master. Resetting status to Signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED Depends on| |13762 --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Setting this to BLOCKED because of bug 13762 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 [Bug 13762] biblionumber field and subfield can be called once in authorities merge -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org