http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff CC| |paul.poulain@biblibre.com --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #12)
Kyle: What do you think about this last patch? Do you agree with it?
Fridolyn: Why do you remove the circulate_remaining_permissions permission?
Looking at both patches, my comments: * the initial one (2.62kb) fails QA : a permission is added in english only. I also think it should be related to circulation, because the report is in circ directory, so let be consistent * Frido, your patch (the 11.01KB one) is written "From: Kyle Hall". Am I misunderstanding something, or that's a mistake ? Will mark the 1st one as obsolete, and back to need signoff for the 11.01KB one ! (note : I haven't tested any of those patches yet) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.