[Bug 6898] New: circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Bug #: 6898 Summary: circulation librarians can't run overdues without reports permissions Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Reports AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org This is related to bug 5874 which made it so that you couldn't run overdues without the execute reports permissions. This change is not seen as a fix but more as a bug by most libraries who don't want their circ staff running reports via the reports module but thought that reports listed on the circulation page were not linked to that. I move that we instead have a new permission for running circulation reports so that those reports can be controlled separately from the reports module - otherwise why are they not listed with the other reports on the reports module? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-10-27 16:52:19 UTC --- What separate permissions should there be? I think the reason for wrapping the overdues report in a reports permission was to prevent people from running a resource-intensive script. If we add a circulation reports permission, do we need two "levels" of circ report permission? - run standard circ reports (like hold queue) - run heavy circ reports (overdues) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-11-05 19:19:53 UTC --- I'm open to anything that allows libraries to have their circ staff run the circulation reports without needing access to run all reports. That's the way it has been since 3.0 and seems strange to remove those rights at this point. As for the resource intensive script - that's why we have the preference to show filters first. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #3 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-10 15:50:21 UTC --- Created attachment 7568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7568 Bug 6898 - circulation librarians can't run overdues without reports permissions This commit adds a new user permission execute_overdues_report for the reports module, and requires this permission to run the overdue items report, rather than requiring full reports permissions. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle.m.hall@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #4 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-10 15:54:01 UTC --- *** Bug 5874 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |kyle.m.hall@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- Bug 6898 - circulation librarians can't run overdues without reports permissions Apply? [yn] y Applying: Bug 6898 - circulation librarians can't run overdues without reports permissions error: patch failed: installer/data/mysql/updatedatabase.pl:4663 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Bug 6898 - circulation librarians can't run overdues without reports permissions When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-6898---circulation-librarians-cant-run-overdue-8sdIWz.patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7568|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8233&action=edit Bug 6898 - circulation librarians can't run overdues without reports permissions This commit adds a new user permission execute_overdues_report for the reports module, and requires this permission to run the overdue items report, rather than requiring full reports permissions. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- With execute_overdues_report and all circulation permissions the link to the overdues report does not show and if you click Overdues with Fines you get this: Software error: Undefined subroutine &C4::Members::checkoverdues called at /home/nengard/kohaclone/C4/Members.pm line 475. For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. With permission to execute overdues but not access circ you can't see the report. I think for this we should just add a note that circ permissions is also required to execute overdues. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #8 from Kyle M Hall <kyle.m.hall@gmail.com> --- Are you sure your error is related to this patch? It likely that it may be that the codebase you applied that patch to was already borked beforehand. (In reply to comment #7)
With execute_overdues_report and all circulation permissions the link to the overdues report does not show and if you click Overdues with Fines you get this:
Software error:
Undefined subroutine &C4::Members::checkoverdues called at /home/nengard/kohaclone/C4/Members.pm line 475.
For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error.
With permission to execute overdues but not access circ you can't see the report. I think for this we should just add a note that circ permissions is also required to execute overdues.
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #9 from Nicole C. Engard <nengard@gmail.com> --- Kyle, You are right, the problem with the overdues with fines report is broken in master. But there were other issues as well. Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 jatara <jatara.barnes@pisd.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jatara.barnes@pisd.edu Patch complexity|--- |Medium patch --- Comment #10 from jatara <jatara.barnes@pisd.edu> --- Are there any updates to this? It is now December and a fix hasn't made it into the codebase yet. It is worth trying to get this completed because this feature is very much needed. There is no reason that every staff member should have access to the entire set of reports. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion Assignee|kyle.m.hall@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #11 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 14680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14680&action=edit Proposed patch (circulation permission) I renew discussion with a rewritten patch. I tested proposed patch and noticed a permission into reports module gives access to nearly entire reports module. I think this module is designed for only the two existing permissions. I propose a permission of circulation module dedicated to overdues page. Patch adds database scripts for all languages. I only translated french, translations are welcome. Also adds management of the "Overdues" link in circulation home page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle: What do you think about this last patch? Do you agree with it? Fridolyn: Why do you remove the circulate_remaining_permissions permission? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff CC| |paul.poulain@biblibre.com --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #12)
Kyle: What do you think about this last patch? Do you agree with it?
Fridolyn: Why do you remove the circulate_remaining_permissions permission?
Looking at both patches, my comments: * the initial one (2.62kb) fails QA : a permission is added in english only. I also think it should be related to circulation, because the report is in circ directory, so let be consistent * Frido, your patch (the 11.01KB one) is written "From: Kyle Hall". Am I misunderstanding something, or that's a mistake ? Will mark the 1st one as obsolete, and back to need signoff for the 11.01KB one ! (note : I haven't tested any of those patches yet) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8233|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #14 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #12)
Kyle: What do you think about this last patch? Do you agree with it?
Fridolyn: Why do you remove the circulate_remaining_permissions permission?
I think "circulate_remaining_permissions" is not needed when a permission exists for a page. Like it says in its name "circulate_remaining_permissions" is for pages that do not have a dedicated permission. Of course, giving only overdues permission will rarely be used. But we can imagine a librarian having only reports permissions, he can have only overdues permission to access the page (via a bookmark maybe) and not the rest of circulation module. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- That makes sense to me! (In reply to comment #14)
(In reply to comment #12)
Kyle: What do you think about this last patch? Do you agree with it?
Fridolyn: Why do you remove the circulate_remaining_permissions permission?
I think "circulate_remaining_permissions" is not needed when a permission exists for a page. Like it says in its name "circulate_remaining_permissions" is for pages that do not have a dedicated permission.
Of course, giving only overdues permission will rarely be used. But we can imagine a librarian having only reports permissions, he can have only overdues permission to access the page (via a bookmark maybe) and not the rest of circulation module.
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14680|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15162&action=edit Bug 6898 - circulation librarians can't run overdues without reports permissions This patch adds a new user permission overdues_report for the circulation module, and requires this permission to run the overdue items report, rather than requiring full reports permissions. Test plan : With a user with permissions circulate_remaining_permissions : - Add overdues_report permission to user - Go to circulation home => you see "Overdues" link - Clik on it => you are allowed to access and use this page - Remove overdues_report permission to user - Go to circulation home => you do not see "Overdues" link - Edit URL : <server>/cgi-bin/koha/circ/overdue.pl => you are not allowed to access this page - Go to main page => you don't have access to reports module Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #17 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- I have to create a follow-up to have a better updatedatabase : when a user has report permissions, this new permission must be set. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #17)
I have to create a follow-up to have a better updatedatabase : when a user has report permissions, this new permission must be set.
Good point. Setting to 'Failed QA' for now. Kyle -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #19 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15939&action=edit Proposed patch (followup) Follow up for better update database. Adds new permission for users with all report permissions and circulation remaining permission. This will not concern user having all circulation permissions. There is no need because when all module is permitted, sub-permissions does not exist in user_permissions, module permission is stored into borrowers.flags. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #20 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- I set status to signed-off. Followup can be validated by QA ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15939|0 |1 is obsolete| | --- Comment #21 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15940&action=edit Proposed patch (followup) Small error in first patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15940|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15946&action=edit [SIGNED-OFF] Bug 6898 - circulation librarians can't run overdues without reports permissions followup Better update database. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #20)
I set status to signed-off. Followup can be validated by QA ?
Fridolyn, I don't see your SO on my original patch. Kyle -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15162|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15947&action=edit Bug 6898 - circulation librarians can't run overdues without reports permissions This patch adds a new user permission overdues_report for the circulation module, and requires this permission to run the overdue items report, rather than requiring full reports permissions. Test plan : With a user with permissions circulate_remaining_permissions : - Add overdues_report permission to user - Go to circulation home => you see "Overdues" link - Clik on it => you are allowed to access and use this page - Remove overdues_report permission to user - Go to circulation home => you do not see "Overdues" link - Edit URL : <server>/cgi-bin/koha/circ/overdue.pl => you are not allowed to access this page - Go to main page => you don't have access to reports module Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15946|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15948&action=edit [SIGNED-OFF] Bug 6898 - circulation librarians can't run overdues without reports permissions followup Better update database. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- I've uploaded a rebased version of the patch. Also, thanks for the followup Fridolyn! (In reply to comment #23)
(In reply to comment #20)
I set status to signed-off. Followup can be validated by QA ?
Fridolyn, I don't see your SO on my original patch.
Kyle
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15947|0 |1 is obsolete| | --- Comment #27 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15966&action=edit [SIGNED-OFF] Bug 6898 - circulation librarians can't run overdues without reports permissions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #28 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #23)
(In reply to comment #20)
I set status to signed-off. Followup can be validated by QA ?
Fridolyn, I don't see your SO on my original patch.
Kyle
Here it is. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15966|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15974&action=edit Bug 6898 - circulation librarians can't run overdues without reports permissions Reuploading to correct patch order. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15948|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15975&action=edit Bug 6898 - circulation librarians can't run overdues without reports permissions followup Reuploading to correct patch order. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch adds a new permission (overdues_report) for the circulation module. This permission allows a librarian to access to the overdues page. The updatedb script updates user permissions for users having permissions for the report module + circulate_remaining_permissions (same behavior as before). There is no link to this page (so nothing to hide). Marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #32 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16034&action=edit Bug 6898 - circulation librarians can't run overdues without reports permissions This patch adds a new user permission overdues_report for the circulation module, and requires this permission to run the overdue items report, rather than requiring full reports permissions. Test plan : With a user with permissions circulate_remaining_permissions : - Add overdues_report permission to user - Go to circulation home => you see "Overdues" link - Clik on it => you are allowed to access and use this page - Remove overdues_report permission to user - Go to circulation home => you do not see "Overdues" link - Edit URL : <server>/cgi-bin/koha/circ/overdue.pl => you are not allowed to access this page - Go to main page => you don't have access to reports module Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Fridolyn SOMERS <fridolyn.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16035&action=edit Bug 6898 - circulation librarians can't run overdues without reports permissions followup Better update database. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15974|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #34 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #35 from Nicole C. Engard <nengard@gmail.com> --- I did a pull from master just now and I don't see a new permission. I was prompted to upgrade my database, but the upgrade notes said nothing about adding a new permission. Are we sure that this new permission is added properly on upgrade? Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #36 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Shows up in updatedatabase for me. "Add circ permission overdues_report" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #37 from Nicole C. Engard <nengard@gmail.com> --- How would I force another update database? Like I said it did prompt me to upgrade and I did, but there was no note about the new permission and the new permission is not showing at all on my patron records. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #38 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #37)
How would I force another update database? Like I said it did prompt me to upgrade and I did, but there was no note about the new permission and the new permission is not showing at all on my patron records.
Set the version back to 3.1100026. I was on a slightly older version of master when I tested it. I found and fixed the problem so all should be working now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #39 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 16207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16207&action=edit update screen .26 to .30 I'm sorry but it's not updating the database with the new permissions. This is all I get when upgrading from .26 to .30: Update report : Upgrade to 3.11.00.030 done (Add system preference FinesIncludeGracePeriod) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #40 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 16208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16208&action=edit update summary there is no new patron permission added to the db and when i look at a patron record there is no new permission to choose. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #41 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- And you updated master again? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #42 from Nicole C. Engard <nengard@gmail.com> --- I did update master again. I tested on another machine and it worked okay so I went back further on this one and it finally updated - something maybe with the update from .26-.30 because when you do .25 to .100 it works a-ok. Anyway, it's not a probably with this patch or one that most people upgrading will encounter cause they will be going from stable to stable. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #43 from Melia Meggs <melia@bywatersolutions.com> --- Is this patch going to make it into 3.10.x stable? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #44 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #45 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Small problem : Second query in updatedatabase is not executed. This second query added by followup patch is not mandatory, so maybe correcting updatedatabase.pl is enough. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #46 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 18670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18670&action=edit Bug 6898 - updatedatabase second query not executed Patch to correct updatedatabase. I created it on the bug branch but it applies on a master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #47 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Fridolyn: Are you sure that this will really fix your problem? Just updating an older dbrev will not help someone that never comes back to that piece of code.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #48 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #47)
Fridolyn: Are you sure that this will really fix your problem? Just updating an older dbrev will not help someone that never comes back to that piece of code..
I know but this query adds the new permission to some borrowers. Now that this permission in not new, I think it whould be dangerous to add it to borrowers. This was only a way to ease the set of the new permission. For libraries that have already used updatedatabase, they will easily see for who the permission is missing and set it manually. Rather less permissions than to much no ? ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16034|0 |1 is obsolete| | Attachment #16035|0 |1 is obsolete| | Attachment #18670|0 |1 is obsolete| | --- Comment #49 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19434&action=edit Bug 6898 - updatedatabase second query not executed Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19434|0 |1 is obsolete| | --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19541&action=edit [PASSED QA] Bug 6898 - updatedatabase second query not executed Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This will only fix the permissions for updates done after the patch has been applied. But I agree with Fridolyn, that we can not safely update permissions for existing installations. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #51 from Galen Charlton <gmcharlt@gmail.com> --- Pushed follow-up to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #52 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow up has been pushed to 3.12.x, will be in 3.12.3. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #53 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Followup pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org