http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Failed QA --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- 1) I think this patch introduces a change in much more places than expected: $ git grep patron-title.inc | wc -l 1491 I suggest that such a change should be optional, and could be done like this: - [%- borrower.firstname %] [% IF borrower.othernames %] ([% borrower.othernames %]) [% END %] [% borrower.surname %] + <span id="patron-title">[%- borrower.title %] </span>[% borrower.firstname %] [% IF borrower.othernames %] ([% borrower.othernames %]) [% END %] [% borrower.surname %] i.e. putting the title inside a span with an id, and change CSS to hide it by default. So you keep the enhancement you want, but people can opt-in instead of making it mandatory (e.g. #patron-title { display: none; } ) 2) Please make it check for borrower.title to avoid warnings? [%- IF borrower.title -%] etc -- You are receiving this mail because: You are watching all bug changes.