https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize (ashimema) from comment #7)
I decided we don't need to push for a unit test here.. none of the other fields are tested and it's a trivial patch.
That's good to know about the test. I was going to check through them but ran out of time. I'm a bit anxious about this one, but it does seem like a sensible change. When I was talking to the hardware vendor, I couldn't figure out why on earth we're not sending AP. It was very reasonable that they wanted AP. I wonder a bit if we'll see unexpected consequences as a result of this sensible change though. I suppose worst case it gets reverted, and best case it just works. I think I rather see it go in than get blocked, so thumbs up from me I think. -- You are receiving this mail because: You are watching all bug changes.