[Bug 39842] New: SIP current_location field is never sent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Bug ID: 39842 Summary: SIP current_location field is never sent Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org We have AP => FID_CURRENT_LOCATION and that points to current_location in SIP items, however, we never populate that field so it is never returned in SIP responses. Some SIP machines would like to be able to find hold items and list where they are waiting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 181969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181969&action=edit Bug 39842: Populate current location for SIP item with holdingbranch This patch simply adds the holdingbranch to the SIP item as current_location To test: 1 - Find an item and check it in at a different location than its homebranch 2 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR -m item_information --item 39999000004151 3 - Note no AP field is returned 4 - Apply patch, restart all 5 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR -m item_information --item 39999000004151 6 - You see the current holdingbranch in the AP field 7 - Return the item to its homebranch 8 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR -m item_information --item 39999000004151 9 - Confirm home and holding branches are the same now -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181969|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 181994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181994&action=edit Bug 39842: Populate current location for SIP item with holdingbranch This patch simply adds the holdingbranch to the SIP item as current_location To test: 1 - Find an item and check it in at a different location than its homebranch 2 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR -m item_information --item 39999000004151 3 - Note no AP field is returned 4 - Apply patch, restart all 5 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR -m item_information --item 39999000004151 6 - You see the current holdingbranch in the AP field 7 - Return the item to its homebranch 8 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR -m item_information --item 39999000004151 9 - Confirm home and holding branches are the same now Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- We bumped into this one the other day as well. The vendor of the SIP client machine was able to work around it, but I was thinking this might be a good idea... We'll need to check the unit tests for this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- I wonder a bit if this will break anything for existing machines... hopefully not. Sometimes I wish we had feature flags or transitional system preferences that we could temporarily use to turn off a new feature until a fix can be developed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Any chance of adding a unit test here Nick? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181994|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182078&action=edit Bug 39842: Populate current location for SIP item with holdingbranch This patch simply adds the holdingbranch to the SIP item as current_location To test: 1 - Find an item and check it in at a different location than its homebranch 2 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR -m item_information --item 39999000004151 3 - Note no AP field is returned 4 - Apply patch, restart all 5 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR -m item_information --item 39999000004151 6 - You see the current holdingbranch in the AP field 7 - Return the item to its homebranch 8 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR -m item_information --item 39999000004151 9 - Confirm home and holding branches are the same now Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I decided we don't need to push for a unit test here.. none of the other fields are tested and it's a trivial patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize (ashimema) from comment #7)
I decided we don't need to push for a unit test here.. none of the other fields are tested and it's a trivial patch.
That's good to know about the test. I was going to check through them but ran out of time. I'm a bit anxious about this one, but it does seem like a sensible change. When I was talking to the hardware vendor, I couldn't figure out why on earth we're not sending AP. It was very reasonable that they wanted AP. I wonder a bit if we'll see unexpected consequences as a result of this sensible change though. I suppose worst case it gets reverted, and best case it just works. I think I rather see it go in than get blocked, so thumbs up from me I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Decided to push, but adding Kyle to get another opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 --- Comment #11 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- This patch is missing unit tests and I'm concerned this current location will be incorrect during checkins that trigger a transfer to a different branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- (In reply to Kyle M Hall (khall) from comment #11)
This patch is missing unit tests and I'm concerned this current location will be incorrect during checkins that trigger a transfer to a different branch.
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Do you suggest a revert or could we make this configurable? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 --- Comment #14 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Kyle M Hall (khall) from comment #11)
This patch is missing unit tests and I'm concerned this current location will be incorrect during checkins that trigger a transfer to a different branch.
The field is only sent during item_information requests - so the information won't be changing during the request, so I don't understand the concern here. I agree we could expand tests to cover this on a new bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 --- Comment #15 from Kyle M Hall (khall) <kyle@bywatersolutions.com> ---
The field is only sent during item_information requests - so the information won't be changing during the request, so I don't understand the concern here.
Agreed. The field is used in the checkin *request*, not the response, so my concerns are invalid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall (khall) from comment #15)
The field is only sent during item_information requests - so the information won't be changing during the request, so I don't understand the concern here.
Agreed. The field is used in the checkin *request*, not the response, so my concerns are invalid.
Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 --- Comment #18 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #17)
Pushed to 24.11.x for 24.11.10
I wonder if we should've classified this one as an enhancement... (In reply to Kyle M Hall (khall) from comment #15)
The field is only sent during item_information requests - so the information won't be changing during the request, so I don't understand the concern here.
Agreed. The field is used in the checkin *request*, not the response, so my concerns are invalid.
Trying 'item_information' SEND: 1700120251007 023043AOCPL|AB39999000004151|ACkoha| READ: 1810020120251007 023043AB39999000004151|AJUn chien andalou =|AQCPL|APFFL|CRNFIC|BGCPL| Kiosks from FE Technologies use the item_information and look for AP to see if they need to do a branch transfer after a SIP checkin. Overall, I think it's a very good thing that we're adding it into the SIP item_information response, as it provides SIP clients with more accurate data... it is possible that it could change the behaviour of some existing SIP clients in an unexpected way / at an unexpected time. That's why we might not want to backport it. But it's probably low risk, and it could provide people on older versions of Koha with a better SIP service. Anyway, just my 2 cents. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 --- Comment #19 from David Cook <dcook@prosentient.com.au> --- On a related note, does anyone have a "term1" user on their KTD? I couldn't get the test plan to work. I had to use the "koha" user. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39842 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting Version(s)|25.05.00,24.11.10 |25.05.00 released in| | --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- OK thanks for the alert David I revert from 24.11.x (not yet released) for behavior stability in LTS -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org