https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180626|0 |1 is obsolete| | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181878&action=edit Bug 39389: Don't stringify the system preference value This bug is caused by the code that is intended to hide the export column when disabled failing because the value of exports_enabled is "0" and not 0 To test: 1 - Checkout an item to a patron 2 - Disable ExportCircHistory 3 - Load the patron's circulation table on the Check Out tab 4 - Notice no export column 5 - Click 'Export' above the table and you can export 6 - Go to the patron's circulation table on the Details tab 7 - The export column shows 8 - Try to export - JS error 9 - Apply patch 10 - Clear local storage in the browser 11 - Repeat 3-6 - no more export column and you can export 12 - Enable ExportCircHistory 13 - Confirm the circ table on both pages hsows the export column and can be exported (You may need to clear local storage again) Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Janne <janne.seppanen@lahti.fi> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.