https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40476 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #8)
Also if punctuation chars are the problem, we should only reject them (eg. "✔❤★" should be accepted, it's not).
Your example of ❤ for a branch code on previous bug reports did cross my mind when I was thinking about the regex for this, and it led me to expand the range of allowed values to all Unicode letters and numbers. I'm not sure that "✔❤★" should be accepted for an item type code though. We could add emojis to the regex, but I'm not sure there's much real world value there to be honest.
Maybe better to simply add a warning if punctuation characters are present instead of rejecting them? It's easy to implement and we don't have to deal with a db rev?
I'm not familiar enough with jQuery validator to know if that's an option within it, or if it would need to be a separate event handler. -- I'm not necessarily opposed to leaving this as In Discussion or closing it. I've already applied it locally and I don't mind carrying this as a local customization. I thought other people would find it useful, but that might not be the case. -- You are receiving this mail because: You are watching all bug changes.