https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40476 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40476 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40476 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Limit item type codes to |Limit new item type codes |letters and numbers |to letters and numbers -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40476 --- Comment #5 from Esther Melander <esther.melander@bywatersolutions.com> --- I ran a test with with an item type that had an underscore, E_Book, and the item type was retained and appeared to function. Any new item type went through validation and would not save until the punctuation was removed. Some additional testing could be done on this point. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40476 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |martin.renvoize@openfifth.c | |o.uk --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #6)

(In reply to Marcel de Rooy from comment #4)

...

What about existing item type codes? Or importing them?

They'll still be problems.

We could possibly try to add some more backend validation and throw errors for invalid item types, but I even that could be bypassed by people inserting directly into the database with migration scripts, so I'm not sure how effective that would be in the end either.

Fixing these problems is quite annoying as well, because you have to update the database and then reindex all affected records, which on a large database can be quite time intensive at the very least.

I don't have any good answers on this one I think. For now, I thought we could add the client-side validation to try steering things in a better direction. But I'm open to ideas.

I dont have a strong argument to block this patch. But just being a bit hesitant since it feels doing half the work needed. And we have so much of these things already in Koha. Asking hereby for feedback from others. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40476 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #8)

Also if punctuation chars are the problem, we should only reject them (eg. "✔❤★" should be accepted, it's not).

Your example of ❤ for a branch code on previous bug reports did cross my mind when I was thinking about the regex for this, and it led me to expand the range of allowed values to all Unicode letters and numbers. I'm not sure that "✔❤★" should be accepted for an item type code though. We could add emojis to the regex, but I'm not sure there's much real world value there to be honest.

Maybe better to simply add a warning if punctuation characters are present instead of rejecting them? It's easy to implement and we don't have to deal with a db rev?

I'm not familiar enough with jQuery validator to know if that's an option within it, or if it would need to be a separate event handler. -- I'm not necessarily opposed to leaving this as In Discussion or closing it. I've already applied it locally and I don't mind carrying this as a local customization. I thought other people would find it useful, but that might not be the case. -- You are receiving this mail because: You are watching all bug changes.