https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43333 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from David Nind <david@davidnind.com> --- I've failed QA because: 1. The vendor name is an H2 instead of an H1 - this is an accessibility issue (headings should follow a logical structure and be semantically correct, for example: H2 headings should follow H1 headings, you shouldn't miss headings) In addition: 1. This is possibly a wider bug with Vue-based modules, but the browser page title, breadcrumb, and page title should all be consistent. A lot of work went into previous releases by Owen to make this consistent. Maybe this has been discussed on other bugs/elsewhere? 2. "Edit" changed to "Modify": this seems "consistent" with other pages - the label is "Edit", but on the page itself it is "Modify...". If there is not a coding guideline/user interface guideline, I think we should have one. (I personally think it is weird to have the action/label as "Edit", but then have the page title/form title as "Modify ...."). This is a separate issue for all of Koha though. Testing notes (using KTD): 1. Before the patch: - In KTD, there is one vendor already set up, "My Vendor" - Viewing a vendor: . Vendor #1 (heading is an H2, doesn't show vendor name) . Breadcrumb: Acquisitions > Vendors > My Vendor . Page title (browser title): Vendors > Koha - Editing a vendor: . Edit vendor #1 (heading is an H2, doesn't show vendor name) . Breadcrumb: Acquisitions > Vendors > My Vendor > Modify vendor . Page title (browser title): Vendors > Koha 2. After the patch: - Rebuild everything: yarn build - Restart everything: restart_all - Viewing a vendor (Vendor #1 - My Vendor): . My Vendor (heading is an H2) . Breadcrumb: Acquisitions > Vendors > My Vendor . Page title (browser title): Vendors > Koha - Editing a vendor (Vendor #1 - My Vendor): . Modify My Vendor (heading is an H2) . Breadcrumb: Acquisitions > Vendors > My Vendor > Modify My Vendor . Page title (browser title): Vendors > Koha -- You are receiving this mail because: You are watching all bug changes.