https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- This works really nicely for the most part, and is a great UX improvement! However, there's a behavior inconsistency with the two checkboxes. The second patch contains the following lines for #categoryChangeUpdateExpiry: + if (UpdateDateExpiryOnCategoryChange == "softyes") { + $("#categoryChangeUpdateExpiry").prop("checked", true); + } else if (UpdateDateExpiryOnCategoryChange == "softno") { + $("#categoryChangeUpdateExpiry").prop("checked", false); + } There's no equivalent code for #categoryChangeUpdateMessaging, which causes the checkboxes to behave differently if a staff member changes the category twice while editing a patron account (which is a bit of an edge case, but it does happen when staff misclick and select the wrong category the first time). For example: 1. Set both sysprefs to "Ask before updating, default to yes" 2. Edit a patron account 3. Change the selection of the category code drop-down --> The modal appears as expected, with both checkboxes checked by default 4. Uncheck both checkboxes 5. Confirm or dismiss the modal (it doesn't matter which) 6. Change the selection of the category code drop-down again --> The modal reappears, but this time "Reset messaging preferences" is unchecked (the state you set it to before), but "Reset expiration date" has gone back to its default state of checked I could see an argument for either behavior (and didn't want to unilaterally choose one in a QA follow-up), but either way, the two checkboxes should be consistent. ---- A few other pieces of feedback that would be nice to correct: - The syspref name and description refer to "date expiry", but everywhere else in the staff interface that I can find says "expiry date" - As of bug 41834, the atomic update only needs to include name and default values for sysprefs - The code added to messaging-preference-form.js, lines 25-31 and 39-70, is pretty much an exact duplicate of existing code. Can this be factored out to DRY out the code? (either on this bug or as a follow-up bug) -- You are receiving this mail because: You are watching all bug changes.