[Bug 42112] New: Add option for prompting for renewal, always renewing, or never renewing borrower when changing category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Bug ID: 42112 Summary: Add option for prompting for renewal, always renewing, or never renewing borrower when changing category Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lisette@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Bug 32581 - Update dateexpiry on categorycode change introduced extra clicks for libraries that change category codes frequently for administrative reasons. There should be an option to not offer the renewal. Ideally the option could be: Always renew/Ask for Renewal/Never renew I'm not sure if it makes more sense to set as a sys pref or as a "when changing to or away from this category" setting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32581 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32581 [Bug 32581] Update dateexpiry on categorycode change -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com --- Comment #1 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- A system preference is definitely preferred here, at least as an option. It's another pop up that staff need to deal with (on top of the messaging preferences popup). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org --- Comment #2 from Juliet Heltibridle <jheltibridle@rcplib.org> --- As with many new features that could be a system preference, I'd prefer that this could be set per branch. I think it is going to help our workflow a lot to have Koha help staff get the correct expiration date for a category set when they change the category, but other libraries in our system may not want this extra click. For me, having it set per branch or as Lisette suggests, per patron category would be my preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org --- Comment #3 from mteal@greenvillelibrary.org --- We would want to make this popup optional. A system preference for options of 1) Always renew, don't ask, 2) Ask if to renew, or 3) Never renew, don't ask. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #4 from mteal@greenvillelibrary.org --- (In reply to mteal from comment #3)
We would want to make this popup optional. A system preference for options of 1) Always renew, don't ask, 2) Ask if to renew, or 3) Never renew, don't ask.
Ideally, a additional patron category preference would be great (when changing to this category). That way we could set the system preference the way we want it for 90% of our categories, and just override that default through a patron category preference. We only have a couple of categories where this would be helpful for us. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Benjamin Daeuber from comment #1)
A system preference is definitely preferred here, at least as an option. It's another pop up that staff need to deal with (on top of the messaging preferences popup).
That is what I really don't like here. Now we have 2 pop-ups, one for date expiry that is a modal and one for message prefs that is a JS alert. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 [Bug 42169] Unify patron category change popups -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #5)
(In reply to Benjamin Daeuber from comment #1)
A system preference is definitely preferred here, at least as an option. It's another pop up that staff need to deal with (on top of the messaging preferences popup).
That is what I really don't like here. Now we have 2 pop-ups, one for date expiry that is a modal and one for message prefs that is a JS alert.
I wrote a patch to unify patron messaging prefs and expiry date into a single modal: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 196349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196349&action=edit Bug 42112: Add new system preferences Patch from commit 5b77d90 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 196350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196350&action=edit Bug 42112: Implement system preferences with modal popups Patch from commit e965030 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #9 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- (In reply to Lucas Gass (lukeg) from comment #6)
I wrote a patch to unify patron messaging prefs and expiry date into a single modal:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169
I tested this and it works (excepting the issue already raised on that bug), but I think my staff would still prefer the option to not deal with a pop-up at all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Benjamin Daeuber from comment #9)
(In reply to Lucas Gass (lukeg) from comment #6)
I wrote a patch to unify patron messaging prefs and expiry date into a single modal:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169
I tested this and it works (excepting the issue already raised on that bug), but I think my staff would still prefer the option to not deal with a pop-up at all.
I have added patches here that will give the option, both for date expiry and messaging prefs controlled via sys pref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196350|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 196363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196363&action=edit Bug 42112: Implement system preferences with modal popups To test: 1. APPLY PATCH, updatedatabase, restart_all 2. Find 2 new system preferences UpdateDateExpiryOnCategoryChange and UpdateMessagingPrefsOnCategoryChange 3. Each was the same options: -Never update -Always ask, default to no -Always ask, default to yes -Always update without asking 4. Go to Administration > Patron categories 5. Edit or create some categories with different Enrollment periods and messaaging preferences 6. Try each of the options for BOTH system preferences, making sure they work as described. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #12 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Working (I think I tried most combos of syspref and checkbox and manual checkbox adjustment), but it's pretty easy to click out of by accident. I actually accidentally did it twice myself. I guess I'd like to see someone who would have it one something other than "always off" test it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | CC| |david@davidnind.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 197752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197752&action=edit Bug 42112: Implement system preferences with modal popups To test: 1. APPLY PATCH, updatedatabase, restart_all 2. Find 2 new system preferences UpdateDateExpiryOnCategoryChange and UpdateMessagingPrefsOnCategoryChange 3. Each was the same options: -Never update -Always ask, default to no -Always ask, default to yes -Always update without asking 4. Go to Administration > Patron categories 5. Edit or create some categories with different Enrollment periods and messaaging preferences 6. Try each of the options for BOTH system preferences, making sure they work as described. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds two new system release notes| |preferences that let you | |control what happens when | |changing a patron's | |category: | |- Updating the enrollment | |period expiry date: | | | |UpdateDateExpiryOnCategoryC | |hange | |- Updating the messaging | |preferences: | | | |UpdateMessagingPrefsOnCateg | |oryChange | | | |When changing a patron's | |category, a pop-up window | |with pre-populated | |checkboxes is shown and | |lets you select what to do | |(depending on the new | |system preference | |settings). | | | |The options for both the | |new system preferences are: | |- Never update | |- Ask before updating, | |default to no | |- Ask before updating, | |default to yes (note: this | |is the default) | |- Always update without | |asking --- Comment #14 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Options for both new system preferences are: - Never update - Ask before updating, default to no - Ask before updating, default to yes (note: is the default) - Always update without asking 2. Setup to check if works as expected: - Kid patron category: . Messaging preferences: Item checkout - select Email . Enrollment period: change to 72 months (6 years) - Patron patron category: . Messaging preferences: Hold filled - select Email . Enrollment period: change to 120 months (10 years) 3. Change patron category from Kid to Patron and back again as you work through the option combinations. I used Lisa Charles. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196349|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197752|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 197753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197753&action=edit Bug 42112: Add new system preferences Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 197754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197754&action=edit Bug 42112: Implement system preferences with modal popups To test: 1. APPLY PATCH, updatedatabase, restart_all 2. Find 2 new system preferences UpdateDateExpiryOnCategoryChange and UpdateMessagingPrefsOnCategoryChange 3. Each was the same options: -Never update -Always ask, default to no -Always ask, default to yes -Always update without asking 4. Go to Administration > Patron categories 5. Edit or create some categories with different Enrollment periods and messaaging preferences 6. Try each of the options for BOTH system preferences, making sure they work as described. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add option for prompting |Add option when changing a |for renewal, always |patron's category: allow |renewing, or never renewing |choosing what to do for the |borrower when changing |expiry date and messaging |category |preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34460 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- This works really nicely for the most part, and is a great UX improvement! However, there's a behavior inconsistency with the two checkboxes. The second patch contains the following lines for #categoryChangeUpdateExpiry: + if (UpdateDateExpiryOnCategoryChange == "softyes") { + $("#categoryChangeUpdateExpiry").prop("checked", true); + } else if (UpdateDateExpiryOnCategoryChange == "softno") { + $("#categoryChangeUpdateExpiry").prop("checked", false); + } There's no equivalent code for #categoryChangeUpdateMessaging, which causes the checkboxes to behave differently if a staff member changes the category twice while editing a patron account (which is a bit of an edge case, but it does happen when staff misclick and select the wrong category the first time). For example: 1. Set both sysprefs to "Ask before updating, default to yes" 2. Edit a patron account 3. Change the selection of the category code drop-down --> The modal appears as expected, with both checkboxes checked by default 4. Uncheck both checkboxes 5. Confirm or dismiss the modal (it doesn't matter which) 6. Change the selection of the category code drop-down again --> The modal reappears, but this time "Reset messaging preferences" is unchecked (the state you set it to before), but "Reset expiration date" has gone back to its default state of checked I could see an argument for either behavior (and didn't want to unilaterally choose one in a QA follow-up), but either way, the two checkboxes should be consistent. ---- A few other pieces of feedback that would be nice to correct: - The syspref name and description refer to "date expiry", but everywhere else in the staff interface that I can find says "expiry date" - As of bug 41834, the atomic update only needs to include name and default values for sysprefs - The code added to messaging-preference-form.js, lines 25-31 and 39-70, is pretty much an exact duplicate of existing code. Can this be factored out to DRY out the code? (either on this bug or as a follow-up bug) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199993&action=edit Bug 42112: (follow-up) Reset modal popups to system preference defaults Patch from commit fb56b68 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199994&action=edit Bug 42112: (follow-up) Fix atomicupdate and rename system prefeerence Patch from commit b9679cd -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42773 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42773 [Bug 42773] Refactor messaging-preference-form.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
- The code added to messaging-preference-form.js, lines 25-31 and 39-70, is pretty much an exact duplicate of existing code. Can this be factored out to DRY out the code? (either on this bug or as a follow-up bug)
For this I have filed a follow-up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197753|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197754|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199993|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199994|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #21 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 201078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201078&action=edit Bug 42112: Add new system preferences Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #22 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 201079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201079&action=edit Bug 42112: Implement system preferences with modal popups To test: 1. APPLY PATCH, updatedatabase, restart_all 2. Find 2 new system preferences UpdateDateExpiryOnCategoryChange and UpdateMessagingPrefsOnCategoryChange 3. Each was the same options: -Never update -Always ask, default to no -Always ask, default to yes -Always update without asking 4. Go to Administration > Patron categories 5. Edit or create some categories with different Enrollment periods and messaaging preferences 6. Try each of the options for BOTH system preferences, making sure they work as described. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #23 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 201080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201080&action=edit Bug 42112: (follow-up) Reset modal popups to system preference defaults Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #24 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 201081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201081&action=edit Bug 42112: (follow-up) Fix atomicupdate and rename system prefeerence Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #25 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Thanks, Lucas! Everything looks great! Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201078|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201079|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201081|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #26 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 203637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203637&action=edit Bug 42112: Add option when changing a patron's category: allow choosing what to do for the expiry date and messaging preferences To test: 1. APPLY PATCH, updatedatabase, restart_all 2. Find 2 new system preferences UpdateDateExpiryOnCategoryChange and UpdateMessagingPrefsOnCategoryChange 3. Each was the same options: -Never update -Always ask, default to no -Always ask, default to yes -Always update without asking 4. Go to Administration > Patron categories 5. Edit or create some categories with different Enrollment periods and messaaging preferences 6. Try each of the options for BOTH system preferences, making sure they work as described. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #27 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- rebased for current main, also squashed the patchset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 --- Comment #28 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 26.05.x backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org