https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147051|0 |1 is obsolete| | Attachment #147052|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147053&action=edit Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. -- You are receiving this mail because: You are watching all bug changes.