[Bug 32991] New: Improve our Dialog component and remove routes for deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Bug ID: 32991 Summary: Improve our Dialog component and remove routes for deletion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com Agustin suggested some nice improvements on bug 32607 that would be great to have in a separate bug. We should embed the changes here, and eventually remove the specific routes (and components) we have to delete object. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io, | |tomascohen@gmail.com Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32607 Depends on| |32925 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32925 [Bug 32925] Display loading info when a form is submitted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146828&action=edit Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146829&action=edit Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patches applied on top of the tree at https://gitlab.com/joubu/Koha/-/commits/bug_32991 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32983 [Bug 32983] Use REST API route to retrieve authorised values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32925 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32925 [Bug 32925] Display loading info when a form is submitted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146828|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147051&action=edit Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146829|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147052&action=edit Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147051|0 |1 is obsolete| | Attachment #147052|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147053&action=edit Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147054&action=edit Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147053|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147082&action=edit Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147054|0 |1 is obsolete| | --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147083&action=edit Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #6)
Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals."
This appears to just need a new variable name - Vue won't accept variables prefixed with "_" in root components so "_is_loading" will need renaming. We can't just remove the "_" as there is a getter called "is_loading" and this will conflict. Maybe "content_is_loading"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Matt Blenkinsop from comment #10)
(In reply to Jonathan Druart from comment #6)
Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals."
This appears to just need a new variable name - Vue won't accept variables prefixed with "_" in root components so "_is_loading" will need renaming. We can't just remove the "_" as there is a getter called "is_loading" and this will conflict. Maybe "content_is_loading"?
Yes, the thing is that Agustin decided to prefix the store variables with '_', to get a good getter method name. We should not only rename is_loading, but others as well (for consistency), and so we need to provide a clean solution for all of them. But first I wanted to make sure the trick in Main was necessary and there was no better alternative. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32807 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 [Bug 32807] No need to fetch all if we need to know if one exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147082|0 |1 is obsolete| | Attachment #147083|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147281&action=edit Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147282&action=edit Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Rebased on top of bug 32983's last changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147291&action=edit Bug 32991: (QA follow-up) Add margin to buttons; Fix duplicate HTML element ID -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147291|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147305&action=edit Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Putting this back to NSO, it's causing Cypress tests to fail. I'm working on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Also need to: - Remove no longer needed Vue files - Abstract the dialog button labels to be set by whatever component that invokes it, i.e. "Yes, delete" instead of the current hard-coded "Accept", etc. - Fix the "is_loading" console error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #19 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147350&action=edit Bug 32991: Fix agreements tests with new dialog instead of confirm delete page. Squash this later with other tests updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #20 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147383&action=edit Bug 32991: accept is a callback, rename accept to accept_callback -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147384&action=edit Bug 32991: Allow for a confirmation title and a confirmation message in the dialog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147385&action=edit Bug 32991: Add delete dialog to licenses list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147384|0 |1 is obsolete| | --- Comment #23 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147387&action=edit Bug 32991: Allow for a confirmation title and a confirmation message in the dialog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147385|0 |1 is obsolete| | --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147388&action=edit Bug 32991: Add delete dialog to licenses list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147387|0 |1 is obsolete| | --- Comment #25 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147389&action=edit Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in the dialog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147388|0 |1 is obsolete| | --- Comment #26 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147390&action=edit Bug 32991: Add delete dialog to licenses list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147389|0 |1 is obsolete| | --- Comment #27 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147391&action=edit Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in the dialog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147391|0 |1 is obsolete| | --- Comment #28 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147392&action=edit Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in the dialog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147390|0 |1 is obsolete| | --- Comment #29 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147393&action=edit Bug 32991: Add delete dialog to licenses list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #30 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147394&action=edit Bug 32991: Add delete dialog to local packages list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #31 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147429&action=edit Bug 32991: Add delete dialog to local titles list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147429|0 |1 is obsolete| | --- Comment #32 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147439&action=edit Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147394|0 |1 is obsolete| | --- Comment #33 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147445&action=edit Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147393|0 |1 is obsolete| | --- Comment #34 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147447&action=edit Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147392|0 |1 is obsolete| | --- Comment #35 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147448&action=edit Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #36 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147449&action=edit Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147383|0 |1 is obsolete| | --- Comment #37 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147450&action=edit Bug 32991: accept is a callback, rename accept to accept_callback -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147448|0 |1 is obsolete| | --- Comment #38 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147451&action=edit Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147439|0 |1 is obsolete| | --- Comment #39 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147452&action=edit Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147445|0 |1 is obsolete| | --- Comment #40 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147453&action=edit Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147447|0 |1 is obsolete| | --- Comment #41 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147454&action=edit Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147449|0 |1 is obsolete| | --- Comment #42 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147455&action=edit Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147350|0 |1 is obsolete| | --- Comment #43 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147456&action=edit Bug 32991: Fix agreements tests with new dialog instead of confirm delete page. Squash this later with other tests updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147456|0 |1 is obsolete| | --- Comment #44 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147461&action=edit Bug 32991: Fix cypress tests. Added new test for when deleting from show view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147483&action=edit Bug 32991: Flag the deletion messages as displayed already Or they will be displayed again on the next view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147485&action=edit Bug 32991: Don't remove all messages when confirm box is closed If we cancel the confirmation box we should not clear all the messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147485|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147486&action=edit Bug 32991: Don't remove all messages when confirm box is closed If we cancel the confirmation box we should not clear all the messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #48 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147487&action=edit Bug 32991: Add cypress tests for the dialog box -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147281|0 |1 is obsolete| | Attachment #147282|0 |1 is obsolete| | Attachment #147305|0 |1 is obsolete| | Attachment #147450|0 |1 is obsolete| | Attachment #147451|0 |1 is obsolete| | Attachment #147452|0 |1 is obsolete| | Attachment #147453|0 |1 is obsolete| | Attachment #147454|0 |1 is obsolete| | Attachment #147455|0 |1 is obsolete| | Attachment #147461|0 |1 is obsolete| | Attachment #147483|0 |1 is obsolete| | Attachment #147486|0 |1 is obsolete| | Attachment #147487|0 |1 is obsolete| | --- Comment #49 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147542&action=edit Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #50 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147543&action=edit Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #51 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147544&action=edit Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #52 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147545&action=edit Bug 32991: accept is a callback, rename accept to accept_callback Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #53 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147546&action=edit Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147547&action=edit Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #55 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147548&action=edit Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #56 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147549&action=edit Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #57 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147550&action=edit Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #58 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147551&action=edit Bug 32991: Fix cypress tests. Added new test for when deleting from show view. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #59 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147552&action=edit Bug 32991: Flag the deletion messages as displayed already Or they will be displayed again on the next view Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #60 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147553&action=edit Bug 32991: Don't remove all messages when confirm box is closed If we cancel the confirmation box we should not clear all the messages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #61 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147554&action=edit Bug 32991: Add cypress tests for the dialog box Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #62 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Added my stamp to Pedro's patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #63 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147569&action=edit Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #64 from Agustín Moyano <agustinmoyano@theke.io> --- Hi Jonathan and Pedro! Excellent job on this Dialog component. I added a little fix on 'Main.vue' to not depend on the '_is_loading' flag I believe we can squash these commits now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 [Bug 33066] We need a KohaTable Vue component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147569|0 |1 is obsolete| | --- Comment #65 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147573&action=edit Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #66 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147584&action=edit Bug 32991: Don't display breadcrumb if pref is off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #67 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Thanks, Agustín! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147542|0 |1 is obsolete| | Attachment #147543|0 |1 is obsolete| | Attachment #147544|0 |1 is obsolete| | Attachment #147545|0 |1 is obsolete| | Attachment #147546|0 |1 is obsolete| | Attachment #147547|0 |1 is obsolete| | Attachment #147548|0 |1 is obsolete| | Attachment #147549|0 |1 is obsolete| | Attachment #147550|0 |1 is obsolete| | Attachment #147551|0 |1 is obsolete| | Attachment #147552|0 |1 is obsolete| | Attachment #147553|0 |1 is obsolete| | Attachment #147554|0 |1 is obsolete| | Attachment #147573|0 |1 is obsolete| | Attachment #147584|0 |1 is obsolete| | --- Comment #68 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147588&action=edit Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #69 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147589&action=edit Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #70 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147590&action=edit Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #71 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147591&action=edit Bug 32991: accept is a callback, rename accept to accept_callback Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #72 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147592&action=edit Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #73 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147593&action=edit Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #74 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147594&action=edit Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #75 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147595&action=edit Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #76 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147596&action=edit Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #77 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147597&action=edit Bug 32991: Fix cypress tests. Added new test for when deleting from show view. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #78 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147598&action=edit Bug 32991: Flag the deletion messages as displayed already Or they will be displayed again on the next view Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #79 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147599&action=edit Bug 32991: Don't remove all messages when confirm box is closed If we cancel the confirmation box we should not clear all the messages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #80 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147600&action=edit Bug 32991: Add cypress tests for the dialog box Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #81 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147601&action=edit Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #82 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147602&action=edit Bug 32991: Don't display breadcrumb if pref is off Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147601|0 |1 is obsolete| | Attachment #147602|0 |1 is obsolete| | --- Comment #83 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147603&action=edit Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #84 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147604&action=edit Bug 32991: Don't display breadcrumb if pref is off Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #85 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Rebased on top of 32983 to integrate the prettier change. Added Agustín and Pedro signed-off-by lines and considering this set PQA. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #86 from Agustín Moyano <agustinmoyano@theke.io> --- \o/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147588|0 |1 is obsolete| | Attachment #147589|0 |1 is obsolete| | Attachment #147590|0 |1 is obsolete| | Attachment #147591|0 |1 is obsolete| | Attachment #147592|0 |1 is obsolete| | Attachment #147593|0 |1 is obsolete| | Attachment #147594|0 |1 is obsolete| | Attachment #147595|0 |1 is obsolete| | Attachment #147596|0 |1 is obsolete| | Attachment #147597|0 |1 is obsolete| | Attachment #147598|0 |1 is obsolete| | Attachment #147599|0 |1 is obsolete| | Attachment #147600|0 |1 is obsolete| | Attachment #147603|0 |1 is obsolete| | Attachment #147604|0 |1 is obsolete| | --- Comment #87 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147937&action=edit Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #88 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147938&action=edit Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #89 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147939&action=edit Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #90 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147940&action=edit Bug 32991: accept is a callback, rename accept to accept_callback Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #91 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147941&action=edit Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #92 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147942&action=edit Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #93 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147943&action=edit Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #94 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147944&action=edit Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #95 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147945&action=edit Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #96 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147946&action=edit Bug 32991: Fix cypress tests. Added new test for when deleting from show view. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #97 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147947&action=edit Bug 32991: Flag the deletion messages as displayed already Or they will be displayed again on the next view Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #98 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147948&action=edit Bug 32991: Don't remove all messages when confirm box is closed If we cancel the confirmation box we should not clear all the messages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #99 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147949&action=edit Bug 32991: Add cypress tests for the dialog box Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #100 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147950&action=edit Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #101 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147951&action=edit Bug 32991: Don't display breadcrumb if pref is off Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #102 from Agustín Moyano <agustinmoyano@theke.io> --- Rebased patches that didn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 [Bug 33169] Improve vue breadcrubms and left-hand menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #103 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 --- Comment #104 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|ERM |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #105 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33648 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33648 [Bug 33648] Errors when enabling ERM in 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org