https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #9)
(In reply to Jonathan Druart from comment #8)
I need a confirmation here.
The test plan says "Set CheckPrevCheckout to Do, or Do, with confirmation", but it's "unless overriden, do". That means we should check the patron category and patron's settings as well.
Finally it sounds like this flag is set when the error/warning must be displayed, and maybe the following code would be enough:
} elsif ($confirmation eq 'PREVISSUE') { $self->screen_msg("This item was previously checked out by you"); last; }
Could someone confirm or tell me what I am missing?
There is no setting on patron category here - so this is alright. The pref has 4 values that seem a little confusing.
No it's not confusing, it's a great way to behave (inheritance). The patron's category can set this value is pref is set to relevant value (softyes, softno). I still think the tests are not necessary, waiting for an answer from patch's author or testers. -- You are receiving this mail because: You are watching all bug changes.