[Bug 19457] New: If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Bug ID: 19457 Summary: If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.field@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com If a library uses the system preference CheckPrevCheckout (Check for a previous issue) then, at the staff client, the issue is blocked with a dialogue asking if the checkout should be allowed or not, this is correct. However, for the sipserver, if CheckPrevCheckout is set to "Do" then the checkout is blocked with a generic "1" code and the checkout is refused by the self check. There is an argument that this is correct but, it is more likely that libraries would want to allow the checkout in this scenario as there is no explanation to the block and, most likely, it would be a genuine transaction. The sipserver needs an exception to handle this scenario. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #1 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 72187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72187&action=edit Bug 19457: If CheckPrevCheckout is set to Do, then checkouts are blocked at the SIPServer To test: Set CheckPrevCheckout to Do, or Do, with confirmation Verify the SIP server is blocking checkouts with this setting set Apply this patch Note that the checkout is now allowed, with a screen message telling the borrower they've issued the item before.y -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72187|0 |1 is obsolete| | --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 72216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72216&action=edit Signed off amended patch Signed off patch - works as advertised Fixed a typo there was an extra ) after the screen message indented the conditional to match preceding and break on the conditions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |liz@catalyst.net.nz |ity.org | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is this specific to 16.11? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #3)
Is this specific to 16.11?
No I think that is 16.11 and greater -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Colin, changing to master (bugs get backported from new to old) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72216|0 |1 is obsolete| | --- Comment #6 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 72771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72771&action=edit revision to signed off patch Amended the yes value to hardyes - this reflects the values of the syspref as in releases from 16.11 to current. 'yes' was the value in the test db I was using (and I assume Liz's) probably from an earlier release of the patch that added the syspref. - Tested against production as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72771|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 73858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73858&action=edit Bug 19457: If CheckPrevCheckout is set to Do, then checkouts are blocked at the SIPServer To test: Set CheckPrevCheckout to Do, or Do, with confirmation Verify the SIP server is blocking checkouts with this setting set Apply this patch Note that the checkout is now allowed, with a screen message telling the borrower they've issued the item before.y Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I need a confirmation here. The test plan says "Set CheckPrevCheckout to Do, or Do, with confirmation", but it's "unless overriden, do". That means we should check the patron category and patron's settings as well. Finally it sounds like this flag is set when the error/warning must be displayed, and maybe the following code would be enough: } elsif ($confirmation eq 'PREVISSUE') { $self->screen_msg("This item was previously checked out by you"); last; } Could someone confirm or tell me what I am missing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Depends on| |6906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 [Bug 6906] Show 'Borrower has previously issued $ITEM' alert on checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #8)
I need a confirmation here.
The test plan says "Set CheckPrevCheckout to Do, or Do, with confirmation", but it's "unless overriden, do". That means we should check the patron category and patron's settings as well.
Finally it sounds like this flag is set when the error/warning must be displayed, and maybe the following code would be enough:
} elsif ($confirmation eq 'PREVISSUE') { $self->screen_msg("This item was previously checked out by you"); last; }
Could someone confirm or tell me what I am missing?
There is no setting on patron category here - so this is alright. The pref has 4 values that seem a little confusing. https://bywatersolutions.com/2017/10/09/koha-tutorial-check-previous-checkou... I feel the patch is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20569 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #9)
(In reply to Jonathan Druart from comment #8)
I need a confirmation here.
The test plan says "Set CheckPrevCheckout to Do, or Do, with confirmation", but it's "unless overriden, do". That means we should check the patron category and patron's settings as well.
Finally it sounds like this flag is set when the error/warning must be displayed, and maybe the following code would be enough:
} elsif ($confirmation eq 'PREVISSUE') { $self->screen_msg("This item was previously checked out by you"); last; }
Could someone confirm or tell me what I am missing?
There is no setting on patron category here - so this is alright. The pref has 4 values that seem a little confusing.
No it's not confusing, it's a great way to behave (inheritance). The patron's category can set this value is pref is set to relevant value (softyes, softno). I still think the tests are not necessary, waiting for an answer from patch's author or testers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You are right, the setting on category only appears when you set a 'do' setting. Which is a little confusing. :( The important bis is that it should not block the circulation when set to softyes/hardyes. So apart from the message, we need to do something about the flag that blocks? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #12 from Magnus Enger <magnus@libriotech.no> --- (In reply to Jonathan Druart from comment #10)
I still think the tests are not necessary, waiting for an answer from patch's author or testers.
Consider this a friendly "ping". :-) Would be nice to have a fix for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #13 from Liz Rea <liz@catalyst.net.nz> --- The use case this patch was originally developed for was display a message if the item was previously issued, if the setting was either hard or soft yes. If you tell me what you're requiring, I'll be happy to fix it in whatever way you want. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #14 from Liz Rea <liz@catalyst.net.nz> --- They didn't care about blocking from the self check, at all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Liz, you check the preference only, but this can be overwritten for each patron category. I missed it at first too - you need to switch the pref to do. Also take a look at comment#8. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com --- Comment #16 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- (In reply to Katrin Fischer from comment #15)
Hi Liz, you check the preference only, but this can be overwritten for each patron category.
I think that the possible override is already taken into account here: C4/SIP/ILS/Transaction/Checkout.pm "do_checkout" calls "_can_we_issue" which calls "CanBookBeIssued" which calls "wants_check_for_previous_checkout" which checks for sypref, patron, and patron category. No need to re-check, right? (In reply to Jonathan Druart from comment #8)
Finally it sounds like this flag is set when the error/warning must be displayed, and maybe the following code would be enough:
} elsif ($confirmation eq 'PREVISSUE') { $self->screen_msg("This item was previously checked out by you"); last; }
I guess you're right, PREVISSUE is set after the syspref, patron and patron category were already checked by wants_check_for_previous_checkout in CanBookBeIssued, so no need to check again here. Imho, with Jonathan's modification, this patch is ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73858|0 |1 is obsolete| | --- Comment #17 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 78567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78567&action=edit Bug 19457: If CheckPrevCheckout is set to Do, then checkouts are blocked at the SIPServer To test: Set CheckPrevCheckout to Do, or Do, with confirmation Verify the SIP server is blocking checkouts with this setting set Apply this patch Note that the checkout is now allowed, with a screen message telling the borrower they've issued the item before.y Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #18 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Updated with Jonathan's modification. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78567|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78597&action=edit Bug 19457: Handle 'PREVISSUE' return by CanBookBeIssued from SIP (CheckPrevCheckout) If CheckPrevCheckout is set to Do, then checkouts are blocked at the SIPServer To test: - Do not apply this patch - Set CheckPrevCheckout to "Do", or "Unless overridden, do" Verify the SIP server is blocking checkouts with this setting set - Apply this patch - Note that the checkout is now allowed, with a screen message telling the borrower they've issued the item before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|liz@catalyst.net.nz |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78597|0 |1 is obsolete| | --- Comment #20 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89674&action=edit Bug 19457: Handle 'PREVISSUE' return by CanBookBeIssued from SIP (CheckPrevCheckout) If CheckPrevCheckout is set to Do, then checkouts are blocked at the SIPServer To test: - Do not apply this patch - Set CheckPrevCheckout to "Do", or "Unless overridden, do" Verify the SIP server is blocking checkouts with this setting set - Apply this patch - Note that the checkout is now allowed, with a screen message telling the borrower they've issued the item before. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> ---
- Note that the checkout is now allowed, with a screen message telling the borrower they've issued the item before.
Not the item, but the biblio ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89674|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 90216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90216&action=edit Bug 19457: Handle 'PREVISSUE' return by CanBookBeIssued from SIP (CheckPrevCheckout) If CheckPrevCheckout is set to Do, then checkouts are blocked at the SIPServer To test: - Do not apply this patch - Set CheckPrevCheckout to "Do", or "Unless overridden, do" Verify the SIP server is blocking checkouts with this setting set - Apply this patch - Note that the checkout is now allowed, with a screen message telling the borrower they've issued the item before. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #25 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #26 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #27 from David Cook <dcook@prosentient.com.au> --- How is this system preference being checked? I don't see any code that directly references "CheckPrevCheckout"? I just see templates. I must be missing something painfully obvious, but I don't see it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #28 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- See comment #16, CheckPrevCheckout is checked by wants_check_for_previous_checkout in Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #29 from David Cook <dcook@prosentient.com.au> --- (In reply to Matthias Meusburger from comment #28)
See comment #16, CheckPrevCheckout is checked by wants_check_for_previous_checkout in Koha/Patron.pm
Thanks, Matt. The reason I didn't see it before was that it checks "checkPrevCheckout" rather than "CheckPrevCheckout". My grep search was case sensitive and I totally missed it heh. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #30 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Hello, I have just dicovered this BZ and I'm really surprised and not agree this this choice. In our library, we want to prevent users who are using the selfcheckout system to checkout an item they have just check-in. They didn't really matter the warning and they can keep a book for all the time. For some title, there's a real pressure becaus they are recommanded by the teachers and we can't have one for all the students. We should have the choice to prevent or warn the check out at the selfchekout sytem and it's not the cas here if I have well understood. Sonia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So I guess we need a pref to control that. Sonia, can you open a new bug report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26591 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 --- Comment #32 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Done : https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26591 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26591 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 [Bug 26591] Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org