https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 197254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197254&action=edit Bug 40449: Add NoWarnings to xt/author/valid-templates.t Several templates generates warnings: xt/author/valid-templates.t .. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-article-requests.inc line 82. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 192. Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt line 461. Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt line 461. Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt line 1649. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt line 334. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt line 1154. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt line 1159. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt line 1162. Argument "" isn't numeric in numeric gt (>) at koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 192. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 283. Argument "" isn't numeric in numeric gt (>) at koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt line 75. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt line 97. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 85. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 85. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 86. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 86. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 87. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 214. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 385. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/user-star-ratings.inc line 17. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt line 76. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 415. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 420. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 423. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt line 355. This happens because we do not sent the variables from the tests (what we don't want to do). This patch is suggesting to remove those warnings by adding a test on the variables than are compared with >, - or * It makes the code is little less readable but IMO it's worth it. Test plan: Code review the changes And confirm that `prove xt/author/valid-templates.t` is now green with Test::NoWarnings Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.