https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43130 --- Comment #62 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Hi! (In reply to Paul Derscheid from comment #58)
Thanks Tomás! A few things before passing QA:
1. The [DO NOT PUSH] schema patch (attachment 200559 [details] [review]) is empty. The schema changes ended up in "Add materialized description columns". Also, the patron/pickup_library belongs_to aliases are below the md5 line, so they need to move to a regular patch ("Add holds queue REST API endpoint" already claims them). 2. The rename follow-up also drops !is_superlibrarian from the HidePatronName check. The change looks right, but it should be squashed into the endpoint patch? 3. No test coverage for HidePatronName in t/db_dependent/api/v1/holds_queue.t. 4. t/lib/sample_holds_queue.pl would be the first executable script in t/lib. Intentional, or should it live in misc/devel/? 5. Minor: does patron duplicate the existing borrower relationship because of the embed name?
I'm having some sort of deja-vu as I already fixed those in a local branch. I'll resubmit shortly. Also: the `t/lib/sample_holds.pl` commit was also `[DO NOT PUSH]`. Not sure how it got lost. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43130 [Bug 43130] Vue-ify the Holds queue report (circ/view_holdsqueue.pl) -- You are receiving this mail because: You are watching all bug changes.