http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |3.10 QA Contact| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment * passes koha-qa.pl * add a sub that is local to ILSDI/Service.pm, sounds fair (I'm just surprised that this sub was not needed before/outside from ILDSI...) * a question : Julian, did you notice that the - my $rank; + my $rank = _get_reserve_next_rank($biblionumber); is followed a few lines later by: $rank = '0' unless C4::Context->preference('ReservesNeedReturns'); Have you checked that it works as expected in all cases ? (just asking, I haven't proved there's a problem) -- You are receiving this mail because: You are watching all bug changes.