http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #76 from Owen Leonard <oleonard@myacpl.org> 2011-09-02 14:03:20 UTC --- (In reply to comment #60)
In the patch 'suggestion/suggestion.tt', in the second block of corrections, the semantic seems to not be preserved:
Here, just an example, for the first line (of second block): Orign: [% IF ( suggestion.statusselected_ASKED ) %] Patch: [% IF (statusselected_ASKED ) %]
I think this modification is correct. Line 305 of suggestion.pl: $template->param( "statusselected_$$suggestion_ref{'STATUS'}" =>1); It doesn't look like that variable needs any scope. My search of the source indicates that there isn't any other place where a variable with that name is created. The behavior of the page seems to be the same with our without the variable scope, and I think this is because the variable never evaluates as true. I think the logic around that <option> is unused. I can't see what circumstances would lead to that status having a preselected value. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.