https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #59 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #50)
1) Terminology
issue is not supposed to be used according to our terminology list. We prefer checkout. But... I am not sure what the better term for the person doing the checkout would be here. In some other cases we have used "manager" (accountlines). But if we wanted to record the person doing the checkin at some point, this won't work. For the pref... RecordStaffUserOnCheckout or similar could work. Overall not an easy one.
I'll only be asking for changes in the GUI.
+ - "When issuing an item, " + - pref: RecordIssuer + choices: + yes: "record" + no: "don't record" + - "the user who issued the item."
Please change to "staff user" and "issu*" to "check* out".
Everywhere else looks good.
Fixed, I've changed the syspref name as you suggested, I've also changed "issuer" to "staff who checked out the item" and "issue" to "check out"
2) Database update and installer don't match up
for old_issues.issuer we have default null in kohastructure.sql, but not in the database update.
Maybe this has been discussed, but why not default null on issues.issuer? On first glance it would make sense for me as we will also use NULL on all the old entries.
Fixed, it is now DEFAULT NULL for both kohastructure.sql and the update, for both issues and old_issues
3) Name display
+ <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% checkout.issuer | uri %]"> + [% checkout.issued_by.firstname | html %] [% checkout.issued_by.surname | html %]
I think we should use patron-title.inc here if possible.
Fixed
4) Tests fail :(
I've run the database update and dbic manually, but the tests are failing:
I can't replicate this (see below)
I hope I didn't mess up the rebase, so not attaching my patches here (had fixed a conflict in one of the test files).
You shouldn't need to rebase, the patches apply cleanly on top of master for me. Maybe try again? kohadev-koha@kohadevbox:/kohadevbox/koha$ ../qa-test-tools/koha-qa.pl -c 8 -v 2 testing 8 commit(s) (applied to 20022fa '21 Bug 22417: Add exec flag on .t fil') Processing files before patches |========================>| 11 / 11 (100.00%) Processing files after patches |========================>| 11 / 11 (100.00%) OK C4/Circulation.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid OK C4/Members.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid OK Koha/Checkout.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid OK Koha/Patrons.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid OK installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation OK tinyint_has_boolean_flag OK installer/data/mysql/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order OK koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template OK t/db_dependent/Circulation.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid OK t/db_dependent/Koha/Checkouts.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid OK t/db_dependent/Koha/Patrons.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes.