https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Christopher Brannon from comment #33)
(In reply to Jonathan Druart from comment #31)
Hi Christopher, I would suggest to move the display logic to the template for several reasons: - the pl logic from the first patch is not easy to read - not defined AV are handled properly by the template plugin (Koha::Template::Plugin::AuthorisedValues) - as we are going to reuse this logic, we will move it to an include file to avoid copy/paste
Could you take a look at tell me what you think about it?
Something funky is going on in your patch. item.location is resolving to a description while item.permanent_location is resolving to a code. Thus, the two can't be compared. Need to figure out where item.location is being defined, because when I look at the table, the code is definitely being stored in the table and not the description.
Can you confirm you applied *only* the second patch? -- You are receiving this mail because: You are watching all bug changes.