[Bug 18355] New: Permanent location should show with cart location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Bug ID: 18355 Summary: Permanent location should show with cart location Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com It would be helpful if the permanent location would show even when the cart location is in use. For example: Location CART (Adult Non-fiction) It is difficult to track an item if it has an unusual location, like a display location, and it is recently returned. This information should show anywhere the shelving location is displayed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 61978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61978&action=edit Bug 18355: Modifies location on detail pages. TEST PLAN 1) Make sure ReturnToShelvingCart is set to Move. 2) Check in an item. 3) View the item in detail.pl and opac-detail.pl and see that only the cart location shows. 4) Apply patch and view the item aga -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- Sorry, the attach turned out wonky. TEST PLAN 1) Make sure ReturnToShelvingCart is set to Move. 2) Check in an item. 3) View the item in detail.pl and opac-detail.pl and see that only the cart location shows. 4) Apply patch and view the item again in check detail.pl and opac-detail.pl. You should now see the permanent location, and the cart location in parenthesis. 5) Check another item that was not checked in. You should see the permanent location and not a secondary location. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- I'm not sure how to fix the subject in the attachment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61978|Bug 18355: Modifies |Bug 18355: Modifies description|location on detail pages. |location on detail pages. |TEST PLAN 1) Make sure | |ReturnToShelvingCart is set | |to Move. 2) Check in an | |item. 3) View the item in | |detail.pl and | |opac-detail.pl and see that | |only the cart location | |shows. 4) Apply patch and | |view the item aga | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cbrannon@cdalibrary.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- Never mind. I fixed it. :) I am only addressing the detail pages in the patch. I looked over the search results, and the item information is being pulled in differently, so I am not sure how to add the information there. It looks like it is being pulled in via marc records, which seems a little odd. Anyway, I consider this the extent of the patch. If there are other locations that would benefit from this added information, we can address it in another patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61978|0 |1 is obsolete| | --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 61981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61981&action=edit Attachment to Bug 18355 - Permanent location should show with cart location Bug 18355: Modifies location on detail pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 61984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61984&action=edit Bug 18355: Permanent location should show with cart location Followed test plan from Comment #2, tested on current Master, works as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #61981|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|3.22 |master --- Comment #7 from Marc Véron <veron@veron.ch> --- Setting version to master (tested on master) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- I like the idea, two strange display issues: 1 - Items with no location before cart display as "CART (Book Cart)", I would expect just to see "Book cart" 2 - Items with a shelving location not tied to an authorized value also display as "CART (Book Cart)" I would expect to see "Book Cart (value)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61984|0 |1 is obsolete| | --- Comment #9 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 62999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62999&action=edit Bug 18355: Modifies location on detail pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #10 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Nick Clemens from comment #8)
I like the idea, two strange display issues:
1 - Items with no location before cart display as "CART (Book Cart)", I would expect just to see "Book cart" 2 - Items with a shelving location not tied to an authorized value also display as "CART (Book Cart)" I would expect to see "Book Cart (value)"
Good catch. It is fixed. Didn't have the same issue on the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |alexbuckley@catalyst.net.nz --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Bug 18355 - Permanent location should show with cart location 62999 - Bug 18355: Modifies location on detail pages. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18355: Modifies location on detail pages. Using index info to reconstruct a base tree... M catalogue/detail.pl M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Auto-merging catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Christopher Can you please merge your patches with the up to date master branch? Cheers Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Alex Buckley from comment #12)
Can you please merge your patches with the up to date master branch?
Git properly merged this, there is no reason to mark this as does not apply. I, however, will push up a cleaner apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62999|0 |1 is obsolete| | --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 66432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66432&action=edit Bug 18355: Modifies location on detail pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #15 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to M. Tompsett from comment #13)
(In reply to Alex Buckley from comment #12)
Can you please merge your patches with the up to date master branch?
Git properly merged this, there is no reason to mark this as does not apply. I, however, will push up a cleaner apply.
Thank you. I have been swamped, and have been trying to figure out how to do this since I rebuilt my kohadevbox. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66432|0 |1 is obsolete| | --- Comment #16 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 66514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66514&action=edit Bug 18355: Modifies location on detail pages. TEST PLAN 1) Make sure ReturnToShelvingCart is set to Move. 2) Check in an item. 3) View the item in detail.pl and opac-detail.pl and see that only the cart location shows. 4) Apply patch and view the item again in check detail.pl and opac-detail.pl. You should now see the permanent location, and the cart location in parenthesis. 5) Check another item that was not checked in. You should see the permanent location and not a secondary location. Followed test plan, patch worked as described. Passes QA test Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #17 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Christopher Your patch works as described and I have signed off on it, I have added your test plan from comment 2 onto the patch as I know it makes it easier for the Release Manager -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #18 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Alex Buckley from comment #17)
Hi Christopher
Your patch works as described and I have signed off on it, I have added your test plan from comment 2 onto the patch as I know it makes it easier for the Release Manager
Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- If permanent_location is NULL the current location shows in parens If the current location is not defined in authorised values: On staff side there is nothing displayed (current behavior on staff sideshows the code) On OPAC you get blank parens for null permanent_location I think the proper logic is: 1 - If permanent location is defined a - display the description if available, display the code if not b - display the current location in parens 2 - If permanent location is not defined, but location is defined a - display the current location description if available, display the code if not 3 - If neither are defined, show nothing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66514|0 |1 is obsolete| | --- Comment #20 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 78584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78584&action=edit Bug 18355: Modifies location on detail pages. TEST PLAN 1) Make sure ReturnToShelvingCart is set to Move. 2) Check in an item. 3) View the item in detail.pl and opac-detail.pl and see that only the cart location shows. 4) Apply patch and view the item again in check detail and opac-detail.pl. You should now see the permanent location, and the cart location in parenthesis. 5) Try removing descriptions from locations. Codes should replace descriptions when not available. Nothing should show if a value (code is missing. 6) Check another item that was not checked in. You should see the permanent location and not a secondary location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | Status|Failed QA |Needs Signoff --- Comment #21 from Christopher Brannon <cbrannon@cdalibrary.org> --- Updated patch (FINALLY!) and updated test plan. Responded to Nick's concerns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 rkuiper@roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper@roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #22 from Christopher Brannon <cbrannon@cdalibrary.org> --- UPDATED TEST PLAN 1) Make sure ReturnToShelvingCart is set to Move. 2) Check in an item. 3) View the item in detail.pl and opac-detail.pl and see that only the cart location shows. 4) Apply patch and view the item again in check detail and opac-detail.pl. You should now see the permanent location, and the cart location in parenthesis. 5) Try removing descriptions from locations. Codes should replace descriptions when not available. 6) Check another item that was not checked in (don't check in). You should see the permanent location and not a secondary location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78584|0 |1 is obsolete| | --- Comment #23 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 78908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78908&action=edit Bug 18355: Modifies location on detail pages. TEST PLAN 1) Make sure ReturnToShelvingCart is set to Move. 2) Check in an item. 3) View the item in detail.pl and opac-detail.pl and see that only the cart location shows. 4) Apply patch and view the item again in check detail and opac-detail.pl. You should now see the permanent location, and the cart location in parenthesis. 5) Try removing descriptions from locations. Codes should replace descriptions when not available. Nothing should show if a value (code is missing. 6) Check another item that was not checked in. You should see the permanent location and not a secondary location. Signed-off-by: Spencer <ssmith3@mckinneytexas.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78908|0 |1 is obsolete| | --- Comment #24 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 78913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78913&action=edit Bug 18355: Modifies location on detail pages. TEST PLAN 1) Make sure ReturnToShelvingCart is set to Move. 2) Check in an item. 3) View the item in detail.pl and opac-detail.pl and see that only the cart location shows. 4) Apply patch and view the item again in check detail and opac-detail.pl. You should now see the permanent location, and the cart location in parenthesis. 5) Try removing descriptions from locations. Codes should replace descriptions when not available. Nothing should show if a value (code is missing. 6) Check another item that was not checked in. You should see the permanent location and not a secondary location. Signed-off-by: Spencer <ssmith3@mckinneytexas.org> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED Keywords|Academy | --- Comment #25 from Christopher Brannon <cbrannon@cdalibrary.org> --- Found a few more places to make this correction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #26 from Christopher Brannon <cbrannon@cdalibrary.org> --- I have decided to make other corrections in other patches so these can go out quicker. Returning to signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21444 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please resubmit without the indentation changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78913|0 |1 is obsolete| | --- Comment #28 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 79684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79684&action=edit Bug 18355: Modifies location on details pages. TEST PLAN: 1) Make sure ReturnToShelvingCart is set to Move. 2) Check in an item. 3) View the item in detail.pl and opac-detail.pl and see that only the cart location shows. 4) Apply patch and view the item again in check detail and opac-detail.pl. You should now see the permanent location, and the cart location in parenthesis. 5) Try removing descriptions from locations. Codes should replace descriptions when not available. Nothing should show if a value (code is missing. 6) Check another item that was not checked in. You should see the permanent location and not a secondary location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #29 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Jonathan Druart from comment #27)
Please resubmit without the indentation changes.
Sorry. Didn't understand this was an issue. Please look and see if this is okay now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79717&action=edit [ALTERNATIVE-PATCH %] Bug 18355: Display permanent location with cart location -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Christopher, I would suggest to move the display logic to the template for several reasons: - the pl logic from the first patch is not easy to read - not defined AV are handled properly by the template plugin (Koha::Template::Plugin::AuthorisedValues) - as we are going to reuse this logic, we will move it to an include file to avoid copy/paste Could you take a look at tell me what you think about it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #32 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Jonathan Druart from comment #31)
Hi Christopher, I would suggest to move the display logic to the template for several reasons: - the pl logic from the first patch is not easy to read - not defined AV are handled properly by the template plugin (Koha::Template::Plugin::AuthorisedValues) - as we are going to reuse this logic, we will move it to an include file to avoid copy/paste
Could you take a look at tell me what you think about it?
Jonathan, Thanks for the suggestion. I have no problem trying to move it to the tt. I put it in the pl because that is where it was already being done. Sorry for the short code. I opted for short code for efficiency but realize it isn't efficient for everyone else. I will work on keeping things more readable. Thank you for your input. I will work on this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #33 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Jonathan Druart from comment #31)
Hi Christopher, I would suggest to move the display logic to the template for several reasons: - the pl logic from the first patch is not easy to read - not defined AV are handled properly by the template plugin (Koha::Template::Plugin::AuthorisedValues) - as we are going to reuse this logic, we will move it to an include file to avoid copy/paste
Could you take a look at tell me what you think about it?
Something funky is going on in your patch. item.location is resolving to a description while item.permanent_location is resolving to a code. Thus, the two can't be compared. Need to figure out where item.location is being defined, because when I look at the table, the code is definitely being stored in the table and not the description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Christopher Brannon from comment #33)
(In reply to Jonathan Druart from comment #31)
Hi Christopher, I would suggest to move the display logic to the template for several reasons: - the pl logic from the first patch is not easy to read - not defined AV are handled properly by the template plugin (Koha::Template::Plugin::AuthorisedValues) - as we are going to reuse this logic, we will move it to an include file to avoid copy/paste
Could you take a look at tell me what you think about it?
Something funky is going on in your patch. item.location is resolving to a description while item.permanent_location is resolving to a code. Thus, the two can't be compared. Need to figure out where item.location is being defined, because when I look at the table, the code is definitely being stored in the table and not the description.
Can you confirm you applied *only* the second patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #35 from Christopher Brannon <cbrannon@cdalibrary.org> --- Yes. I checked for my mods and they are not there. Just yours. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #36 from Christopher Brannon <cbrannon@cdalibrary.org> --- I also did a restart just to be sure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #37 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 79786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79786&action=edit Bug 18355: Remove obsolete code from pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79684|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #38 from Christopher Brannon <cbrannon@cdalibrary.org> --- I've accepted the alternative patch as the better way to go. This patch will depend on fixing AuthorisedValues.pm, per our discussion, to display the code if a description doesn't exist. That will have to be fixed before this is pushed. :/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #39 from Christopher Brannon <cbrannon@cdalibrary.org> --- While this works properly, it will work better once 21503 is applied. As is, AuthoriseValues.pm (plugin) will not fail to code. 21503 will fix that issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #40 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80153&action=edit Bug 18355: Update opac-detail.pl/tt to show both Adding dependancy of bug 21503 for templates to fully fail correctly. To Test this patch: 1) Apply patch / restart_all 2) Check out an item. 3) Check item in with ReturnToShelvingCart set to Move. 4) View the item in opac-detail.pl and see the permanent location, and the cart location in parentesis. 5) Try removing opac description from the cart and item sleving location. Refresh opac-detail.pl. Should default to regular description. (If not, may need patch 21503 to test.) 6) To test for code replacement if regular and opac description are missing, you WILL need patch 21503. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21503 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80153|0 |1 is obsolete| | --- Comment #41 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Created attachment 83665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83665&action=edit Bug 18355: Update opac-detail.pl/tt to show both Adding dependancy of bug 21503 for templates to fully fail correctly. To Test this patch: 1) Apply patch / restart_all 2) Check out an item. 3) Check item in with ReturnToShelvingCart set to Move. 4) View the item in opac-detail.pl and see the permanent location, and the cart location in parentesis. 5) Try removing opac description from the cart and item sleving location. Refresh opac-detail.pl. Should default to regular description. (If not, may need patch 21503 to test.) 6) To test for code replacement if regular and opac description are missing, you WILL need patch 21503. Signed-off-by: Jose-Mario <jose-mario.monteiro-santos@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The status of all attached patches is not very clear. Please obsolete what is not relevant any more. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #79786|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83665|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21466 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95775&action=edit Bug 18355: Display permanent location with cart location Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79717|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95775|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 95879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95879&action=edit Bug 18355: Display permanent location with cart location Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #45 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 95880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95880&action=edit Bug 18355: (QA follow-up) Rearrange comments, improve code Comments were hard to read (for me) but tastes differ.. Code should reflect that permanent_location is a code and that location may be already an authval. See detail.pl: $item->{'location'} = $shelflocations->{$shelfcode} if ( defined( $shelfcode ) && defined($shelflocations) && exists( $shelflocations->{$shelfcode} ) ); Obviously, this kind of logic divided over two places should be reduced. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Permanent location should |Add 'permanent location' |show with cart location |alongside 'shelving | |location' when located on | |cart -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Currently awaiting QA of bug 21466 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_target | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org