https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152530&action=edit Bug 34035: Move translatable strings out of opac-bottom.inc: Tags This patch removes the definition of JS variables in opac-bottom.inc related to the tags feature. These strings can be wrapped in the __() function inside tags.js and they'll get picked up for translation. Some other tags-related JS variable definitions are removed from templates in favor of embedding them directly in the <script> block. To test you must have TagsEnabled set to "Allow." Apply the patch and log in to the OPAC. - Perform a catalog search and select some items in the result list. - Add the items to the cart and open the cart. - Check a box next to one of the titles in the cart. - Click the "Tag" link - Submit the "New tag" form without entering a tag. You should see "No tag was specified." - Perform the same test on the search results page both using the checkboxes and by clicking the "Add tag" link on an individual result. - Perform the same test on the bibliographic detail page. - When adding tags from the cart, result list, or detail page, confirm that the "Tags added: X" message is always displayed. - Test adding a tag to a title which is already attached to that title. - Test adding HTML markup, e.g. "<script>" - Test adding HTML markup and plain text, e.g. "<script>Foo" -- You are receiving this mail because: You are watching all bug changes.