https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152416&action=edit Bug 34035: Move translatable strings out of opac-bottom.inc: Tags This patch removes the definition of JS variables in opac-bottom.inc related to the tags feature. These strings can be wrapped in the __() function inside tags.js and they'll get picked up for translation. Some other tags-related JS variable definitions are removed from templates in favor of embedding them directly in the <script> block. To test you must have TagsEnabled set to "Allow." Apply the patch and log in to the OPAC. - Perform a catalog search and select some items in the result list. - Add the items to the cart and open the cart. - Check a box next to one of the titles in the cart. - Click the "Tag" link - Submit the "New tag" form without entering a tag. You should see "No tag was specified." - Perform the same test on the search results page both using the checkboxes and by clicking the "Add tag" link on an individual result. - Perform the same test on the bibliographic detail page. - When adding tags from the cart, result list, or detail page, confirm that the "Tags added: X" message is always displayed. - Test adding a tag to a title which is already attached to that title. - Test adding HTML markup, e.g. "<script>" - Test adding HTML markup and plain text, e.g. "<script>Foo" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152526&action=edit Bug 34035: Move translatable strings out of opac-bottom.inc: Tags This patch removes the definition of JS variables in opac-bottom.inc related to the tags feature. These strings can be wrapped in the __() function inside tags.js and they'll get picked up for translation. Some other tags-related JS variable definitions are removed from templates in favor of embedding them directly in the <script> block. To test you must have TagsEnabled set to "Allow." Apply the patch and log in to the OPAC. - Perform a catalog search and select some items in the result list. - Add the items to the cart and open the cart. - Check a box next to one of the titles in the cart. - Click the "Tag" link - Submit the "New tag" form without entering a tag. You should see "No tag was specified." - Perform the same test on the search results page both using the checkboxes and by clicking the "Add tag" link on an individual result. - Perform the same test on the bibliographic detail page. - When adding tags from the cart, result list, or detail page, confirm that the "Tags added: X" message is always displayed. - Test adding a tag to a title which is already attached to that title. - Test adding HTML markup, e.g. "<script>" - Test adding HTML markup and plain text, e.g. "<script>Foo" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152530&action=edit Bug 34035: Move translatable strings out of opac-bottom.inc: Tags This patch removes the definition of JS variables in opac-bottom.inc related to the tags feature. These strings can be wrapped in the __() function inside tags.js and they'll get picked up for translation. Some other tags-related JS variable definitions are removed from templates in favor of embedding them directly in the <script> block. To test you must have TagsEnabled set to "Allow." Apply the patch and log in to the OPAC. - Perform a catalog search and select some items in the result list. - Add the items to the cart and open the cart. - Check a box next to one of the titles in the cart. - Click the "Tag" link - Submit the "New tag" form without entering a tag. You should see "No tag was specified." - Perform the same test on the search results page both using the checkboxes and by clicking the "Add tag" link on an individual result. - Perform the same test on the bibliographic detail page. - When adding tags from the cart, result list, or detail page, confirm that the "Tags added: X" message is always displayed. - Test adding a tag to a title which is already attached to that title. - Test adding HTML markup, e.g. "<script>" - Test adding HTML markup and plain text, e.g. "<script>Foo" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152530|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 156699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156699&action=edit Bug 34035: Move translatable strings out of opac-bottom.inc: Tags This patch removes the definition of JS variables in opac-bottom.inc related to the tags feature. These strings can be wrapped in the __() function inside tags.js and they'll get picked up for translation. Some other tags-related JS variable definitions are removed from templates in favor of embedding them directly in the <script> block. To test you must have TagsEnabled set to "Allow." Apply the patch and log in to the OPAC. - Perform a catalog search and select some items in the result list. - Add the items to the cart and open the cart. - Check a box next to one of the titles in the cart. - Click the "Tag" link - Submit the "New tag" form without entering a tag. You should see "No tag was specified." - Perform the same test on the search results page both using the checkboxes and by clicking the "Add tag" link on an individual result. - Perform the same test on the bibliographic detail page. - When adding tags from the cart, result list, or detail page, confirm that the "Tags added: X" message is always displayed. - Test adding a tag to a title which is already attached to that title. - Test adding HTML markup, e.g. "<script>" - Test adding HTML markup and plain text, e.g. "<script>Foo" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156698|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156710&action=edit Bug 34035: (preparatory cleanup) Convert indentation to spaces. This patch converts tabs to spaces in tags.js. No other changes are made. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 Bug 34035 depends on bug 34034, which changed state. Bug 34034 Summary: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.