https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #7)
Created attachment 114810 [details] [review] Bug 25674: Adapt koha-create
This patch adds the following option switches to koha-create:
--mb-host --mb-port --mb-user --mb-pass --mb-vhost
They are used to override the default values on instance creation.
To test: 1. Play with the several option switches and verify that the resulting koha-conf.xml contains the expected data. => SUCCESS: It works as expected 2. Sign off :-D
My test plan: 1. cp debian/templates/koha-conf-site.xml.in /etc/koha/koha-conf-site.xml.in 2. cp debian/scripts/koha-create /usr/sbin/koha-create 3. koha-create --create-db --mb-host test1 --mb-port 8000 --mb-user test2 --mb-pass test3 --mb-vhost test4 test5 4. vi /etc/koha/sites/test5/koha-conf.xml 5. Note the following block near the bottom of the file: <message_broker> <hostname>test1</hostname> <port>8000</port> <username>test2</username> <password>test3</password> <vhost>test4</vhost> </message_broker> 6. koha-create --create-db test6 7. vi /etc/koha/sites/test6/koha-conf.xml 8. Note the following block near the bottom of the file: <message_broker> <hostname>localhost</hostname> <port>61613</port> <username>guest</username> <password>guest</password> <vhost>koha_test6</vhost> </message_broker> I'm failing QA because it sets the feature defaults to a vhost of "koha_test6" when the vhost should be set to nothing by default. If someone tried to use koha-create --create-db test6 without any other intervention, the RabbitMQ functionality wouldn't work out of the box. -- You are receiving this mail because: You are watching all bug changes.